From patchwork Tue Aug 15 08:22:49 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 9901247 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4C2AB60244 for ; Tue, 15 Aug 2017 08:23:35 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3BAA5287D4 for ; Tue, 15 Aug 2017 08:23:35 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 3099E287FB; Tue, 15 Aug 2017 08:23:35 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 82C0E287F0 for ; Tue, 15 Aug 2017 08:23:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:To:From:Subject:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UUVj6v5cNRa/9eYNyZ7ByFxPnRH/1QLkfnOLRqh0NEM=; b=iIb65vzs6dhr+f 2XmVoVRgy0WbSUwXdhHLU6vZJwVsg02IZjDmt6pKyyM5yQGEDKObBtsZKlBs826ZEO0HwCy3LWqkw A8wOhVDPhXVE5l+jxdtQapQ9/VsyYtnX3BwrAI2uMtUxdIY8rPkW4PItbXNnFDvPzYio+dvs9jbBY qQP5DyWy8hOdpgz5xm9GYkWjxIOsHY7MBcKSzdI9QZnnYGoq3k6vNEfRWIxKytEO7/IwdYnwo1etb E4duvdAriWdl+M87qYgBjZQQKdK56H1sIn2FZlpj198rhxRBq4PgmPfu+phJ6GR6Al2zCM+olnsG9 ifbnjIm7Nmuht1bdmPzw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1dhX8L-0001EH-Hz; Tue, 15 Aug 2017 08:23:29 +0000 Received: from sabertooth01.qualcomm.com ([65.197.215.72]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1dhX8H-0000lq-G7 for ath10k@lists.infradead.org; Tue, 15 Aug 2017 08:23:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1502785405; x=1534321405; h=subject:from:to:cc:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=lq5iV08QYa9egJI7KkkeUxStEnrpXAsUB/LPPUOXVaM=; b=kvTRgOkVi6knTTtg4ioiSmA40Mo+T45cPdJgi8O5C1r2NrEI/+6Z4d5S f+3jsaLHF9pg8Y/h/MXnv7s+TQxp+nXWcI8gLVD3/iUf1iZ3pxjfltg3o fnHQ+QxTy7FPEvrKrKTvKN+khqEJ2Umgvk84pHfBY7xrUehuhuN3i4Hl3 o=; X-IronPort-AV: E=Sophos;i="5.41,377,1498546800"; d="scan'208";a="112735834" Received: from unknown (HELO ironmsg02-R.qualcomm.com) ([10.53.140.106]) by sabertooth01.qualcomm.com with ESMTP; 15 Aug 2017 01:22:59 -0700 X-IronPort-AV: E=McAfee;i="5900,7806,8622"; a="1016282106" X-MGA-submission: =?us-ascii?q?MDFOTenY43xB+rwRTy16BCfuPBklG9+N58qdg+?= =?us-ascii?q?9Ap8/izwbBgolGfPKC58fjfbLktX8s7Viov0GJdRUjTGc0lE9gpcS7t4?= =?us-ascii?q?+CfJ02LyIzrBYXZrs7FWwjHNS8KhBJCTZGSuTZJ95q8BMey35v2kP5OU?= =?us-ascii?q?K8?= Received: from nasanexm02h.na.qualcomm.com ([10.85.0.89]) by ironmsg02-R.qualcomm.com with ESMTP/TLS/RC4-SHA; 15 Aug 2017 01:22:59 -0700 Received: from euamsexm01a.eu.qualcomm.com (10.251.127.40) by nasanexm02h.na.qualcomm.com (10.85.0.89) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Tue, 15 Aug 2017 01:22:58 -0700 Received: from potku.adurom.net (10.80.80.8) by euamsexm01a.eu.qualcomm.com (10.251.127.40) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Tue, 15 Aug 2017 10:22:54 +0200 Subject: [PATCH 1/6] ath10k: remove deprecated fw_crash_dump debugfs file From: Kalle Valo To: Date: Tue, 15 Aug 2017 11:22:49 +0300 Message-ID: <150278536928.22482.13768610556657786942.stgit@potku.adurom.net> In-Reply-To: <150278532045.22482.14490702801292107536.stgit@potku.adurom.net> References: <150278532045.22482.14490702801292107536.stgit@potku.adurom.net> User-Agent: StGit/0.17.1-17-ge4e0 MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01C.na.qualcomm.com (10.85.0.83) To euamsexm01a.eu.qualcomm.com (10.251.127.40) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170815_012325_666242_4C893C58 X-CRM114-Status: UNSURE ( 5.36 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-wireless@vger.kernel.org Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The fw_crash_dump file was deprecated by commmit 727000e6af34 ("ath10k: support dev_coredump for crash dump") in v4.11 in favor of dev_coredump interface, remove it now for good. Everyone should use dev_coredump now. Signed-off-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/debug.c | 46 ------------------------------- 1 file changed, 46 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c index df514507d3f1..266bb697d960 100644 --- a/drivers/net/wireless/ath/ath10k/debug.c +++ b/drivers/net/wireless/ath/ath10k/debug.c @@ -851,49 +851,6 @@ int ath10k_debug_fw_devcoredump(struct ath10k *ar) return 0; } -static int ath10k_fw_crash_dump_open(struct inode *inode, struct file *file) -{ - struct ath10k *ar = inode->i_private; - struct ath10k_dump_file_data *dump; - - ath10k_warn(ar, "fw_crash_dump debugfs file is deprecated, please use /sys/class/devcoredump instead."); - - dump = ath10k_build_dump_file(ar, true); - if (!dump) - return -ENODATA; - - file->private_data = dump; - - return 0; -} - -static ssize_t ath10k_fw_crash_dump_read(struct file *file, - char __user *user_buf, - size_t count, loff_t *ppos) -{ - struct ath10k_dump_file_data *dump_file = file->private_data; - - return simple_read_from_buffer(user_buf, count, ppos, - dump_file, - le32_to_cpu(dump_file->len)); -} - -static int ath10k_fw_crash_dump_release(struct inode *inode, - struct file *file) -{ - vfree(file->private_data); - - return 0; -} - -static const struct file_operations fops_fw_crash_dump = { - .open = ath10k_fw_crash_dump_open, - .read = ath10k_fw_crash_dump_read, - .release = ath10k_fw_crash_dump_release, - .owner = THIS_MODULE, - .llseek = default_llseek, -}; - static ssize_t ath10k_reg_addr_read(struct file *file, char __user *user_buf, size_t count, loff_t *ppos) @@ -2460,9 +2417,6 @@ int ath10k_debug_register(struct ath10k *ar) debugfs_create_file("simulate_fw_crash", 0600, ar->debug.debugfs_phy, ar, &fops_simulate_fw_crash); - debugfs_create_file("fw_crash_dump", 0400, ar->debug.debugfs_phy, ar, - &fops_fw_crash_dump); - debugfs_create_file("reg_addr", 0600, ar->debug.debugfs_phy, ar, &fops_reg_addr);