From patchwork Mon Feb 26 06:16:32 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthikeyan periyasamy X-Patchwork-Id: 10241307 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A43EB602DC for ; Mon, 26 Feb 2018 06:17:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9076B292AD for ; Mon, 26 Feb 2018 06:17:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8361B292AF; Mon, 26 Feb 2018 06:17:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0ED52292AD for ; Mon, 26 Feb 2018 06:17:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=qm90iPz/4bcBeNNoPF8xVCODtRni9JqhoiZmLm2mbeg=; b=d5/ duURN4rCSheKu0pao/UofBbrgx/8O2Mhbz8j5G2qveixJ+rg8mtbupXUI7D5+LdELIdwpHcvdGDV2 nYgytiJtO3blBlUcPcU9tlEQ+GY/rSJWePuLoiqc3DCyR1UlryZRa9QHUny+nOYVRLtJl0igi7Mev 7vzh1FnQJSM5Ls2z9pGYFuszayHYpTyAJSbXpvObFtMAS8k1V6h/ulSmCbzMlU3JLiYrOO5nU3wg4 bxmaCE+K6y1oBOhdClqc8rAqbEUDIDacQDUVykL4jjYcVqOaNVShD7Xi8pmaCMprYYhfLR0+NNOVW PrgXLU4J+TYbZ2lkTga8A87O0hleFJQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1eqC6I-0005XR-Dh; Mon, 26 Feb 2018 06:17:26 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1eqC69-0004B8-9k for ath10k@lists.infradead.org; Mon, 26 Feb 2018 06:17:22 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 332D760591; Mon, 26 Feb 2018 06:17:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519625826; bh=uN3XuxbueQXIOqmMmuEO5jXOOE+K2Ir0zfZ+igOzG9I=; h=From:To:Cc:Subject:Date:From; b=atoHI5zqB3UArkEwaGDBff0CI1pCrWEtC9W2fqoKnd5aEt2FeBu59/jE4eje1VCx+ AFnM8YIqypkTIWZmFXTk3p848fUMVWubQBof0+UBRSZhfVaP51gN9iFTfX69Kx5AfD llriHWOrnuf+CRMr9AvLQ0hrGQsVRgPwUuwnA47A= Received: from localhost (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: periyasa@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 06F6060390; Mon, 26 Feb 2018 06:17:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1519625825; bh=uN3XuxbueQXIOqmMmuEO5jXOOE+K2Ir0zfZ+igOzG9I=; h=From:To:Cc:Subject:Date:From; b=S+z+PvlEwnrom+cYLJzDwIC4TMsbxWRlesaXjkPVTYp3MgXWlAiFIt35RefXZP7lB Q3//E4p9O/+rRhGYj3VnxgWG96ZwKTZLIhgbY/+orqnvNVPXJl/p++bv6kMVx6Ieul AdKgfjfX8YiREJsSoIQvy35hstALQc7/8/B5g48E= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 06F6060390 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=periyasa@codeaurora.org From: Karthikeyan Periyasamy To: ath10k@lists.infradead.org Subject: [PATCH] Revert "ath10k: send (re)assoc peer command when NSS changed" Date: Mon, 26 Feb 2018 11:46:32 +0530 Message-Id: <1519625792-12010-1-git-send-email-periyasa@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180225_221717_689058_BF54DF1C X-CRM114-Status: UNSURE ( 9.02 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karthikeyan Periyasamy , linux-wireless@vger.kernel.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This reverts commit 55884c045d31a29cf69db8332d1064a1b61dd159. When Ath10k is in AP mode and an unassociated STA sends a VHT action frame (Operating Mode Notification for the NSS change) periodically to AP this causes ath10k to call ath10k_station_assoc() which sends WMI_PEER_ASSOC_CMDID during NSS update. Over the time (with a certain client it can happen within 15 mins when there are over 500 of these VHT action frames) continuous calls of WMI_PEER_ASSOC_CMDID cause firmware to assert due to resource exhaust. To my knowledge setting WMI_PEER_NSS peer param itself enough to handle NSS updates and no need to call ath10k_station_assoc(). So revert the original commit from 2014 as it's unclear why the change was really needed. Now the firmware assert doesn't happen anymore. Issue observed in QCA9984 platform with firmware version:10.4-3.5.3-00053. This Change tested in QCA9984 with firmware version: 10.4-3.5.3-00053 and QCA988x platform with firmware version: 10.2.4-1.0-00036. Signed-off-by: Karthikeyan Periyasamy --- drivers/net/wireless/ath/ath10k/mac.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c index ebb3f1b..800a86e 100644 --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -6028,9 +6028,8 @@ static void ath10k_sta_rc_update_wk(struct work_struct *wk) sta->addr, smps, err); } - if (changed & IEEE80211_RC_SUPP_RATES_CHANGED || - changed & IEEE80211_RC_NSS_CHANGED) { - ath10k_dbg(ar, ATH10K_DBG_MAC, "mac update sta %pM supp rates/nss\n", + if (changed & IEEE80211_RC_SUPP_RATES_CHANGED) { + ath10k_dbg(ar, ATH10K_DBG_MAC, "mac update sta %pM supp rates\n", sta->addr); err = ath10k_station_assoc(ar, arvif->vif, sta, true);