From patchwork Mon Sep 24 07:09:59 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anilkumar Kolli X-Patchwork-Id: 10611945 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 8B8B26CB for ; Mon, 24 Sep 2018 07:07:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8F5DC29BD9 for ; Mon, 24 Sep 2018 07:07:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8355129D15; Mon, 24 Sep 2018 07:07:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 24AC829BD9 for ; Mon, 24 Sep 2018 07:07:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=foCWQuCPgs9LMtc55BUFmJN9V6qCYS1YfP7KCcZW3DE=; b=Kf3zoDztA5M5OomW41M9GCxbvu 3Jo5Z36OQVV4d2NWEAeb1p+NYv1vJrD1Ks5YpMNxxsgCRPd8d7J2ukHXI73G0ELTr/NWFZF/UF5wi laz9YKlAu1cif35BG0WINFkAB6e5Eb7TbFj4C0BMaWv+hMlb+zLizmTjz8U5iN6vEib5w4MIeN9JI KwsmpvmWYzK1Z3B2MCZHQvBZ5dMP0GdKW6jqKJkbF2B1RpodU9orr5aPC+UwUeVL3xpsOWaSXZSFi p+ZQOOoZtZo+nlzjSEv4+yw0aA9chpXRm4O38OkW0/8S1nX6kuM2OVT/c3zmv5E7tDGOSvCSn/iKq 6nMMVZdg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1g4Ky9-0004qT-4U; Mon, 24 Sep 2018 07:07:45 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g4Ky5-0004l1-5h for ath10k@lists.infradead.org; Mon, 24 Sep 2018 07:07:42 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id DA298606DC; Mon, 24 Sep 2018 07:07:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537772850; bh=rvzZW35FllN5HF5WVn+cZ+gGNUjuWxH8TaAoiSovIg0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DZH+t1LPe2X1YQJUYTb7305C2Rb9WoYzdD+AwyCj6uslihMJRIvmup6FPFU6N5cWF vIZuULCv644FOfZ9VPz/6DkfbpgpJpwzoX45NYgEvpl0dPJeS74a4anfHffiWw7Q48 RUMFqyI2EgAdg7D1zJxSRGEVnSvOBOKNeddHJpkw= Received: from localhost (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) (Authenticated sender: akolli@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id DEFAA601C3; Mon, 24 Sep 2018 07:07:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1537772850; bh=rvzZW35FllN5HF5WVn+cZ+gGNUjuWxH8TaAoiSovIg0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DZH+t1LPe2X1YQJUYTb7305C2Rb9WoYzdD+AwyCj6uslihMJRIvmup6FPFU6N5cWF vIZuULCv644FOfZ9VPz/6DkfbpgpJpwzoX45NYgEvpl0dPJeS74a4anfHffiWw7Q48 RUMFqyI2EgAdg7D1zJxSRGEVnSvOBOKNeddHJpkw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org DEFAA601C3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=akolli@codeaurora.org From: Anilkumar Kolli To: ath10k@lists.infradead.org Subject: [RFC v4 1/2] mac80211: implement ieee80211_tx_rate_update to update rate Date: Mon, 24 Sep 2018 12:39:59 +0530 Message-Id: <1537773000-2587-2-git-send-email-akolli@codeaurora.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1537773000-2587-1-git-send-email-akolli@codeaurora.org> References: <1537773000-2587-1-git-send-email-akolli@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180924_000741_310107_CB1EF8FF X-CRM114-Status: UNSURE ( 9.62 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Anilkumar Kolli , linux-wireless@vger.kernel.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Current mac80211 has provision to update tx status through ieee80211_tx_status() and ieee80211_tx_status_ext(). But drivers like ath10k updates the tx status from the skb except txrate, txrate will be updated from a different path, peer stats. Using ieee80211_tx_status_ext() in two different paths - (one for the stats, one for the tx rate) will duplicate the stats. To avoid this stats duplication, ieee80211_tx_rate_update() is implemented. Signed-off-by: Anilkumar Kolli --- V3: - Added new API in mac80211 to update tx rate(Johannes) V4: - Removed non NULL check on pubsta and updated comments on ieee80211_tx_rate_update() include/net/mac80211.h | 15 +++++++++++++++ net/mac80211/status.c | 22 ++++++++++++++++++++++ 2 files changed, 37 insertions(+) diff --git a/include/net/mac80211.h b/include/net/mac80211.h index 8c26d2d36cbe..86f6253a68c4 100644 --- a/include/net/mac80211.h +++ b/include/net/mac80211.h @@ -4331,6 +4331,21 @@ void ieee80211_sta_set_expected_throughput(struct ieee80211_sta *pubsta, u32 thr); /** + * ieee80211_tx_rate_update - transmit rate update callback + * + * Drivers should call this functions with a non-NULL pubsta + * This function can be used in drivers that does not have provision + * in updating the tx rate in data path. + * + * @hw: the hardware the frame was transmitted by + * @pubsta: the station to update the tx rate for. + * @info: tx status information + */ +void ieee80211_tx_rate_update(struct ieee80211_hw *hw, + struct ieee80211_sta *pubsta, + struct ieee80211_tx_info *info); + +/** * ieee80211_tx_status - transmit status callback * * Call this function for all transmitted frames after they have been diff --git a/net/mac80211/status.c b/net/mac80211/status.c index 9a6d7208bf4f..a67547970a36 100644 --- a/net/mac80211/status.c +++ b/net/mac80211/status.c @@ -988,6 +988,28 @@ void ieee80211_tx_status_ext(struct ieee80211_hw *hw, } EXPORT_SYMBOL(ieee80211_tx_status_ext); +void ieee80211_tx_rate_update(struct ieee80211_hw *hw, + struct ieee80211_sta *pubsta, + struct ieee80211_tx_info *info) +{ + struct ieee80211_local *local = hw_to_local(hw); + struct ieee80211_supported_band *sband; + struct sta_info *sta; + struct ieee80211_tx_status status; + + sband = hw->wiphy->bands[info->band]; + + sta = container_of(pubsta, struct sta_info, sta); + status.skb = NULL; + status.info = info; + status.sta = pubsta; + + rate_control_tx_status(local, sband, &status); + if (ieee80211_hw_check(&local->hw, HAS_RATE_CONTROL)) + sta->tx_stats.last_rate = info->status.rates[0]; +} +EXPORT_SYMBOL(ieee80211_tx_rate_update); + void ieee80211_report_low_ack(struct ieee80211_sta *pubsta, u32 num_packets) { struct sta_info *sta = container_of(pubsta, struct sta_info, sta);