From patchwork Mon Feb 18 06:14:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wen Gong X-Patchwork-Id: 10817365 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2E4891390 for ; Mon, 18 Feb 2019 06:15:23 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 18B862A40E for ; Mon, 18 Feb 2019 06:15:23 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0940E2A431; Mon, 18 Feb 2019 06:15:23 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 976652A40E for ; Mon, 18 Feb 2019 06:15:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=Gvwishy87720hW43jOpDeE+Yc2pAM9+P1x+RHnLRNhs=; b=ej3 EFl0JdMgYIPRh6UWv3hsoLhjUpXxUlyq4JfShBeMh1nyY4u7sE4QtidMBJfSHyAn20Yz2VsMnZM+f hXIqFhk2f1uA5P4UFRGYSK0DTDQ5F/KB2HI47NZFB58EQ7UzfmNDATYRa66/RYmG/yrNt6zWb23z0 OHF7Ah4hNpsnQR3P3G1GzUvSJQdfSTqRvf7wL06MPbErHlW90UC9CZbeClRj1C9YkIDuixJTrbEaJ VsOkV8Lvd4bq9CnMkQReaYDielTUMd7sG0dEDNH3kRRrvFtiiqTsL/+arcYPBYO4DAdAQmUv6ZS0N jOY19C2GoNpIlum9/4x0S/f3I/O1gXQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gvcD2-00060B-KX; Mon, 18 Feb 2019 06:15:20 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gvcCz-0005zo-TI for ath10k@lists.infradead.org; Mon, 18 Feb 2019 06:15:19 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 0AE3460500; Mon, 18 Feb 2019 06:15:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1550470516; bh=fdnLzBqaHlpkKFft5Fkcwt1PjsGTpovhyuNbIQbPNSY=; h=From:To:Cc:Subject:Date:From; b=YBFJAWohLDhCu9/bpVGnVfoMtleMWEC1++MmHv9qe3kwU2eeEW4edIGTDvZ8VrB5v 8rCfQlMVo0E7TH1kNJQ5+1JK1eNXMLcILT/wa4xJDEfn41eEv6zIrtRW0q2mgc1amt qBjn6u4IzONH2rdPBhbDVPoccKgxLKDRU7OXSaG8= Received: from localhost.localdomain (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: wgong@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id B5E0D60500; Mon, 18 Feb 2019 06:15:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1550470515; bh=fdnLzBqaHlpkKFft5Fkcwt1PjsGTpovhyuNbIQbPNSY=; h=From:To:Cc:Subject:Date:From; b=JhQ5d3RHpohgc0xHNZXckpOgeDjC2Q9v6ov/BJ/JZfD91fOQm1Kp6lApDihUgLwuA 0dTJfmeo/DIFNlw71NS93Vhm2DcCylhsIfrNaUfDYqjCgKU80CT5SOjASHzEDLfamF eXGue8Eal2h6EQ08igZaByg3vlp7vVNXmOKgq2sY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B5E0D60500 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=wgong@codeaurora.org From: Wen Gong To: ath10k@lists.infradead.org Subject: [PATCH] ath10k: remove the calibration data fetch for sdio Date: Mon, 18 Feb 2019 14:14:31 +0800 Message-Id: <1550470471-28002-1-git-send-email-wgong@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190217_221517_966192_97CB535C X-CRM114-Status: UNSURE ( 8.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-wireless@vger.kernel.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The calibration data fetch will trigger sdio error, then sdio will become fail untill reboot system. If happens when run ifconfig wlan down, then ifconfig wlan up will fail untill reboot system.Remove it fix the ifconfig wlan issue. Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00005-QCARMSWP-1. Signed-off-by: Wen Gong --- drivers/net/wireless/ath/ath10k/debug.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/debug.c b/drivers/net/wireless/ath/ath10k/debug.c index 15964b3..c33a51f 100644 --- a/drivers/net/wireless/ath/ath10k/debug.c +++ b/drivers/net/wireless/ath/ath10k/debug.c @@ -1263,6 +1263,9 @@ static int ath10k_debug_cal_data_fetch(struct ath10k *ar) if (WARN_ON(ar->hw_params.cal_data_len > ATH10K_DEBUG_CAL_DATA_LEN)) return -EINVAL; + if (ar->hw_params.cal_data_len == 0) + return -EOPNOTSUPP; + hi_addr = host_interest_item_address(HI_ITEM(hi_board_data)); ret = ath10k_hif_diag_read(ar, hi_addr, &addr, sizeof(addr));