From patchwork Tue May 14 09:01:47 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yibo Zhao X-Patchwork-Id: 10942555 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 990CC924 for ; Tue, 14 May 2019 09:02:59 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 841C420134 for ; Tue, 14 May 2019 09:02:59 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 781A5285ED; Tue, 14 May 2019 09:02:59 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 1EC4B20134 for ; Tue, 14 May 2019 09:02:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=SuuTFRxh3B0pxKQJMb0WSEPS9b1cC97CnwQ6FWhlbYs=; b=Ekr Did7nOHJiYOzfAtFn1SiH5wfnz8C/WwwAfb1PNLDUnMMpch6g8kYnHEKP9RKn05TwN6+jCkiJWN8q 3cM8mlqxw79q4AYH9LUZSyvU8/7u3DqV2wGPlYGmTieh9rhRpmDE0dbGPqOHC40XJC7wjb7+e/h4t mvPk4/jd+Wn7AsAkn3U3aJrEB3KH/ITNvJYrxgE+ZBq0bfxEq45HpDr2wWUxIDdtglYrCcuVSWkA+ /TWQPRFmVCzDzB7kCsly8yVaE+qrKrTpfA3LvOk0sVYqr9+oDk2srwrui5bGAqcL0S19Uac7AVwqt SYo1poV1cjS4n/no+U6TDOr8RNVqZ9Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQTKb-0000kq-No; Tue, 14 May 2019 09:02:41 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQTKY-0000kN-NJ for ath10k@lists.infradead.org; Tue, 14 May 2019 09:02:39 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5FAEA60D0C; Tue, 14 May 2019 09:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1557824557; bh=bD3iKG3E35Kj0ikXVqdS2I0jjn4uY5AlrqsINgImqeU=; h=From:To:Cc:Subject:Date:From; b=lQGrLec8asJb4BP/irX+jFiOofqivLmx+wcxp3BADRsbEWl2loplL/KMJrdJL1zBD NCLBTgwqHs1D70BafF4qNkMqwBsktCQEphNSQmHc5J/G5SA62zS6mCwkdwBQnOu8N0 2yknDrZ/GdhlGsm76pkdjobscd4kxc+q0HG+2Cos= Received: from ybzhao-Latitude-E5440.ap.qualcomm.com (unknown [180.166.53.21]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: yiboz@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 290BB60AD1; Tue, 14 May 2019 09:02:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1557824556; bh=bD3iKG3E35Kj0ikXVqdS2I0jjn4uY5AlrqsINgImqeU=; h=From:To:Cc:Subject:Date:From; b=CeUahC1aV4y4hbSR9/geqZ7Tpi16izgANknnRruL0xNyjdw1TLeKIfY+T8AtZQ9gV tRKiHe6c7GfUZuMVovuFRTV6usdvC1diqKknmOw8TgBBPh1ssTIhiCGQ7kUSg3jogo kMmg6OnFc5q/9sRNsnwX8w39tyUBUEauEXI5r2Nw= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 290BB60AD1 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=yiboz@codeaurora.org From: Yibo Zhao To: linux-wireless@vger.kernel.org Subject: [PATCH v2] mac80211: remove warning message Date: Tue, 14 May 2019 17:01:47 +0800 Message-Id: <1557824507-17668-1-git-send-email-yiboz@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190514_020238_807787_5307BB9E X-CRM114-Status: GOOD ( 11.83 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Zhi Chen , Yibo Zhao , ath10k@lists.infradead.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP In multiple SSID cases, it takes time to prepare every AP interface to be ready in initializing phase. If a sta already knows everything it needs to join one of the APs and sends authentication to the AP which is not fully prepared at this point of time, AP's channel context could be NULL. As a result, warning message occurs. Even worse, if the AP is under attack via tools such as MDK3 and massive authentication requests are received in a very short time, console will be hung due to kernel warning messages. If this case can be hit during normal functionality, there should be no WARN_ON(). Those should be reserved to cases that are not supposed to be hit at all or some other more specific cases like indicating obsolete interface. Signed-off-by: Zhi Chen Signed-off-by: Yibo Zhao --- net/mac80211/ieee80211_i.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/ieee80211_i.h b/net/mac80211/ieee80211_i.h index 073a823..f39c289 100644 --- a/net/mac80211/ieee80211_i.h +++ b/net/mac80211/ieee80211_i.h @@ -1435,7 +1435,7 @@ struct ieee80211_local { rcu_read_lock(); chanctx_conf = rcu_dereference(sdata->vif.chanctx_conf); - if (WARN_ON(!chanctx_conf)) { + if (!chanctx_conf) { rcu_read_unlock(); return NULL; }