| Message ID | 20160912141105.24085-1-benjamin@sipsolutions.net (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Kalle Valo |
| Headers | show |
Benjamin Berg <benjamin@sipsolutions.net> writes: > The patch "ath10k: allow setting coverage class" was missing a check for > CONFIG_ATH10K_DEBUGFS so it would try to use non-existing struct elements > in some configurations. Fix this by adding the appropriate ifdef. > > Signed-off-by: Benjamin Berg <benjamin@sipsolutions.net> > --- > > Sorry, so turns out the kbuild test robot is correct and I forgot the ifdef > to check for CONFIG_ATH10K_DEBUGFS, so here a fixup commit for it. > > Other than that everything looks good to me in the pending branch. Thanks, I folded this to the original patch in the pending branch.
diff --git a/drivers/net/wireless/ath/ath10k/hw.c b/drivers/net/wireless/ath/ath10k/hw.c index c52b5f4..e182f09 100644 --- a/drivers/net/wireless/ath/ath10k/hw.c +++ b/drivers/net/wireless/ath/ath10k/hw.c @@ -338,8 +338,13 @@ static void ath10k_hw_qca988x_set_coverage_class(struct ath10k *ar, * set the registers again if the firmware does an internal reset and * this way we will be notified of the event. */ +#ifdef CONFIG_ATH10K_DEBUGFS fw_dbglog_mask = ar->debug.fw_dbglog_mask; fw_dbglog_level = ar->debug.fw_dbglog_level; +#else + fw_dbglog_mask = 0; + fw_dbglog_level = 0; +#endif if (value > 0) { if (fw_dbglog_level > ATH10K_DBGLOG_LEVEL_WARN)
The patch "ath10k: allow setting coverage class" was missing a check for CONFIG_ATH10K_DEBUGFS so it would try to use non-existing struct elements in some configurations. Fix this by adding the appropriate ifdef. Signed-off-by: Benjamin Berg <benjamin@sipsolutions.net> --- Sorry, so turns out the kbuild test robot is correct and I forgot the ifdef to check for CONFIG_ATH10K_DEBUGFS, so here a fixup commit for it. Other than that everything looks good to me in the pending branch. Benjamin drivers/net/wireless/ath/ath10k/hw.c | 5 +++++ 1 file changed, 5 insertions(+)