From patchwork Mon Apr 23 20:12:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andres Rodriguez X-Patchwork-Id: 10358089 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 2D39260209 for ; Mon, 23 Apr 2018 20:14:25 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1C5C728C29 for ; Mon, 23 Apr 2018 20:14:25 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0F23228C2D; Mon, 23 Apr 2018 20:14:25 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AB9E928C29 for ; Mon, 23 Apr 2018 20:14:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=Q0E9hDZVeIZyiKe2ViRFV7cWJd/+tel+EWPHRnzWpII=; b=Dt6LDGhijt5+40XU1uXgRGx7B8 OFSGNUxojfsqvfi7QNfVG9uuLx/Al7JySmnYnOq1cQBczUNIMvdsBqLs0NZOPJtW0w65bdhNfCrQ5 C/NT448p7OekOfVGm9mxkvV7ZUYCmyVtXGdME9kosrwXpqWJX596YUgm5CRa42f180WJyBrfOQndx GRfYIuB+h8z35WYMMsd4q52Wg3MuOYfE+xD3DUYMuncefYVMBM2P6AKRjBVH3QzKFmqx52bSbsVfd ZeFJDJF2C+TRkBWEORqFKJK0IhGZTZbK96Fy3Q8IyZaoiz6R+bl46QoQ+qGrNdEx5GEZGNQSGegF/ qBExrOww==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fAhqq-0005ly-EJ; Mon, 23 Apr 2018 20:14:16 +0000 Received: from mail-it0-x242.google.com ([2607:f8b0:4001:c0b::242]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fAhpF-0004rU-Kz for ath10k@lists.infradead.org; Mon, 23 Apr 2018 20:12:51 +0000 Received: by mail-it0-x242.google.com with SMTP id m134-v6so12623517itb.3 for ; Mon, 23 Apr 2018 13:12:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jKkPtOxxsOO/OOaOXa1om3vVQfSWXWBuAWW8jjohDgs=; b=ZQ2qhiaVBGDVUFV2DRH1EQKfpvLP/n4UdLLGGFeGs2taUY8WX+M2uEv+5jlredqyTm A0SZvD9XnFov8Rvuo5B2yFRLu36E34UaKqBUxjd2Tyew8tROMpqCOe4gQx9MLHr/f3tq Y9cwkNQtrhN1iFDmro2KTjHQC7BABZy2mlrYqLq8LQKkJ5tn8nN/3TZeY9Ln9k1kPzn0 gQNNWg/4oOU3+P8ALKQZ56Zs0rl6mxOqm6dqPXH3VO879puWCuGNWb3D+R9epLQMC4Hv 4c2nK6XIjTLrwWhF46cOVjaD1mkXbVYT839Yr2kXTlW+rWbD5WyqvOt+GUQCXzGRBHUZ horQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jKkPtOxxsOO/OOaOXa1om3vVQfSWXWBuAWW8jjohDgs=; b=VNB+rTPjas7H1eO9xY8qjkfPpdXP14wBkwDMBFOSNtcmx0te0102gzBz53cv0Jxez8 x2Qi+4IdapRDN2O9lBgL0M5NzLxauL31EveibyZvn3f6tMl8bgLEyOEXjxOcJ4fxsr94 qvfBqGqLBsyk+9WmgP8T3bGj5Z3oaMs7HG4FSi+1C0bVl5NoDkhtCTypUJOL7kkTXcf2 1j5hX/gYENWFJtv/aPAX07JJNhJZvucr7fd7DZxpIBSW8SIE2/TLg9kXMGXPGEgUaa5l u0+k35ZrnJb8x74slOIAULnkLxNHgU1WUBJITkKq8HVf9KVsjChrhoRU6Zv+nHb2+zts rZ0Q== X-Gm-Message-State: ALQs6tCATlv4S+L9tbR4m1koLk6RHRTv40FvSP0MuJ5qgWw0r/J6z4vl IzHpm1sWtsxJASpcUWRsgoU= X-Google-Smtp-Source: AIpwx4/XgsWHPjDVHMR93bFF2M7zVdmhhu6D7Rcoy7Mpv5TWULb81up5d0CT6RSQyRxEJB6U/SBSFw== X-Received: by 2002:a24:b953:: with SMTP id k19-v6mr10534266iti.140.1524514346193; Mon, 23 Apr 2018 13:12:26 -0700 (PDT) Received: from localhost.localdomain (184-175-36-239.dsl.teksavvy.com. [184.175.36.239]) by smtp.gmail.com with ESMTPSA id k130-v6sm1632551itb.0.2018.04.23.13.12.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Apr 2018 13:12:25 -0700 (PDT) From: Andres Rodriguez To: linux-kernel@vger.kernel.org Subject: [PATCH 9/9] ath10k: re-enable the firmware fallback mechanism for testmode Date: Mon, 23 Apr 2018 16:12:05 -0400 Message-Id: <20180423201205.20533-10-andresx7@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180423201205.20533-1-andresx7@gmail.com> References: <20180423201205.20533-1-andresx7@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180423_131237_730749_48C4849D X-CRM114-Status: GOOD ( 10.66 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arend.vanspriel@broadcom.com, gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, hdegoede@redhat.com, mcgrof@kernel.org, andresx7@gmail.com, alexdeucher@gmail.com, christian.koenig@amd.com, kvalo@codeaurora.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The ath10k testmode uses request_firmware_direct() in order to avoid producing firmware load warnings. Disabling the fallback mechanism was a side effect of disabling warnings. We now have a new API that allows us to avoid warnings while keeping the fallback mechanism enabled. So use that instead. Signed-off-by: Andres Rodriguez Acked-by: Kalle Valo --- drivers/net/wireless/ath/ath10k/testmode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/testmode.c b/drivers/net/wireless/ath/ath10k/testmode.c index 568810b41657..0beb91be1b1c 100644 --- a/drivers/net/wireless/ath/ath10k/testmode.c +++ b/drivers/net/wireless/ath/ath10k/testmode.c @@ -157,7 +157,7 @@ static int ath10k_tm_fetch_utf_firmware_api_1(struct ath10k *ar, ar->hw_params.fw.dir, ATH10K_FW_UTF_FILE); /* load utf firmware image */ - ret = request_firmware_direct(&fw_file->firmware, filename, ar->dev); + ret = request_firmware_nowarn(&fw_file->firmware, filename, ar->dev); ath10k_dbg(ar, ATH10K_DBG_TESTMODE, "testmode fw request '%s': %d\n", filename, ret);