From patchwork Mon Apr 23 20:12:00 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andres Rodriguez X-Patchwork-Id: 10358061 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D69F36038F for ; Mon, 23 Apr 2018 20:13:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C689328C29 for ; Mon, 23 Apr 2018 20:13:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BAF3828C2D; Mon, 23 Apr 2018 20:13:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 28DF228C29 for ; Mon, 23 Apr 2018 20:13:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=4CJrCwI+gAzuoYdMPv/m2/d81Igw/9LpA+u5vqlKgkc=; b=US351R/UQQ0I9qWLf3NzIEiELK hLeClkrCMGK31y5wJnFd5RQKpePWQGkgH8hnzd7yUDpR/km/24ccGiAQ13nLNrO7I4KfwBL1ulTT4 alGRJZ5xIDt3noCFAHfIf1kh+G0MYuAzYhuoX9Du63KP0wrq0pb2alxQVyxuMydKpJAn9VRzNU1QT U110BivhvmFbt+IGeDHiQvz9gxrn0BiU3ASCdwR169iMXQTk8De1zWucVlX/dmYCcqAGFamFeOajp PjS9N1FuYKjao2dbUGY3KwHEG1RuWXMkagrzRJEKLGxggmUHVSzST01F8AZiBu8QHAdnZv5JDtJhD Ee8LM5rg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fAhpu-0005Ap-6L; Mon, 23 Apr 2018 20:13:18 +0000 Received: from mail-it0-x243.google.com ([2607:f8b0:4001:c0b::243]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fAhp6-0004nv-Fq for ath10k@lists.infradead.org; Mon, 23 Apr 2018 20:12:36 +0000 Received: by mail-it0-x243.google.com with SMTP id f6-v6so12635546ita.2 for ; Mon, 23 Apr 2018 13:12:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=QFmqh8gQId75ySBJi9ID6wXFA7zeevmisgtCcHQP264=; b=pgAVEyXWiqlyysPwDHlO45Ldm2OPBA6JbaunrFY22LE51nEM3gENJi0KwpZu+YGLD1 5j7ifYIU1HSKWrh+dXE4ayjZuLZlTTpL3NZ5LthUAqZo6mBkVnYolorQ80rHUkgUaAH7 nypGT5WTGHEzwFl633dSCNYAzdss0oLkFJYOiz5UsT8PH8oz41mnZwiHjA3nYQibH/un zHI5IjOWjIR8T4Atdh7Q61RVQ4eTtuajltstvvBgSbm4CzBkEFUEyjJHyBTdB+yk4EdL E4vAE640p7pamzh1/HVunF5j4WucosQCCuo7nea+zaHWuqbJiGJ6WYBvvqFnQx1u4NZs UR/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=QFmqh8gQId75ySBJi9ID6wXFA7zeevmisgtCcHQP264=; b=nicJZCJ2TrIXuKhY3FQfjh9D71/SDy65vIzw/UiYweQktExRFx4okaD2v1CHwN1oIm /wSYVA+yRzaH+2tMCwJFbn9LTI2Qhvhotb3Ql9pi09OQLxt+3bDalj3CpJRnrR6v0jvJ hKno9C/phurgjdKQc0wHoe7bQJbpf1uVYFQ4SquJDhtHFxwU147/rKpU0jJTDzEsRBp4 VihgRgJ4NmNwk7P+Leznf5Me3VBKT+gFGEyuWuLNMC2/aZwI1LXVIHSO/cqDrtmsiyNt fDFk82PAOXUweQSzXTkdhKvEGxhWCKuWdUpmm1rG/fJQ0M/uBOVZ1CPzgUaeSI0rYTr0 11UQ== X-Gm-Message-State: ALQs6tDPZ4eDUnpzZWVw5K4Fq8Vn+TbqIQNHgSLWC/Z+5KCXNiPd1d6m N2WzQupf5QYypWUsnQ9sXu4= X-Google-Smtp-Source: AB8JxZooRKcGVp+yOVifWwdiRklFx7zY8Qf4tInpnC3NmY6RCZpFqQkcrn4CyZycs2pxVIZIn0KecA== X-Received: by 2002:a24:1946:: with SMTP id b67-v6mr15833306itb.63.1524514339801; Mon, 23 Apr 2018 13:12:19 -0700 (PDT) Received: from localhost.localdomain (184-175-36-239.dsl.teksavvy.com. [184.175.36.239]) by smtp.gmail.com with ESMTPSA id k130-v6sm1632551itb.0.2018.04.23.13.12.18 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Apr 2018 13:12:19 -0700 (PDT) From: Andres Rodriguez To: linux-kernel@vger.kernel.org Subject: [PATCH 4/9] firmware: use () to terminate kernel-doc function names Date: Mon, 23 Apr 2018 16:12:00 -0400 Message-Id: <20180423201205.20533-5-andresx7@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180423201205.20533-1-andresx7@gmail.com> References: <20180423201205.20533-1-andresx7@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180423_131228_594181_9318D5F4 X-CRM114-Status: GOOD ( 12.68 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arend.vanspriel@broadcom.com, gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, hdegoede@redhat.com, mcgrof@kernel.org, andresx7@gmail.com, alexdeucher@gmail.com, christian.koenig@amd.com, kvalo@codeaurora.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP The kernel-doc spec dictates a function name ends in (). Signed-off-by: Andres Rodriguez Acked-by: Randy Dunlap --- drivers/base/firmware_loader/fallback.c | 8 ++++---- drivers/base/firmware_loader/main.c | 22 +++++++++++----------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index ecc49a619298..e75928458489 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c @@ -124,7 +124,7 @@ static ssize_t timeout_show(struct class *class, struct class_attribute *attr, } /** - * firmware_timeout_store - set number of seconds to wait for firmware + * firmware_timeout_store() - set number of seconds to wait for firmware * @class: device class pointer * @attr: device attribute pointer * @buf: buffer to scan for timeout value @@ -238,7 +238,7 @@ static int map_fw_priv_pages(struct fw_priv *fw_priv) } /** - * firmware_loading_store - set value in the 'loading' control file + * firmware_loading_store() - set value in the 'loading' control file * @dev: device pointer * @attr: device attribute pointer * @buf: buffer to scan for loading control value @@ -430,7 +430,7 @@ static int fw_realloc_pages(struct fw_sysfs *fw_sysfs, int min_size) } /** - * firmware_data_write - write method for firmware + * firmware_data_write() - write method for firmware * @filp: open sysfs file * @kobj: kobject for the device * @bin_attr: bin_attr structure @@ -536,7 +536,7 @@ fw_create_instance(struct firmware *firmware, const char *fw_name, } /** - * fw_load_sysfs_fallback - load a firmware via the sysfs fallback mechanism + * fw_load_sysfs_fallback() - load a firmware via the sysfs fallback mechanism * @fw_sysfs: firmware sysfs information for the firmware to load * @opt_flags: flags of options, FW_OPT_* * @timeout: timeout to wait for the load diff --git a/drivers/base/firmware_loader/main.c b/drivers/base/firmware_loader/main.c index 5baadad3012d..d028cd3257f7 100644 --- a/drivers/base/firmware_loader/main.c +++ b/drivers/base/firmware_loader/main.c @@ -597,7 +597,7 @@ _firmware_request(const struct firmware **firmware_p, const char *name, } /** - * firmware_request: - send firmware request and wait for it + * firmware_request() - send firmware request and wait for it * @firmware_p: pointer to firmware image * @name: name of firmware file * @device: device for which firmware is being loaded @@ -632,7 +632,7 @@ firmware_request(const struct firmware **firmware_p, const char *name, EXPORT_SYMBOL(firmware_request); /** - * firmware_request_direct: - load firmware directly without usermode helper + * firmware_request_direct() - load firmware directly without usermode helper * @firmware_p: pointer to firmware image * @name: name of firmware file * @device: device for which firmware is being loaded @@ -657,7 +657,7 @@ int firmware_request_direct(const struct firmware **firmware_p, EXPORT_SYMBOL_GPL(firmware_request_direct); /** - * firmware_request_cache: - cache firmware for suspend so resume can use it + * firmware_request_cache() - cache firmware for suspend so resume can use it * @name: name of firmware file * @device: device for which firmware should be cached for * @@ -681,7 +681,7 @@ int firmware_request_cache(struct device *device, const char *name) EXPORT_SYMBOL_GPL(firmware_request_cache); /** - * firmware_request_into_buf - load firmware into a previously allocated buffer + * firmware_request_into_buf() - load firmware into a previously allocated buffer * @firmware_p: pointer to firmware image * @name: name of firmware file * @device: device for which firmware is being loaded and DMA region allocated @@ -713,7 +713,7 @@ firmware_request_into_buf(const struct firmware **firmware_p, const char *name, EXPORT_SYMBOL(firmware_request_into_buf); /** - * firmware_release: - release the resource associated with a firmware image + * firmware_release() - release the resource associated with a firmware image * @fw: firmware resource to release **/ void firmware_release(const struct firmware *fw) @@ -755,7 +755,7 @@ static void firmware_request_work_func(struct work_struct *work) } /** - * firmware_request_nowait - asynchronous version of firmware_request + * firmware_request_nowait() - asynchronous version of firmware_request * @module: module requesting the firmware * @uevent: sends uevent to copy the firmware image if this flag * is non-zero else the firmware copy must be done manually. @@ -824,7 +824,7 @@ EXPORT_SYMBOL(firmware_request_nowait); static ASYNC_DOMAIN_EXCLUSIVE(fw_cache_domain); /** - * cache_firmware - cache one firmware image in kernel memory space + * cache_firmware() - cache one firmware image in kernel memory space * @fw_name: the firmware image name * * Cache firmware in kernel memory so that drivers can use it when @@ -866,7 +866,7 @@ static struct fw_priv *lookup_fw_priv(const char *fw_name) } /** - * uncache_firmware - remove one cached firmware image + * uncache_firmware() - remove one cached firmware image * @fw_name: the firmware image name * * Uncache one firmware image which has been cached successfully @@ -1042,7 +1042,7 @@ static void __device_uncache_fw_images(void) } /** - * device_cache_fw_images - cache devices' firmware + * device_cache_fw_images() - cache devices' firmware * * If one device called firmware_request or its nowait version * successfully before, the firmware names are recored into the @@ -1075,7 +1075,7 @@ static void device_cache_fw_images(void) } /** - * device_uncache_fw_images - uncache devices' firmware + * device_uncache_fw_images() - uncache devices' firmware * * uncache all firmwares which have been cached successfully * by device_uncache_fw_images earlier @@ -1092,7 +1092,7 @@ static void device_uncache_fw_images_work(struct work_struct *work) } /** - * device_uncache_fw_images_delay - uncache devices firmwares + * device_uncache_fw_images_delay() - uncache devices firmwares * @delay: number of milliseconds to delay uncache device firmwares * * uncache all devices's firmwares which has been cached successfully