From patchwork Mon Apr 23 20:12:02 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andres Rodriguez X-Patchwork-Id: 10358103 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 0EF95601BE for ; Mon, 23 Apr 2018 20:28:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F2F6C28C3F for ; Mon, 23 Apr 2018 20:28:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id E573E28C46; Mon, 23 Apr 2018 20:28:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, MAILING_LIST_MULTI autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 9082A28C3F for ; Mon, 23 Apr 2018 20:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=/WYY2mzqff6t5btmB/f3Dk6DCob/NbLccgfCwqY+EjE=; b=quyi4TSumObTrLrVysUkFnj8mS dYYJKE+QfEQVX6U+gIlE1e7ZswU4X/CThNE9XfOdT05UX7SlnfoP3gSU/Nyoa9qBlKPgfK2hGOuqQ NMhXSPuejt+XNtZmhb4hiKin7sq013vmmlJ/qvtVIeRcNVCTdOGr0b4vLFS6D+BFPJHy2iGmoR3HV EayGzWKkrHgXzdXpcMqrFk0EBIEZEB6pu/4miKi3RiI+LJVXaFIB9ykVysIB1NObgMRrL1QRHNqMU rYK6thD/oh56KKZmohbRR7+XJkK+czsOLvzhjljjIHzO8r8WHH9m8PLkSmQ6O7HWQtDZiddwKKqhC 4tTi1KVw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1fAi4Q-0002nw-Gv; Mon, 23 Apr 2018 20:28:18 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fAi4L-0002eo-4f for ath10k@bombadil.infradead.org; Mon, 23 Apr 2018 20:28:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=References:In-Reply-To:Message-Id:Date: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=5tnmS4A0EkeinAzDvDrUlGtQwgojMNe4S8UGgYfzhE4=; b=Ht0zlHgURjoqIjOnyaIaVUdcM bGB9eCFF10XRH1z20LJ3g4eRf5P7REMHesLft0n+AsQLWtqFG161kV8pylG+pygkeg+UE6QgHTO7c tO7/8F6bg3FNROiDsZ9V99gjNvW6uyhIt2MjoNW6DbDzwqHm/+LeIO75DC0kB/eWKbYClPev+AsGz SIVTpHihEtzFlvfkbpQIs4Pzy5Gc3S5CaeK4Rta7wQdRu0AlD3NuX6OxcVZHjdBBCcwQ6pY3g68Fl M1GZBNeAIlitI24x3O/sUoEARHKMlQ4LKr//wT2olWvXQEgoM27ql/YzRG1UjQkzySl+MIJN4wsQQ 3VakDEoGg==; Received: from mail-io0-x244.google.com ([2607:f8b0:4001:c06::244]) by casper.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1fAhpC-0004xC-Fr for ath10k@lists.infradead.org; Mon, 23 Apr 2018 20:12:36 +0000 Received: by mail-io0-x244.google.com with SMTP id f3-v6so19966235iob.13 for ; Mon, 23 Apr 2018 13:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=5tnmS4A0EkeinAzDvDrUlGtQwgojMNe4S8UGgYfzhE4=; b=s5Pef7LuaicEN0TmTlnx2c6+OgybEatPtkh1cgbXKQoIrNAO4v0AlGw06yAai/7L7t ffvFCRa7mJMepQ+s1CC6ydzZpGD1TaEf+3zmdpu+1DOKaTrqRX3+DuIx6v2M8KC1hJTI yH74h6WXwbyKqxaUMBiqnPPAhUDzNmGfdqU/ACoAZtYISkEknPt0B+DAB9SVXQq75n88 hfNgdCaZ87wovcLkrq2P5vFUw015zKH3VZFxRnCF/ct1V/E6zukrD9+xwDeBkWlnF1JI NhH1M6qN8pkgBBM+xsva4xEh83YDuYik62rtQsQZN59oDv7GTX8IavVr+j9J1Hom7nwU ZyJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=5tnmS4A0EkeinAzDvDrUlGtQwgojMNe4S8UGgYfzhE4=; b=Cj0GT22crZ3EEFEHGy0UVYhgKxan+uFjRrhYg4XHXmElyvx4RcVk8UppDoBbHqE2C7 Nek58F3kWpUzBbdC9L3hoDhDDQ8f8OMzKAVgSPi9GPITOEiq7xbUxShcS7gFM1Wu1RpX xoJa9Iy3newBdJWZvQZPGXNRvjZf3egmi6owPHZDbtDy/GwTTyujUqMAu0Ipk3nH7SSe Lm/wCnW+HJRf9z6MpiMnYdJ83eB3nUfoH+ptSuDN2+mzolAvgpZ9mmwDl0FlSJfKOAB2 QNObHEPCtIRq7YrXScAnGDAgA1U/eQ1SFKG+6vEu6S/6mE+7HFzKB5t9pJs8EJFAbq5s V5VA== X-Gm-Message-State: ALQs6tCBsM1j1H2emQLo1F5/T0ZYKOv4/Gkk4Lu/4yVF/dDzzFVs9IN3 Nv38lsgufdSn/sRXZVWVNik= X-Google-Smtp-Source: AB8JxZpWm6FIadcf1BDCzj2Mtm3K7oYgqNpQQbF2T65WlbHUa3KxF9+uY6CVj8U2CQ7qGAgoC7gZkw== X-Received: by 2002:a6b:697:: with SMTP id f23-v6mr13392298ioi.18.1524514342225; Mon, 23 Apr 2018 13:12:22 -0700 (PDT) Received: from localhost.localdomain (184-175-36-239.dsl.teksavvy.com. [184.175.36.239]) by smtp.gmail.com with ESMTPSA id k130-v6sm1632551itb.0.2018.04.23.13.12.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Apr 2018 13:12:21 -0700 (PDT) From: Andres Rodriguez To: linux-kernel@vger.kernel.org Subject: [PATCH 6/9] firmware: print firmware name on fallback path Date: Mon, 23 Apr 2018 16:12:02 -0400 Message-Id: <20180423201205.20533-7-andresx7@gmail.com> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20180423201205.20533-1-andresx7@gmail.com> References: <20180423201205.20533-1-andresx7@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20180423_211234_624334_7E37A0F2 X-CRM114-Status: GOOD ( 12.61 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arend.vanspriel@broadcom.com, gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, hdegoede@redhat.com, mcgrof@kernel.org, andresx7@gmail.com, alexdeucher@gmail.com, christian.koenig@amd.com, kvalo@codeaurora.org MIME-Version: 1.0 Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Previously, one could assume the firmware name from the preceding message: "Direct firmware load for {name} failed with error %d". However, with the new firmware_request_nowarn() entrypoint, the message outlined above will not always be printed. Therefore, we add the firmware name to the fallback path spew in order to associate it with the appropriate request. Signed-off-by: Andres Rodriguez --- drivers/base/firmware_loader/fallback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/firmware_loader/fallback.c b/drivers/base/firmware_loader/fallback.c index e75928458489..1a47ddc70c31 100644 --- a/drivers/base/firmware_loader/fallback.c +++ b/drivers/base/firmware_loader/fallback.c @@ -669,6 +669,6 @@ int fw_sysfs_fallback(struct firmware *fw, const char *name, if (!fw_run_sysfs_fallback(opt_flags)) return ret; - dev_warn(device, "Falling back to user helper\n"); + dev_warn(device, "Falling back to user helper for %s\n", name); return fw_load_from_user_helper(fw, name, device, opt_flags); }