From patchwork Sun Sep 27 19:25:13 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christian Marangi X-Patchwork-Id: 11802281 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A7A8C139A for ; Sun, 27 Sep 2020 19:26:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 455CE206E5 for ; Sun, 27 Sep 2020 19:26:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="gTucK/a/"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UREkh7q3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 455CE206E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To:From: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References:List-Owner; bh=5pLiHQRjg9Gs1CrZCt6RUtgd4Smnyf/NY6nzu0cA93w=; b=gTucK/a/WoR7g4PakyRZM13CoK CCKYWBnZs3LnZvzq6/f0OB000mR5um1N1PWvtuamvoVA/HfxcN6SsP5Vb1bgJFmOTi5eslH/l8PXw ICjJ2iS/5vnWHi8tXtXeGU+QvxeijGyEgJFi8z1abpl7eeY8Tuu7spMN5eb83hacdnrQscN+Ju/Qu tZzm+M+rxsmANzQxfJA2EfXcodCuzqYDXUO+NtqEGCe7VsNYsGX7tcloPRReIYwyChyKIqNMbKoFe 3NUc0CBPIPn1vSA02moHo//cpfAw+DRQa/P0uOs+iMNswBbseqsZ7Xllx0LFK3Poih4ki5isv6OY9 BxETAbmQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMcIe-0005fO-0s; Sun, 27 Sep 2020 19:25:32 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kMcIb-0005eG-NK for ath10k@lists.infradead.org; Sun, 27 Sep 2020 19:25:30 +0000 Received: by mail-wr1-x442.google.com with SMTP id c18so9499703wrm.9 for ; Sun, 27 Sep 2020 12:25:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ib+m1upj1my5VACm4oUnf3b2Tj68EgFVrf7eXMZTHfA=; b=UREkh7q3a8XqC4vMjYLUHU5B32+ZhtSg5kKiGrLc07GE7sLvYFIdVIlJeBSqeeuTls 0T780VdBWvd35udo+spI2djY5UoRW1Xd5Y/9ARKtP5WnutErh9Vt6ThsxUPJFftqVjJ4 /VMcOxAzbZz0Nr4r+5XESrhhujkB5RUdyPZcj1GfWkCnmQzJC+o1AR3AbdpiWBqT2uXg Wx5Ct3l9T2bzfQGB4pQoVCQaTwaGePQiW4bT85Ba05n1HpeljR7EwZzXV+Xelztm4h5v JLeB2gc1K0zy94ik6bFrc0qBmZPoVDvkZX4dt70xmAneufhgVy9SCytuGIFeMfET8HeZ mPsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ib+m1upj1my5VACm4oUnf3b2Tj68EgFVrf7eXMZTHfA=; b=tUQwYFHj9VOqGZFnIi7kuYh8h+ILDRb+VJCTehyVpSw3ZCY3ZeaUqsMOx0+R8DL7UA TMjLS20mGB8j2wh8PW1tvYiX5z2ABuzrH/cle9xARTdhCHrW7vAfduS9ciRvv2UGnTPU xVrZGg0lqcXlTy2ZWeIH/e3/KxCn/lVryVIUeFw9hzH7beJpNwcTFekJfPT+PBcl1DrM P+ihObD5sYvqZr8/cK2Fy7Ki43HCg1hbop1a2IcquBiYEtpbp1QhcIqFKti3Hb7/Nrxz ABue4Wc0giGF5pPx6Vx4KZuXnAfHqx/t6PZauqkmon8mI0B+Lco1wd2p3KxvPmx2S2bG OzDw== X-Gm-Message-State: AOAM530ZSnfGXFcprfCeRnsM525FKlzlCP7tgA8d35XoCW7NAR3Cvs0i 9O5SvOh1w9+1XkB9UHB4ZGo= X-Google-Smtp-Source: ABdhPJwUUM/a/0bM09qKLhuI3meVRyIGzKoPK8GfrgyIMYu0sDQyWDYEeuVS+sSDhGeI1KsJ1SCC6w== X-Received: by 2002:adf:9043:: with SMTP id h61mr3933615wrh.237.1601234723236; Sun, 27 Sep 2020 12:25:23 -0700 (PDT) Received: from Ansuel-XPS.localdomain (93-39-149-95.ip76.fastwebnet.it. [93.39.149.95]) by smtp.googlemail.com with ESMTPSA id w21sm6398106wmk.34.2020.09.27.12.25.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 27 Sep 2020 12:25:22 -0700 (PDT) From: Ansuel Smith To: "0001-ath10k-Try-to-get-mac-address-from-dts . patchKalle Valo" Subject: [PATCH 1/2] ath10k: Try to get mac-address from dts Date: Sun, 27 Sep 2020 21:25:13 +0200 Message-Id: <20200927192515.86-1-ansuelsmth@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200927_152529_769225_B904C429 X-CRM114-Status: GOOD ( 15.20 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:442 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider [ansuelsmth[at]gmail.com] -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, "David S. Miller" , Jakub Kicinski , Ansuel Smith Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org Most of embedded device that have the ath10k wifi integrated store the mac-address in nvmem partitions. Try to fetch the mac-address using the standard 'of_get_mac_address' than in all the check also try to fetch the address using the nvmem api searching for a defined 'mac-address' cell. Mac-address defined in the dts have priority than any other address found. Tested-on: QCA9984 hw1.0 PCI 10.4 Signed-off-by: Ansuel Smith --- drivers/net/wireless/ath/ath10k/core.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 5f4e12196..9ed7b9883 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -8,6 +8,8 @@ #include #include #include +#include +#include #include #include #include @@ -2961,8 +2963,12 @@ EXPORT_SYMBOL(ath10k_core_stop); static int ath10k_core_probe_fw(struct ath10k *ar) { struct bmi_target_info target_info; + const char *mac; int ret = 0; + /* register the platform to be found by the of api */ + of_platform_device_create(ar->dev->of_node, NULL, NULL); + ret = ath10k_hif_power_up(ar, ATH10K_FIRMWARE_MODE_NORMAL); if (ret) { ath10k_err(ar, "could not power on hif bus (%d)\n", ret); @@ -3062,6 +3068,10 @@ static int ath10k_core_probe_fw(struct ath10k *ar) device_get_mac_address(ar->dev, ar->mac_addr, sizeof(ar->mac_addr)); + mac = of_get_mac_address(ar->dev->of_node); + if (!IS_ERR(mac)) + ether_addr_copy(ar->mac_addr, mac); + ret = ath10k_core_init_firmware_features(ar); if (ret) { ath10k_err(ar, "fatal problem with firmware features: %d\n",