From patchwork Mon Dec 15 20:42:57 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felix Fietkau X-Patchwork-Id: 5497651 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 746CCBEEA8 for ; Mon, 15 Dec 2014 20:43:33 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9C880209F5 for ; Mon, 15 Dec 2014 20:43:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C08C9209EB for ; Mon, 15 Dec 2014 20:43:31 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y0cUH-0006Vy-Ki; Mon, 15 Dec 2014 20:43:25 +0000 Received: from arrakis.dune.hu ([78.24.191.176]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y0cUE-0006Mg-4A for ath10k@lists.infradead.org; Mon, 15 Dec 2014 20:43:23 +0000 Received: from arrakis.dune.hu (localhost [127.0.0.1]) by arrakis.dune.hu (Postfix) with ESMTP id 9FA762802B9; Mon, 15 Dec 2014 21:41:08 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from nf.lan (p5DDC7842.dip0.t-ipconnect.de [93.220.120.66]) by arrakis.dune.hu (Postfix) with ESMTPSA; Mon, 15 Dec 2014 21:41:08 +0100 (CET) Message-ID: <548F47D1.8080502@openwrt.org> Date: Mon, 15 Dec 2014 21:42:57 +0100 From: Felix Fietkau User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Peter Oh , ath10k@lists.infradead.org Subject: Re: [PATCH] ath: fix incorrect PPB on FCC radar type 5 References: <1418669734-12921-1-git-send-email-poh@qca.qualcomm.com> In-Reply-To: <1418669734-12921-1-git-send-email-poh@qca.qualcomm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20141215_124322_414019_C5726E16 X-CRM114-Status: GOOD ( 11.37 ) X-Spam-Score: 0.0 (/) Cc: linux-wireless@vger.kernel.org X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP On 2014-12-15 19:55, Peter Oh wrote: > The minimum number of pulses per burst on FCC radar type 5 is 1. > Use this number for correct radar detection. > > Signed-off-by: Peter Oh > --- > drivers/net/wireless/ath/dfs_pattern_detector.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/dfs_pattern_detector.c b/drivers/net/wireless/ath/dfs_pattern_detector.c > index cfd0554..3d57f87 100644 > --- a/drivers/net/wireless/ath/dfs_pattern_detector.c > +++ b/drivers/net/wireless/ath/dfs_pattern_detector.c > @@ -86,7 +86,7 @@ static const struct radar_detector_specs fcc_radar_ref_types[] = { > FCC_PATTERN(1, 0, 5, 150, 230, 1, 23), > FCC_PATTERN(2, 6, 10, 200, 500, 1, 16), > FCC_PATTERN(3, 11, 20, 200, 500, 1, 12), > - FCC_PATTERN(4, 50, 100, 1000, 2000, 1, 20), > + FCC_PATTERN(4, 50, 100, 1000, 2000, 1, 1), Won't that significantly increase the false positive rate? Here's the previous change on that pattern: commit 562930f8baee7a1cb5b9f382b4338c9b6fbf1139 Author: Vivek Natarajan Date: Mon Nov 24 17:26:22 2014 +0530 ath: Fix a false radar detection pattern For FCC and JP, in one of the radar patterns, PPB and PRF seems to be interchanged leading to frequent incorrect radar detections. Signed-off-by: Vivek Natarajan Signed-off-by: John W. Linville diff --git a/drivers/net/wireless/ath/dfs_pattern_detector.c b/drivers/net/wireless/ath/dfs_pattern_detector.c index 650be79..cfd0554 100644 --- a/drivers/net/wireless/ath/dfs_pattern_detector.c +++ b/drivers/net/wireless/ath/dfs_pattern_detector.c @@ -86,7 +86,7 @@ static const struct radar_detector_specs fcc_radar_ref_types[] = { FCC_PATTERN(1, 0, 5, 150, 230, 1, 23), FCC_PATTERN(2, 6, 10, 200, 500, 1, 16), FCC_PATTERN(3, 11, 20, 200, 500, 1, 12), - FCC_PATTERN(4, 50, 100, 1000, 2000, 20, 1), + FCC_PATTERN(4, 50, 100, 1000, 2000, 1, 20), FCC_PATTERN(5, 0, 1, 333, 333, 1, 9), }; @@ -105,7 +105,7 @@ static const struct radar_detector_specs jp_radar_ref_types[] = { JP_PATTERN(4, 0, 5, 150, 230, 1, 23), JP_PATTERN(5, 6, 10, 200, 500, 1, 16), JP_PATTERN(6, 11, 20, 200, 500, 1, 12), - JP_PATTERN(7, 50, 100, 1000, 2000, 20, 1), + JP_PATTERN(7, 50, 100, 1000, 2000, 1, 20), JP_PATTERN(5, 0, 1, 333, 333, 1, 9), };