From patchwork Tue Jan 6 01:26:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ben Greear X-Patchwork-Id: 5571041 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id BE55DBF6C3 for ; Tue, 6 Jan 2015 01:26:59 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CDC3D20320 for ; Tue, 6 Jan 2015 01:26:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D908420306 for ; Tue, 6 Jan 2015 01:26:57 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y8Iuz-00044R-9Y; Tue, 06 Jan 2015 01:26:45 +0000 Received: from mail2.candelatech.com ([208.74.158.173]) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y8Iux-00042r-UP for ath10k@lists.infradead.org; Tue, 06 Jan 2015 01:26:44 +0000 Received: from [192.168.100.236] (unknown [50.251.239.81]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail2.candelatech.com (Postfix) with ESMTPSA id 235F340DBDB; Mon, 5 Jan 2015 17:26:22 -0800 (PST) Message-ID: <54AB39BD.2050804@candelatech.com> Date: Mon, 05 Jan 2015 17:26:21 -0800 From: Ben Greear Organization: Candela Technologies User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7 MIME-Version: 1.0 To: ath10k , rmanohar@qti.qualcomm.com Subject: Re: Firmware debug messages stopped sometime after 3.18 (bisected) References: <54A5F18C.2050007@candelatech.com> In-Reply-To: <54A5F18C.2050007@candelatech.com> X-Enigmail-Version: 1.5.2 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150105_172644_009901_645FB4B5 X-CRM114-Status: GOOD ( 14.86 ) X-Spam-Score: -0.0 (/) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 01/01/2015 05:17 PM, Ben Greear wrote: > While trying to reproduce some bugs on ath10k in 3.19.0-rc2, I could not > get any debuglog messages from the firmware. For instance, in stock kernel > it should print out something like this: > > wmi event debug mesg len 28 > > I got other wmi debug messages, so the debug level appeared correct. > > The message shows up as expected in stock 3.18 kernel. > > Was this done on purpose? > > I've started a bisect...should track it down directly. Took a while, but bisect points to this. If you are doing bisect yourself, or playing with changes near here, you must manually apply the patch below to allow scan to work. I'll try to figure out why the patch below disables firmware debuglog messages next. I assume that was not the intention? 90174455ae058a1dcf1f3d344a9752385803c1d8 is the first bad commit commit 90174455ae058a1dcf1f3d344a9752385803c1d8 Author: Rajkumar Manoharan Date: Fri Oct 3 08:02:33 2014 +0300 ath10k: add support to configure pktlog filter Add support to configure packet log filters (tx, rx, rate control) via debugfs. To disable htt pktlog events set the filters to 0. ex: To enable pktlog for all filters echo 0x1f > /sys/kernel/debug/ieee80211/phy*/ath10k/pktlog_filter To disable pktlog echo 0 > /sys/kernel/debug/ieee80211/phy*/ath10k/pktlog_filter Signed-off-by: Rajkumar Manoharan Signed-off-by: Kalle Valo :040000 040000 1ff3b609db06d718fb22a7d8444a70e38a60ebcd 6504c0828edb532f19826167eab9ba0634b3f044 M drivers Patch to allow scan to work (this patch made it upstream a bit later): [greearb@ben-dt2 linux-bisect]$ git diff [greearb@ben-dt2 linux-bisect]$ Thanks, Ben > > Thanks, > Ben > diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c index f65032f..d878fbe 100644 --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -3506,10 +3506,10 @@ int ath10k_wmi_start_scan(struct ath10k *ar, return ret; if (test_bit(ATH10K_FW_FEATURE_WMI_10X, ar->fw_features)) - len = sizeof(struct wmi_start_scan_cmd) + + len = sizeof(struct wmi_10x_start_scan_cmd) + ath10k_wmi_start_scan_tlvs_len(arg); else - len = sizeof(struct wmi_10x_start_scan_cmd) + + len = sizeof(struct wmi_start_scan_cmd) + ath10k_wmi_start_scan_tlvs_len(arg); skb = ath10k_wmi_alloc_skb(ar, len);