From patchwork Thu Aug 17 06:49:40 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 9905063 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 275C26038C for ; Thu, 17 Aug 2017 06:50:18 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 17BC028ABC for ; Thu, 17 Aug 2017 06:50:18 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0C2EF28ABE; Thu, 17 Aug 2017 06:50:18 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 0A47628ABC for ; Thu, 17 Aug 2017 06:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jJ18u7mULkgrMf3iu1AdWXf4JUk5vU8xsjCiIOce+zU=; b=Qb1vpYLW1NFXyJ ub03FLx8cw/1cIB0pehFVd+gY5MbvNri96MQj6FhG1euosnr68eoDzN1WxABJqqazL8GzKB7heAP3 iILJSRx3keekYTh1UjvkpKtzQE7B2m/2TU4RcznpxHCjjAh6UBOmJUPmT24DXZ+ejC/6/D2zGDuGm 96YNiAb4vNFOn+FSfFojHdDtqThFOSQy/IzdbDra7j9ufW7YGiMUtR0rBKS0J68TxD/KlpwGI6IVC Yn6o3p2ux4Jm9TGtvWLDzlkpIRNisAGnG70RFKMoWKGeuKv1ATAjLiBhZAKoBUg5kdoXiGFVh/Kob 32OdnKm7UzevBudK6qJg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1diEd8-0000Ku-Gz; Thu, 17 Aug 2017 06:50:10 +0000 Received: from sabertooth01.qualcomm.com ([65.197.215.72]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1diEd4-000899-R5 for ath10k@lists.infradead.org; Thu, 17 Aug 2017 06:50:08 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1502952606; x=1534488606; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=7k3zexOo6feljmXQw6y95FK0+ZCDvIX2Nc6fX7g90dQ=; b=j0GVzIKMJXKgnhla1u0uYaSiSS4DIg1e83VrUdcTBkV6cGvEJsmdLXjp Ih8O0fVKmDlhfyA1LrZrgP25MNgI0eTT1aIahVcFmbq/LxfvUVOS+h8qL ClAgUOPB8T80hmF/FffseElVVyPTAlOyCthSgE7vcjOwgwwoEcxG3CoBe A=; X-IronPort-AV: E=Sophos;i="5.41,386,1498546800"; d="scan'208";a="112858896" Received: from unknown (HELO Ironmsg04-L.qualcomm.com) ([10.53.140.111]) by sabertooth01.qualcomm.com with ESMTP; 16 Aug 2017 23:49:45 -0700 X-IronPort-AV: E=McAfee;i="5900,7806,8624"; a="1405759828" X-MGA-submission: =?us-ascii?q?MDEaWUcNUK51Udmm+x4CMSVcwh6WszPL8VIAmj?= =?us-ascii?q?zboRbrtuvedIt2uh6xCt4R4JI/EL0aUisVNgRwrfbtILXrC+J98M/f8/?= =?us-ascii?q?WIScG44DQjSlsbqXSevgZagHw8uCt9sIgej5U/7Dp2ILbHNb0CQDY5Zk?= =?us-ascii?q?qD?= Received: from nasanexm02e.na.qualcomm.com ([10.85.0.86]) by Ironmsg04-L.qualcomm.com with ESMTP/TLS/RC4-SHA; 16 Aug 2017 23:49:44 -0700 Received: from euamsexm01e.eu.qualcomm.com (10.251.127.42) by nasanexm02e.na.qualcomm.com (10.85.0.86) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Wed, 16 Aug 2017 23:49:43 -0700 Received: from euamsexm01a.eu.qualcomm.com (10.251.127.40) by euamsexm01e.eu.qualcomm.com (10.251.127.42) with Microsoft SMTP Server (TLS) id 15.0.1178.4; Thu, 17 Aug 2017 08:49:40 +0200 Received: from euamsexm01a.eu.qualcomm.com ([10.251.127.40]) by euamsexm01a.eu.qualcomm.com ([10.251.127.40]) with mapi id 15.00.1178.000; Thu, 17 Aug 2017 08:49:40 +0200 From: Kalle Valo To: "ath10k@lists.infradead.org" Subject: Re: [2/6] ath10k: refactor firmware crashdump code to coredump.c Thread-Topic: [2/6] ath10k: refactor firmware crashdump code to coredump.c Thread-Index: AQHTFyT/OcUWR5TRwk6hc7ZTXDtY6w== Date: Thu, 17 Aug 2017 06:49:40 +0000 Message-ID: <87378q664c.fsf@kamboji.qca.qualcomm.com> References: <150278538298.22482.10986802411848917689.stgit@potku.adurom.net> In-Reply-To: (Kalle Valo's message of "Thu, 17 Aug 2017 06:20:02 +0200") Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.251.52.12] MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170816_235006_943756_AAF4E0FE X-CRM114-Status: UNSURE ( 5.18 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-wireless@vger.kernel.org" Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Kalle Valo writes: > Kalle Valo wrote: > >> In preparation to add RAM dump support. No functional changes, only moving code >> and renaming function names. >> >> Signed-off-by: Kalle Valo > > With only this patch applied, and CONFIG_DEV_COREDUMP disabled, there's a build error: > > drivers/net/wireless/ath/ath10k/coredump.c:24:30: error: redefinition > of 'ath10k_coredump_new' > drivers/net/wireless/ath/ath10k/coredump.c:130:5: error: redefinition > of 'ath10k_coredump_submit' Fixed in pending branch like this: ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k --- a/drivers/net/wireless/ath/ath10k/Makefile +++ b/drivers/net/wireless/ath/ath10k/Makefile @@ -20,7 +20,7 @@ ath10k_core-$(CONFIG_ATH10K_TRACING) += trace.o ath10k_core-$(CONFIG_THERMAL) += thermal.o ath10k_core-$(CONFIG_MAC80211_DEBUGFS) += debugfs_sta.o ath10k_core-$(CONFIG_PM) += wow.o -ath10k_core-$(CONFIG_ATH10K_DEBUGFS) += coredump.o +ath10k_core-$(CONFIG_DEV_COREDUMP) += coredump.o -- Kalle Valo _______________________________________________