From patchwork Fri Jan 2 07:45:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kalle Valo X-Patchwork-Id: 5558291 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4E408BF6C3 for ; Fri, 2 Jan 2015 07:46:31 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 7741F2024D for ; Fri, 2 Jan 2015 07:46:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 60E5B2022D for ; Fri, 2 Jan 2015 07:46:29 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y6wwD-0008DG-Sm; Fri, 02 Jan 2015 07:46:25 +0000 Received: from sabertooth01.qualcomm.com ([65.197.215.72]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1Y6wwC-0008CT-96 for ath10k@lists.infradead.org; Fri, 02 Jan 2015 07:46:24 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=qca.qualcomm.com; i=@qca.qualcomm.com; q=dns/txt; s=qcdkim; t=1420184784; x=1451720784; h=from:to:cc:subject:references:date:in-reply-to: message-id:mime-version; bh=6m/TsqT6EmO5HClZpgplvAbNFM0gMXyYSw87pwclF0I=; b=b8WcKUGGL73BvVW60dbBUGvO7Ce3HW1hqvS1fS9zvoZ4kk56fg6B4ufn gQJM15LsaDybrNhItamCQvQwhx3YvhDhFplEO/6d0IeC3AoxwmabE7kq3 Nj3z9Wsl48pvdoaMoVlIxph/kja29EIKJfNflH+RghTL53pmL50P0nMoz 4=; X-IronPort-AV: E=McAfee;i="5600,1067,7668"; a="80907212" Received: from ironmsg03-lv.qualcomm.com ([10.47.202.181]) by sabertooth01.qualcomm.com with ESMTP; 01 Jan 2015 23:46:02 -0800 X-IronPort-AV: E=Sophos;i="5.07,683,1413270000"; d="scan'208";a="25638742" Received: from nalasexr01g.na.qualcomm.com ([10.49.56.53]) by ironmsg03-lv.qualcomm.com with ESMTP/TLS/RC4-SHA; 01 Jan 2015 23:46:02 -0800 Received: from potku.adurom.net.qca.qualcomm.com (10.80.80.8) by NALASEXR01G.na.qualcomm.com (10.49.56.53) with Microsoft SMTP Server (TLS) id 15.0.995.29; Thu, 1 Jan 2015 23:45:59 -0800 From: Kalle Valo To: Sujith Manoharan Subject: Re: [PATCH] ath10k: Enable RX batching References: <1419834084-11859-1-git-send-email-sujith@msujith.org> Date: Fri, 2 Jan 2015 09:45:54 +0200 In-Reply-To: <1419834084-11859-1-git-send-email-sujith@msujith.org> (Sujith Manoharan's message of "Mon, 29 Dec 2014 11:51:24 +0530") Message-ID: <87fvbt62x9.fsf@kamboji.qca.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) MIME-Version: 1.0 X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: NASANEXM01H.na.qualcomm.com (10.85.0.34) To NALASEXR01G.na.qualcomm.com (10.49.56.53) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150101_234624_429490_2C11B8C9 X-CRM114-Status: UNSURE ( 9.29 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -5.1 (-----) Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Sujith Manoharan writes: > From: Sujith Manoharan > > This feature allows the FW to batch RX indications, > reducing the rate of host interrupt generation, which > in turn reduces CPU load. Currently, this is enabled > only for the 10.2 firmware. > > Signed-off-by: Sujith Manoharan Any throughput improvements? Also I simplified the patch a bit in ath-next-test: --- a/drivers/net/wireless/ath/ath10k/wmi.c +++ b/drivers/net/wireless/ath/ath10k/wmi.c @@ -3710,7 +3710,7 @@ static struct sk_buff *ath10k_wmi_10_2_op_gen_init(struct ath10k *ar) struct wmi_init_cmd_10_2 *cmd; struct sk_buff *buf; struct wmi_resource_config_10x config = {}; - u32 len, val, features = 0; + u32 len, val, features; config.num_vdevs = __cpu_to_le32(TARGET_10X_NUM_VDEVS); config.num_peers = __cpu_to_le32(TARGET_10X_NUM_PEERS); @@ -3764,7 +3764,7 @@ static struct sk_buff *ath10k_wmi_10_2_op_gen_init(struct ath10k *ar) cmd = (struct wmi_init_cmd_10_2 *)buf->data; - features |= WMI_10_2_RX_BATCH_MODE; + features = WMI_10_2_RX_BATCH_MODE; cmd->resource_config.feature_mask = __cpu_to_le32(features); memcpy(&cmd->resource_config.common, &config, sizeof(config));