From patchwork Thu Aug 6 05:03:15 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Kazior X-Patchwork-Id: 6955841 Return-Path: X-Original-To: patchwork-ath10k@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id B64229F358 for ; Thu, 6 Aug 2015 05:03:52 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AFF962069D for ; Thu, 6 Aug 2015 05:03:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D164B2067D for ; Thu, 6 Aug 2015 05:03:50 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZNDLA-0008Bm-RB; Thu, 06 Aug 2015 05:03:40 +0000 Received: from mail-wi0-x233.google.com ([2a00:1450:400c:c05::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZNDL8-00089G-Fo for ath10k@lists.infradead.org; Thu, 06 Aug 2015 05:03:39 +0000 Received: by wibxm9 with SMTP id xm9so7155140wib.0 for ; Wed, 05 Aug 2015 22:03:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; bh=LVjstaiTp/gKztcp4/s2UfiSzHFIGhaJmmSXGwTkLqo=; b=ozpzoR4bdwDp5rBV51zvWKPnnfdr7soV75EmnbWbBRMBu37SMrTDPdnHPLZiy4fjk3 qZ1Q7mIYLvm91o/PldIOiy7NrWG4ExY18wHc6Taak5DWgMDx5z+v/BVXQ/0ff9nK2k4N heT0ZjRkRwHst6GY7n/ry5WNArt2k/ZH4QXYM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=LVjstaiTp/gKztcp4/s2UfiSzHFIGhaJmmSXGwTkLqo=; b=Y4nuA1kbkfPILm0bVSR10JS14TgZ7RRUt5y5uPACn7uLA2sC9Jdb1tR5RICE5Qr+vc GHbHGQGyHMFdtLn3j6gvbW+7O3wl6i7Ol6WUI7iJ6tjYJahoydxeyq7hMP7R7+neK7Zv fdTlDU+P7z8bLabrWrT7VyiO9VK8t2L0UVI+F016FJl3l0lHudB7Fe0CGnTejvw8xQ5b fQH4jAt8tPGNPrSqR0dx6d4US98qYTTUPWflwfrW4LF0FvIxtkRW99bWnr6sBb14Sad+ 4nS4paY1f5xjzvRlJBbHpoiSRwJym17Z6POriar7LkPNMExzdpCAHjq4hQ7E+qZhM77A 0i0w== X-Gm-Message-State: ALoCoQnEov0psHbhzw23XkNC0wTzSmwX9c0QLNypD4+qo+UirjHNQ5syHZx0eRyfQHny9TD/6AAJOxkusTu/ZPaN5kD7m5/PaOe14vUUwKkLSS0qTONLWIVJkhFmMD8oXk51a/ubMghG MIME-Version: 1.0 X-Received: by 10.180.24.198 with SMTP id w6mr2412489wif.49.1438837395707; Wed, 05 Aug 2015 22:03:15 -0700 (PDT) Received: by 10.194.221.67 with HTTP; Wed, 5 Aug 2015 22:03:15 -0700 (PDT) In-Reply-To: References: Date: Thu, 6 Aug 2015 07:03:15 +0200 Message-ID: Subject: Re: qca6174 hw2.1 fw and kernel crash on 5GHz network connection attempt From: Michal Kazior To: Lapo Calamandrei X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150805_220338_680302_26F0B39F X-CRM114-Status: GOOD ( 14.73 ) X-Spam-Score: -2.7 (--) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "ath10k@lists.infradead.org" Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On 5 August 2015 at 15:25, Lapo Calamandrei wrote: > Hi, > > I have an alienware 17 r2 with a fedora 22 installed, I'm using kvalo > ath kernel master branch from today, built with fedora rawhide > 4.2.0-rc4 kernel config. The firmware is made following the > instructions on the list by the windows drivers. > I'm using skip_otp=1 on ath10k_core and irq_mode=1 on ath10k_pci > otherwise I run into the same issues reported by Enrico Tagliavini. > Everything works reasonably well on my 2.4GHz network, but trying to > connect to my other 5Ghz I get a firmware crash followed by a kernel > crash. Attached a dmesg output, feel free to ask any additional info. There's no kernel crash here. It's just a warning splat with call trace. This happens because - apparently - the device double-crashed and got wedged so mac80211 complained verbosely. The firmware crash itself seems to be related to TxBF. I'm guessing the firmware wrongly advertises vht capabilities and crashes when associating to TxBF capable AP. As a temporary measure (and confirmation) you can try the diff below (warning, whitespace damaged). Micha? for (i = 0; i < 8; i++) { --- a/drivers/net/wireless/ath/ath10k/mac.c +++ b/drivers/net/wireless/ath/ath10k/mac.c @@ -6732,23 +6732,10 @@ static struct ieee80211_sta_vht_cap ath10k_create_vht_cap(struct ath10k *ar) vht_cap.vht_supported = 1; vht_cap.cap = ar->vht_cap_info; - if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE | - IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE)) { - val = ar->num_rf_chains - 1; - val <<= IEEE80211_VHT_CAP_BEAMFORMEE_STS_SHIFT; - val &= IEEE80211_VHT_CAP_BEAMFORMEE_STS_MASK; - - vht_cap.cap |= val; - } - - if (ar->vht_cap_info & (IEEE80211_VHT_CAP_SU_BEAMFORMER_CAPABLE | - IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE)) { - val = ar->num_rf_chains - 1; - val <<= IEEE80211_VHT_CAP_SOUNDING_DIMENSIONS_SHIFT; - val &= IEEE80211_VHT_CAP_SOUNDING_DIMENSIONS_MASK; - - vht_cap.cap |= val; - } + ar->vht_cap_info &= ~(IEEE80211_VHT_CAP_SU_BEAMFORMEE_CAPABLE | + IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE | + IEEE80211_VHT_CAP_SU_BEAMFORMER_CAPABLE | + IEEE80211_VHT_CAP_MU_BEAMFORMER_CAPABLE); mcs_map = 0;