From patchwork Mon Apr 24 06:44:37 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marcin Rokicki X-Patchwork-Id: 9695683 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 82DD26037F for ; Mon, 24 Apr 2017 06:45:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 75CC72654B for ; Mon, 24 Apr 2017 06:45:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6A43426B41; Mon, 24 Apr 2017 06:45:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 56F462654B for ; Mon, 24 Apr 2017 06:45:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=U27sGpMfMVuE7KF75QNsa+/ssLUX/Uobp2hRmzGDLIc=; b=hq3C1PHh89W+CD 15mNn40TSwTzsR5oA3d+iRXiyNkd7sF/O3ay26qOtFgEfphCMhcV+lMQddicKUdKYhVYQT6cR4t0F iXzhpa7DLdjG9i9nL/SlKG+YZjherUomERtsD57h3phwpQqfRsdglVizhala3fz8nHC4N4P4A5P62 LJPVndgS7rOH0b6aFlCaBEeMtOvXCYVHx5/XCbM+RUstvvmL6L6dFyNhulyAwFKcz8xpbcmACqfgN 9OAFEWyXeWjy09EutuQ46E+6rjddQFfEnc6yFkIzKW73hUxBOyfjOaH0LUhoInt1TVQIUvkwDT/oX RWjlZY1TVAO2IdvecQvA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.87 #1 (Red Hat Linux)) id 1d2Xk7-0001cw-Lc; Mon, 24 Apr 2017 06:45:03 +0000 Received: from mail-io0-x231.google.com ([2607:f8b0:4001:c06::231]) by bombadil.infradead.org with esmtps (Exim 4.87 #1 (Red Hat Linux)) id 1d2Xk3-0001Ul-Dc for ath10k@lists.infradead.org; Mon, 24 Apr 2017 06:45:01 +0000 Received: by mail-io0-x231.google.com with SMTP id a103so180357677ioj.1 for ; Sun, 23 Apr 2017 23:44:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tieto.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dwKj+X/nXaOp6DnW6KNnbUaAUR+OrZX6D+I0xGQ5aCo=; b=wW0XT/DBX9saS9fbIlha3A5EkYkDByuNPxPKqi2JTWcqzZYSDwyltZnKRWywvH28Vp 6uqbwUGO8BecHRfKmSu4+z08RvcYEuCUxecSsa8X54v8fTwlDZ4AWPTdb9i/10ggElZL ta27tSUHHWnrFC4iQJBKsEj4/OFZ0nR4doKRA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dwKj+X/nXaOp6DnW6KNnbUaAUR+OrZX6D+I0xGQ5aCo=; b=Jzbvfz9buqCc2Dxr4ZIDk/heO1Jm80pb7WRK+pxJXGsuPiXTe7VmDne72JAfMbFmZP XKmit7eJRpN8sA0tpkx37qJPuh4fChOT9rUXKkao5Vn0n+madOh9wn8c/WXjDvz2C/Qb NpFU68OpMESpbfokhsdzbQrHgxWXFAcUYsegXXwrIDPfdeWcMXZWGfcgr4/pBo/AHAop 9usJjUzokzYldrCESgX6xoZsiLVErhwsQg8OH8FzkqY6KwO82rkJhFzNejRS00dfyPED TYtz0pOUsYyBu6QY75lhsnUjj28bgKORgGDJh+mBVAYb2AA6fqIRjpxCsVP/neDS+OtX pWUw== X-Gm-Message-State: AN3rC/6blR2W9MhlNcPNsFBkEclYuy2POr0/dM7gTP5TVWbJKzdjMg+h zFK9kJB8JmZiw3uF/v1GShdDNwKJ4xrAbpaaEHDqhjQchKo52SPwZ+umat+Jh/bj7ci/JFaKRWE ARMYbn2KEvxIX5pIJQDL2qYa0Og== X-Received: by 10.202.186.131 with SMTP id k125mr2397996oif.53.1493016277896; Sun, 23 Apr 2017 23:44:37 -0700 (PDT) MIME-Version: 1.0 Received: by 10.74.144.195 with HTTP; Sun, 23 Apr 2017 23:44:37 -0700 (PDT) In-Reply-To: References: <2103690e-ad1f-4612-e343-1ea711c14a00@linaro.org> <1492660230116.11983@qti.qualcomm.com> <87a87b7fl4.fsf@kamboji.qca.qualcomm.com> <2c39033b-b444-da10-c444-c25ae627c051@qca.qualcomm.com> From: Marcin Rokicki Date: Mon, 24 Apr 2017 08:44:37 +0200 Message-ID: Subject: Re: odd msg using kvalo firmware-5.bin w/ KillerAC 1535(QCA6174) To: Adrian Chadd X-DomainID: tieto.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20170423_234459_503432_E9EAA19A X-CRM114-Status: GOOD ( 15.60 ) X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ryan Hsu , "ath10k@lists.infradead.org" Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP I made quick check and the last existing ev is: ath10k_pci 0000:03:00.0: WMI_TLV_RADIO_LINK_STATS_EVENTID: 90116 If you don't want to implement this feature now then could you please define these 2 missing ev's name for simple suppress not implemented ev. (to avoid naming like this) drivers/net/wireless/ath/ath10k/wmi-tlv.c | 5 +++++ drivers/net/wireless/ath/ath10k/wmi-tlv.h | 2 ++ 2 files changed, 7 insertions(+) --- *Marcin* On 21 April 2017 at 21:53, Adrian Chadd wrote: > can we get a definition of the feature so we can just implement it? It > looks like something simpleish? > > > -a > > > On 21 April 2017 at 12:00, Ryan Hsu wrote: >> On 04/19/2017 11:34 PM, Kalle Valo wrote: >> >>> "Mohammed Shafi Shajakhan (Mohammed Shafi)" >>> writes: >>> >>>> my quick analysis suggests this belongs to >>>> 'WMI_TLV_GRP_STATS' >>>> >>>> WMI_TLV_STATS_EXT_EVENTID = WMI_TLV_EV(WMI_TLV_GRP_STATS), equals to 90112 (0x16000) >>>> WMI_TLV_IFACE_LINK_STATS_EVENTID, 90113 >>>> WMI_TLV_PEER_LINK_STATS_EVENTID, 90114 >>>> WMI_TLV_RADIO_LINK_STATS_EVENTID, 90015 >>>> .... ? >>>> WMI_TLV_NLO_MATCH_EVENTID = WMI_TLV_EV(WMI_TLV_GRP_NLO_OFL), >>> >>> I checked and I think this is a some kind of RSSI stats event. I assume >>> that's a new feature coming from RM.4.4 branch. (Michael said on IRC he >>> is not seeing that with RM.2.0 branch.) >>> >>>> but this should be a harmless warning message indicating the host had not implemented >>>> any action for this particular event. >>>> >>>> For example in 10.2 wmi.c >>>> >>>> >>>> case WMI_10_2_GPIO_INPUT_EVENTID: >>>> case WMI_10_2_PEER_RATECODE_LIST_EVENTID: >>>> case WMI_10_2_GENERIC_BUFFER_EVENTID: >>>> case WMI_10_2_MCAST_BUF_RELEASE_EVENTID: >>>> case WMI_10_2_MCAST_LIST_AGEOUT_EVENTID: >>>> case WMI_10_2_WDS_PEER_EVENTID: >>>> ath10k_dbg(ar, ATH10K_DBG_WMI, >>>> "received event id %d not implemented\n", id); >>>> break; >>> Yes, it's harmless but ath10k should not print that warning to not >>> distract the users. Can someone make a patch to silent the warning that >>> similarly like with WMI_10_2_WDS_PEER_EVENTID above? >>> >> >> It doesn't harm anything, just a new firmware feature that is not implemented in ath10k. >> I'll make the message silent instead of warn to avoid confusion. And will also see if we could also disable it >> >> Ryan >> _______________________________________________ >> ath10k mailing list >> ath10k@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/ath10k > > _______________________________________________ > ath10k mailing list > ath10k@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/ath10k diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.c b/drivers/net/wireless/ath/ath10k/wmi-tlv.c index f918802..c0ec27b 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.c +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.c @@ -552,6 +552,11 @@ static void ath10k_wmi_tlv_op_rx(struct ath10k *ar, struct sk_buff *skb) case WMI_TLV_TX_PAUSE_EVENTID: ath10k_wmi_tlv_event_tx_pause(ar, skb); break; + case WMI_TLV_RSVD1_STATS_EVENTID: + case WMI_TLV_RSVD2_STATS_EVENTID: + ath10k_dbg(ar, ATH10K_DBG_WMI, + "received event id %d is not implemented\n", id); + break; default: ath10k_warn(ar, "Unknown eventid: %d\n", id); break; diff --git a/drivers/net/wireless/ath/ath10k/wmi-tlv.h b/drivers/net/wireless/ath/ath10k/wmi-tlv.h index 22cf011..19f7e48 100644 --- a/drivers/net/wireless/ath/ath10k/wmi-tlv.h +++ b/drivers/net/wireless/ath/ath10k/wmi-tlv.h @@ -335,6 +335,8 @@ enum wmi_tlv_event_id { WMI_TLV_IFACE_LINK_STATS_EVENTID, WMI_TLV_PEER_LINK_STATS_EVENTID, WMI_TLV_RADIO_LINK_STATS_EVENTID, + WMI_TLV_RSVD1_STATS_EVENTID, + WMI_TLV_RSVD2_STATS_EVENTID, WMI_TLV_NLO_MATCH_EVENTID = WMI_TLV_EV(WMI_TLV_GRP_NLO_OFL), WMI_TLV_NLO_SCAN_COMPLETE_EVENTID, WMI_TLV_APFIND_EVENTID,