From patchwork Tue May 28 05:48:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasanthakumar Thiagarajan X-Patchwork-Id: 10963717 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9867C6C5 for ; Tue, 28 May 2019 05:48:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7B89D286BC for ; Tue, 28 May 2019 05:48:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6FF6B286BF; Tue, 28 May 2019 05:48:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 10568286BD for ; Tue, 28 May 2019 05:48:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9U4SOLtPRvhsMsUmNSSgz19myRcLbuHtJTVoqphPQd8=; b=MUAoLznUfEN9+P F2/c5W641qGwNxhpSPKp9RATJUUUPPNGCJJgQOxF0gJILVEqk55VO95O6IK4jiwXWuNL9yuJU6+Qi Umglr4nWYZ2/7Wem3Z4peNNEF45NyZYbL/r94Tes645Rs51reR+HW0R/CLsGA04wYPj4VHM+3iXs7 438GJZOGYawvEpS3ca9AHH2v0YolAJNU/IdcbcpsuPf/ya7zMWABta6Em0i484phkrgnLPnD73ZBs TxaRXbB348FS1xauGcW3b7DbnV7WlnGZ97NNBB+y2xHMj8Fv+EvionplOkBtev0uDIGqM7SE5m7dv l2Qww6p2vCdYehFNFF6A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVUyP-0007Dj-5K; Tue, 28 May 2019 05:48:33 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVUyL-0007BV-AN for ath11k@lists.infradead.org; Tue, 28 May 2019 05:48:30 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 1323E60A24; Tue, 28 May 2019 05:48:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559022509; bh=0wRJbN7tMZEF1jVPGXPEU3OayGbxJfDcL/VkiLUUGOU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=DMqq3MxRTYqe/knUA+4BZNqmHicICXEy0OBJw6ICVkHN5KvGqaUu/5M3xC4CnqiTg H8VZotJoRPZLpoBtdV+4YpqHr3X16DtTJjWzxwlpw1/P55whkA89+PaWp/QP86wdX+ cWiTMqWMRNbfD/4RxFXv8R3EwSHWTtjkit6w+xcY= Received: from vasanth-lnx.qca.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vthiagar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 2C09360712 for ; Tue, 28 May 2019 05:48:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1559022508; bh=0wRJbN7tMZEF1jVPGXPEU3OayGbxJfDcL/VkiLUUGOU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=eCJU4UVlpJdqmz5xx8blFyzYoeOySLit/M2hI4EmNqbBUPKCAhf+BTd0j7Xop56o5 2ElV73oC2u4Dd6QuQxQKnli7yilx2QwUoUopxjOzHwUkLWrkr9/95vCjeGCvAkZaNf dKHzlCD2idKuMmSaPHigxiJdsCh3DIeTETlwLSyQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2C09360712 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vthiagar@codeaurora.org From: Vasanthakumar Thiagarajan To: ath11k@lists.infradead.org Subject: [PATCH 4/4] ath11k: Fix sparse warning using palin integer as NULL pointer Date: Tue, 28 May 2019 11:18:06 +0530 Message-Id: <1559022486-7073-4-git-send-email-vthiagar@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1559022486-7073-1-git-send-email-vthiagar@codeaurora.org> References: <1559022486-7073-1-git-send-email-vthiagar@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190527_224829_389368_29BC3CA6 X-CRM114-Status: GOOD ( 11.31 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP drivers/net/wireless/ath/ath11k/qmi.c:1806:41: warning: Using plain integer as NULL pointer drivers/net/wireless/ath/ath11k/dp_rx.c:3433:16: warning: Using plain integer as NULL pointer drivers/net/wireless/ath/ath11k/debug_htt_stats.c:815:59: warning: Using plain integer as NULL pointer Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath11k/debug_htt_stats.c | 2 +- drivers/net/wireless/ath/ath11k/dp_rx.c | 5 +---- drivers/net/wireless/ath/ath11k/qmi.c | 4 +++- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c b/drivers/net/wireless/ath/ath11k/debug_htt_stats.c index 876134a..ac217d9 100644 --- a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c +++ b/drivers/net/wireless/ath/ath11k/debug_htt_stats.c @@ -812,7 +812,7 @@ static inline void htt_print_tx_peer_rate_stats_tlv(const u32 *tag_buf, u8 *data u32 len = stats_req->buf_len; u32 buf_len = ATH11K_HTT_STATS_BUF_SIZE; char str_buf[HTT_MAX_STRING_LEN] = {0}; - char *tx_gi[HTT_TX_PEER_STATS_NUM_GI_COUNTERS] = {0}; + char *tx_gi[HTT_TX_PEER_STATS_NUM_GI_COUNTERS]; u8 j; for (j = 0; j < HTT_TX_PEER_STATS_NUM_GI_COUNTERS; j++) diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index 73865ce..2987c0a 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -3411,7 +3411,7 @@ static inline void ath11k_dp_mon_get_buf_len(struct hal_rx_msdu_desc_info *info, struct ath11k_pdev_dp *dp = &ar->dp; struct ath11k_mon_data *pmon = (struct ath11k_mon_data *)&dp->mon_data; struct dp_rxdma_ring *rx_ring = &dp->rxdma_mon_buf_ring; - struct sk_buff *msdu, *last; + struct sk_buff *msdu = NULL, *last = NULL; struct hal_rx_msdu_list msdu_list; void *p_buf_addr_info, *p_last_buf_addr_info; void *rx_desc; @@ -3430,9 +3430,6 @@ static inline void ath11k_dp_mon_get_buf_len(struct hal_rx_msdu_desc_info *info, (struct hal_reo_entrance_ring *)ring_entry; int buf_id; - msdu = 0; - last = NULL; - ath11k_hal_rx_reo_ent_buf_paddr_get(ring_entry, &paddr, &sw_cookie, &p_last_buf_addr_info, &msdu_cnt); diff --git a/drivers/net/wireless/ath/ath11k/qmi.c b/drivers/net/wireless/ath/ath11k/qmi.c index 4f3e25b..89ee81d 100644 --- a/drivers/net/wireless/ath/ath11k/qmi.c +++ b/drivers/net/wireless/ath/ath11k/qmi.c @@ -1803,10 +1803,12 @@ static int ath11k_qmi_request_target_cap(struct ath11k_base *ab) struct device *dev = ab->dev; char filename[ATH11K_QMI_MAX_BDF_FILE_NAME_SIZE]; const struct firmware *fw_entry; - struct ath11k_board_data bd = { 0 }; + struct ath11k_board_data bd; u32 fw_size; int ret = 0; + memset(&bd, 0, sizeof(bd)); + switch (type) { case ATH11K_QMI_FILE_TYPE_BDF_GOLDEN: ret = ath11k_core_fetch_bdf(ab, &bd);