diff mbox series

ath11k: add wrapper function to ath11k_dbg

Message ID 1560855152-2609-1-git-send-email-vnaralas@codeaurora.org (mailing list archive)
State Accepted
Commit 6b4ad0ceb0759ae7421be203c51b01823cf0fc6d
Delegated to: Kalle Valo
Headers show
Series ath11k: add wrapper function to ath11k_dbg | expand

Commit Message

Venkateswara Naralasetty June 18, 2019, 10:52 a.m. UTC 
This patch define a macro for ath11k_dbg() which improves
the Rx performance by avoid calling ath11k_dbg() from
ath11k_dp_rx_deliver_msdu() when no dbg_mask set.

Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
---
v2:
 * corrected one style issue

 drivers/net/wireless/ath/ath11k/debug.c |  6 +++---
 drivers/net/wireless/ath/ath11k/debug.h | 18 ++++++++++++------
 2 files changed, 15 insertions(+), 9 deletions(-)

Comments

Kalle Valo June 18, 2019, 12:51 p.m. UTC | #1 
Venkateswara Naralasetty <vnaralas@codeaurora.org> writes:

> This patch define a macro for ath11k_dbg() which improves
> the Rx performance by avoid calling ath11k_dbg() from
> ath11k_dp_rx_deliver_msdu() when no dbg_mask set.
>
> Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
> ---
> v2:
>  * corrected one style issue

When you submit v2 please remember to mark it as "[PATCH v2]" in the
Subject as well. But no need to resend because of this.
Kalle Valo June 20, 2019, 1:40 p.m. UTC | #2 
Venkateswara Naralasetty <vnaralas@codeaurora.org> wrote:

> This patch define a macro for ath11k_dbg() which improves
> the Rx performance by avoid calling ath11k_dbg() from
> ath11k_dp_rx_deliver_msdu() when no dbg_mask set.
> 
> Signed-off-by: Venkateswara Naralasetty <vnaralas@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath11k-bringup branch of ath.git, thanks.

6b4ad0ceb075 ath11k: add wrapper function to ath11k_dbg
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/debug.c b/drivers/net/wireless/ath/ath11k/debug.c
index 69a2340..6e16c29 100644
--- a/drivers/net/wireless/ath/ath11k/debug.c
+++ b/drivers/net/wireless/ath/ath11k/debug.c
@@ -53,8 +53,8 @@  void ath11k_warn(struct ath11k_base *sc, const char *fmt, ...)
 }
 
 #ifdef CONFIG_ATH11K_DEBUG
-void ath11k_dbg(struct ath11k_base *ab, enum ath11k_debug_mask mask,
-		const char *fmt, ...)
+void __ath11k_dbg(struct ath11k_base *ab, enum ath11k_debug_mask mask,
+		  const char *fmt, ...)
 {
 	struct va_format vaf;
 	va_list args;
@@ -83,7 +83,7 @@  void ath11k_dbg_dump(struct ath11k_base *ab,
 
 	if (ath11k_debug_mask & mask) {
 		if (msg)
-			ath11k_dbg(ab, mask, "%s\n", msg);
+			__ath11k_dbg(ab, mask, "%s\n", msg);
 
 		for (ptr = buf; (ptr - buf) < len; ptr += 16) {
 			linebuflen = 0;
diff --git a/drivers/net/wireless/ath/ath11k/debug.h b/drivers/net/wireless/ath/ath11k/debug.h
index 5774f53..ebc807e 100644
--- a/drivers/net/wireless/ath/ath11k/debug.h
+++ b/drivers/net/wireless/ath/ath11k/debug.h
@@ -106,17 +106,17 @@  __printf(2, 3) void ath11k_warn(struct ath11k_base *sc, const char *fmt, ...);
 extern unsigned int ath11k_debug_mask;
 
 #ifdef CONFIG_ATH11K_DEBUG
-__printf(3, 4) void ath11k_dbg(struct ath11k_base *ab,
-			       enum ath11k_debug_mask mask,
-			       const char *fmt, ...);
+__printf(3, 4) void __ath11k_dbg(struct ath11k_base *ab,
+				 enum ath11k_debug_mask mask,
+				 const char *fmt, ...);
 void ath11k_dbg_dump(struct ath11k_base *ab,
 		     enum ath11k_debug_mask mask,
 		     const char *msg, const char *prefix,
 		     const void *buf, size_t len);
 #else /* CONFIG_ATH11K_DEBUG */
-static inline int ath11k_dbg(struct ath11k_base *ab,
-			     enum ath11k_debug_mask dbg_mask,
-			     const char *fmt, ...)
+static inline int __ath11k_dbg(struct ath11k_base *ab,
+			       enum ath11k_debug_mask dbg_mask,
+			       const char *fmt, ...)
 {
 	return 0;
 }
@@ -272,4 +272,10 @@  static inline void ath11k_sta_update_rx_duration(struct ath11k *ar,
 
 #endif /* CONFIG_MAC80211_DEBUGFS*/
 
+#define ath11k_dbg(ar, dbg_mask, fmt, ...)			\
+do {								\
+	if (ath11k_debug_mask & dbg_mask)			\
+		__ath11k_dbg(ar, dbg_mask, fmt, ##__VA_ARGS__);	\
+} while (0)
+
 #endif /* _ATH11K_DEBUG_H_ */