From patchwork Thu Jun 20 18:59:20 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthikeyan periyasamy X-Patchwork-Id: 11007781 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 945E613AF for ; Thu, 20 Jun 2019 18:59:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 81B8A28783 for ; Thu, 20 Jun 2019 18:59:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7231E28846; Thu, 20 Jun 2019 18:59:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A73D928783 for ; Thu, 20 Jun 2019 18:59:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=Rs3ZGtn5ooHA0jbJHkN23zGiVVWyUFfNIThJkIrcM9w=; b=DrL jk87KLD4y2f06/0V6sgXcE93RYRWnhIZzZiIW3rlOJ9uUghaOxBKOPdeu6N3NTdhbClwRqu05He1M KAgBBqLVzaXKUp6EwwAwLF2HRYRoHTCFGnQQuyXpaZU3WUsv0p8EpS5bTgyfgvYDEpKxtO7c4M7xF 3KnUGRXuhCOEu109WV7LHdnE0PgxGWimeA8Mhl/oXTZOkbqz+Vhfd5PHMlodRYtJao9xdRzT4XPLl v9MbAxbnIe+OgzupY8pbmc+Cdjt47GuCoW/E0YbAVzHXbsneuBHbHA7dIpFVo/EIRRdquUDiYpZ8t hcQUeBx+wRWjC8B6arBMlfU3se7y3Vg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1he2Hf-0003X7-RU; Thu, 20 Jun 2019 18:59:43 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1he2Hc-0003W4-Gq for ath11k@lists.infradead.org; Thu, 20 Jun 2019 18:59:42 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 314BE602F1; Thu, 20 Jun 2019 18:59:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561057180; bh=9wyaNoYx5org2F3lGUN5WKDLeJNjfR8h/LREpWGc/Vg=; h=From:To:Cc:Subject:Date:From; b=J/uTAYI5RH3xa3HP0Ibc1FONZfQ2a3zN5NhKrHS66g4cg1boY1z9smIMlo5Hq4bS5 L6lRBwYDQpvO2oBWhn/uuurNU4A4QrzNI1xNU8nG5O145vRg19ajD3JwfmwtHaX9iT wjPXMPxJU3Wot5IDqhnwrjE4OnHwVOwP12hsDqSI= Received: from CHECSTP284781-LIN.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: periyasa@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 846FA6028D; Thu, 20 Jun 2019 18:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561057179; bh=9wyaNoYx5org2F3lGUN5WKDLeJNjfR8h/LREpWGc/Vg=; h=From:To:Cc:Subject:Date:From; b=QPvgE3aXXCDrlnodEQJD7nxmBHvaSyOSL72U9gP4MgaaoFuVnFaVpdZ7VXk7RCKN0 kqop5qZLB6V3x41KE1h7dAvJENpKsw3S0POv8KX2/mw2Z8h+JBgWhAfdUNs7LEJDo6 B8Kyo7cpaWu3W+KopLyJrwHKt03Z0lJExrRWEW7U= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 846FA6028D Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=periyasa@codeaurora.org From: Karthikeyan Periyasamy To: ath11k@lists.infradead.org Subject: [PATCH] ath11k: Avoid blank lines related warning Date: Fri, 21 Jun 2019 00:29:20 +0530 Message-Id: <1561057160-32679-1-git-send-email-periyasa@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_115940_597032_37BDBCAD X-CRM114-Status: GOOD ( 13.49 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karthikeyan Periyasamy MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP drivers/net/wireless/ath/ath11k/ce.c:496: Blank lines aren't necessary before a close brace '}' drivers/net/wireless/ath/ath11k/core.h:156: Please don't use multiple blank lines drivers/net/wireless/ath/ath11k/core.c:325: Blank lines aren't necessary before a close brace '}' drivers/net/wireless/ath/ath11k/debug.h:123: Please use a blank line after function/struct/union/enum declarations drivers/net/wireless/ath/ath11k/debug.h:128: Blank lines aren't necessary after an open brace '{' drivers/net/wireless/ath/ath11k/debug.h:129: Blank lines aren't necessary before a close brace '}' drivers/net/wireless/ath/ath11k/debug.c:103: Blank lines aren't necessary before a close brace '}' drivers/net/wireless/ath/ath11k/debug_htt_stats.h:1611: Blank lines aren't necessary after an open brace '{' drivers/net/wireless/ath/ath11k/hal.h:251: Please don't use multiple blank lines drivers/net/wireless/ath/ath11k/dp_rx.c:2249: Blank lines aren't necessary after an open brace '{' drivers/net/wireless/ath/ath11k/dp_rx.c:3223: Please don't use multiple blank lines drivers/net/wireless/ath/ath11k/debug_htt_stats.c:3430: Please don't use multiple blank lines drivers/net/wireless/ath/ath11k/rx_desc.h:380: Please don't use multiple blank lines drivers/net/wireless/ath/ath11k/mac.c:771: Please use a blank line after function/struct/union/enum declarations drivers/net/wireless/ath/ath11k/mac.c:1832: Missing a blank line after declarations drivers/net/wireless/ath/ath11k/mac.c:2627: Blank lines aren't necessary before a close brace '}' drivers/net/wireless/ath/ath11k/mac.c:5558: Blank lines aren't necessary before a close brace '}' drivers/net/wireless/ath/ath11k/mac.c:5636: Blank lines aren't necessary before a close brace '}' drivers/net/wireless/ath/ath11k/wmi.h:5061: Please don't use multiple blank lines drivers/net/wireless/ath/ath11k/wmi.h:5134: Missing a blank line after declarations drivers/net/wireless/ath/ath11k/wmi.c:532: Please don't use multiple blank lines drivers/net/wireless/ath/ath11k/wmi.c:2113: Please don't use multiple blank lines Signed-off-by: Karthikeyan Periyasamy --- drivers/net/wireless/ath/ath11k/ce.c | 1 - drivers/net/wireless/ath/ath11k/core.c | 1 - drivers/net/wireless/ath/ath11k/core.h | 1 - drivers/net/wireless/ath/ath11k/debug.c | 1 - drivers/net/wireless/ath/ath11k/debug.h | 3 ++- drivers/net/wireless/ath/ath11k/debug_htt_stats.c | 1 - drivers/net/wireless/ath/ath11k/debug_htt_stats.h | 1 - drivers/net/wireless/ath/ath11k/dp_rx.c | 2 -- drivers/net/wireless/ath/ath11k/hal.h | 1 - drivers/net/wireless/ath/ath11k/mac.c | 5 ++--- drivers/net/wireless/ath/ath11k/rx_desc.h | 1 - drivers/net/wireless/ath/ath11k/wmi.c | 2 -- drivers/net/wireless/ath/ath11k/wmi.h | 4 +--- 13 files changed, 5 insertions(+), 19 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/ce.c b/drivers/net/wireless/ath/ath11k/ce.c index 048adc1..33306b9 100644 --- a/drivers/net/wireless/ath/ath11k/ce.c +++ b/drivers/net/wireless/ath/ath11k/ce.c @@ -491,7 +491,6 @@ void ath11k_ce_per_engine_service(struct ath11k_base *ab, u16 ce_id) if (pipe->recv_cb) ath11k_ce_recv_process_cb(pipe); - } void ath11k_ce_poll_send_completed(struct ath11k_base *ab, u8 pipe_id) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index c6dd9ba..8be6a62 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -321,7 +321,6 @@ int ath11k_core_fetch_bdf(struct ath11k_base *sc, struct ath11k_board_data *bd) success: ath11k_dbg(sc, ATH11K_DBG_BOOT, "using board api %d\n", sc->bd_api); return 0; - } static void ath11k_core_stop(struct ath11k_base *sc) diff --git a/drivers/net/wireless/ath/ath11k/core.h b/drivers/net/wireless/ath/ath11k/core.h index f2990d3..e8278cc 100644 --- a/drivers/net/wireless/ath/ath11k/core.h +++ b/drivers/net/wireless/ath/ath11k/core.h @@ -153,7 +153,6 @@ enum ath11k_scan_state { ATH11K_SCAN_ABORTING, }; - enum ath11k_dev_flags { ATH11K_CAC_RUNNING, ATH11K_FLAG_CORE_REGISTERED, diff --git a/drivers/net/wireless/ath/ath11k/debug.c b/drivers/net/wireless/ath/ath11k/debug.c index 4aace02..4b124d7 100644 --- a/drivers/net/wireless/ath/ath11k/debug.c +++ b/drivers/net/wireless/ath/ath11k/debug.c @@ -100,7 +100,6 @@ void ath11k_dbg_dump(struct ath11k_base *ab, dev_printk(KERN_DEBUG, ab->dev, "%s\n", linebuf); } } - } #endif diff --git a/drivers/net/wireless/ath/ath11k/debug.h b/drivers/net/wireless/ath/ath11k/debug.h index 04d9f32..d6a8135 100644 --- a/drivers/net/wireless/ath/ath11k/debug.h +++ b/drivers/net/wireless/ath/ath11k/debug.h @@ -120,12 +120,13 @@ static inline int __ath11k_dbg(struct ath11k_base *ab, { return 0; } + static inline void ath11k_dbg_dump(struct ath11k_base *ab, enum ath11k_debug_mask mask, const char *msg, const char *prefix, const void *buf, size_t len) { - + return; } #endif /* CONFIG_ATH11K_DEBUG */ diff --git a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c b/drivers/net/wireless/ath/ath11k/debug_htt_stats.c index cd8510c..596b763 100644 --- a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c +++ b/drivers/net/wireless/ath/ath11k/debug_htt_stats.c @@ -3427,7 +3427,6 @@ static inline void htt_print_rx_pdev_fw_stats_tlv(const u32 *tag_buf, len += HTT_DBG_OUT(buf + len, buf_len - len, "fw_ring_mgmt_subtype = %s ", fw_ring_mgmt_subtype); - ARRAY_TO_STRING(fw_ring_ctrl_subtype, htt_stats_buf->fw_ring_ctrl_subtype, HTT_STATS_SUBTYPE_MAX); diff --git a/drivers/net/wireless/ath/ath11k/debug_htt_stats.h b/drivers/net/wireless/ath/ath11k/debug_htt_stats.h index 377ddd8..3ce4ba2 100644 --- a/drivers/net/wireless/ath/ath11k/debug_htt_stats.h +++ b/drivers/net/wireless/ath/ath11k/debug_htt_stats.h @@ -1612,7 +1612,6 @@ struct htt_tx_sounding_stats_tlv { }; struct htt_pdev_obss_pd_stats_tlv { - u32 num_obss_tx_ppdu_success; u32 num_obss_tx_ppdu_failure; }; diff --git a/drivers/net/wireless/ath/ath11k/dp_rx.c b/drivers/net/wireless/ath/ath11k/dp_rx.c index c64beb5..854d8ca 100644 --- a/drivers/net/wireless/ath/ath11k/dp_rx.c +++ b/drivers/net/wireless/ath/ath11k/dp_rx.c @@ -2196,7 +2196,6 @@ int ath11k_dp_process_rx(struct ath11k_base *ab, int mac_id, ath11k_hal_srng_access_begin(ab, srng); while ((rx_desc = ath11k_dp_rx_get_reo_desc(ab, srng))) { - memset(&meta_info, 0, sizeof(meta_info)); ath11k_hal_rx_parse_dst_ring_desc(ab, rx_desc, &meta_info); @@ -3170,7 +3169,6 @@ int ath11k_dp_rx_process_wbm_err(struct ath11k_base *ab, if (!total_num_buffs_reaped) goto done; - for (i = 0; i < ab->num_radios; i++) { if (!num_buffs_reaped[i]) continue; diff --git a/drivers/net/wireless/ath/ath11k/hal.h b/drivers/net/wireless/ath/ath11k/hal.h index 6649dd2..8ee4446 100644 --- a/drivers/net/wireless/ath/ath11k/hal.h +++ b/drivers/net/wireless/ath/ath11k/hal.h @@ -248,7 +248,6 @@ #define HAL_ADDR_MSB_REG_SHIFT 32 - /* WBM ring bit field mask and shift */ #define HAL_WBM_LINK_DESC_IDLE_LIST_MODE BIT(1) #define HAL_WBM_SCATTER_BUFFER_SIZE GENMASK(10, 2) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index c1e9c34..42ebc40 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -648,6 +648,7 @@ static int ath11k_monitor_vdev_up(struct ath11k *ar, int vdev_id) vdev_id); return 0; } + static int ath11k_config(struct ieee80211_hw *hw, u32 changed) { struct ath11k *ar = hw->priv; @@ -1710,6 +1711,7 @@ static void ath11k_bss_info_changed(struct ieee80211_hw *hw, if (changed & BSS_CHANGED_ERP_CTS_PROT) { u32 cts_prot; + cts_prot = !!(info->use_cts_prot); param_id = WMI_VDEV_PARAM_PROTECTION_MODE; @@ -2504,7 +2506,6 @@ static void ath11k_sta_rc_update_wk(struct work_struct *wk) if (!wait_for_completion_timeout(&ar->peer_assoc_done, 1 * HZ)) ath11k_warn(ar->ab, "failed to get peer assoc conf event for %pM vdev %i\n", sta->addr, arvif->vdev_id); - } } @@ -5468,7 +5469,6 @@ void ath11k_mac_unregister(struct ath11k_base *ab) kfree(ar->mac.sbands[NL80211_BAND_5GHZ].channels); SET_IEEE80211_DEV(ar->hw, NULL); - } ab->mac_registered = false; } @@ -5546,7 +5546,6 @@ int ath11k_mac_create(struct ath11k_base *ab) idr_init(&ar->txmgmt_idr); spin_lock_init(&ar->txmgmt_idr_lock); - } /* Initialize channel counters frequency value in hertz */ diff --git a/drivers/net/wireless/ath/ath11k/rx_desc.h b/drivers/net/wireless/ath/ath11k/rx_desc.h index 57518a0..3bc2bbe 100644 --- a/drivers/net/wireless/ath/ath11k/rx_desc.h +++ b/drivers/net/wireless/ath/ath11k/rx_desc.h @@ -377,7 +377,6 @@ struct rx_attention { #define RX_MPDU_START_INFO3_RXDMA0_SRC_RING_SEL GENMASK(12, 11) #define RX_MPDU_START_INFO3_RXDMA0_DST_RING_SEL GENMASK(14, 13) - #define RX_MPDU_START_INFO4_REO_QUEUE_DESC_HI GENMASK(7, 0) #define RX_MPDU_START_INFO4_RECV_QUEUE_NUM GENMASK(23, 8) #define RX_MPDU_START_INFO4_PRE_DELIM_ERR_WARN BIT(24) diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c index c9a239e..e563867 100644 --- a/drivers/net/wireless/ath/ath11k/wmi.c +++ b/drivers/net/wireless/ath/ath11k/wmi.c @@ -530,7 +530,6 @@ int ath11k_wmi_mgmt_send(struct ath11k *ar, u32 vdev_id, u32 buf_id, if (!skb) return -ENOMEM; - cmd = (struct wmi_mgmt_send_cmd *)skb->data; cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_MGMT_TX_SEND_CMD) | FIELD_PREP(WMI_TLV_LEN, sizeof(*cmd) - TLV_HDR_SIZE); @@ -2111,7 +2110,6 @@ int ath11k_wmi_send_scan_chan_list_cmd(struct ath11k *ar, cmd->tlv_header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_SCAN_CHAN_LIST_CMD) | FIELD_PREP(WMI_TLV_LEN, sizeof(*cmd) - TLV_HDR_SIZE); - ath11k_dbg(ar->ab, ATH11K_DBG_WMI, "WMI no.of chan = %d len = %d\n", chan_list->nallchans, len); cmd->pdev_id = chan_list->pdev_id; diff --git a/drivers/net/wireless/ath/ath11k/wmi.h b/drivers/net/wireless/ath/ath11k/wmi.h index 1239eaf..4e92bf0 100644 --- a/drivers/net/wireless/ath/ath11k/wmi.h +++ b/drivers/net/wireless/ath/ath11k/wmi.h @@ -5058,7 +5058,6 @@ enum ath11k_hw_txrx_mode { ATH11K_HW_TXRX_ETHERNET = 2, }; - struct wmi_wmm_params { u32 tlv_header; u32 cwmin; @@ -5131,8 +5130,7 @@ struct target_resource_config { u32 tt_support; u32 atf_config; u32 iphdr_pad_config; - u32 - qwrap_config:16, + u32 qwrap_config:16, alloc_frag_desc_for_data_pkt:16; u32 num_tdls_vdevs; u32 num_tdls_conn_table_entries;