From patchwork Thu Jun 20 19:05:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthikeyan periyasamy X-Patchwork-Id: 11007793 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 027CD112C for ; Thu, 20 Jun 2019 19:05:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E56D62832D for ; Thu, 20 Jun 2019 19:05:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D595328856; Thu, 20 Jun 2019 19:05:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 35D3B2832D for ; Thu, 20 Jun 2019 19:05:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=XtT1owZBFak+FYgzJdR2p2JuoqhnGqdw9fWYjh8QSDk=; b=Bln cgk+xGGN3RQ3Lf/5/pPAMoVn9eUGbHVdvc6SeTRWiMue478XeC2NQU405gqdj1JErXo6gxLNfhu32 ZARoL+gn6JXeeCzZLoNXYCN/CmHAIy3qbt7OemycD8IcM7ee06i8/0uQ0L2NPtSIQBSZuHapCmjuK OSDLLNsF8BRrrH+s3zQ1ccM3TZGekeXk9t5Twi7YpoR5HMosN7nEMAdkTczk6mg719wVTNsL7fhhC aOJG+7/hCGfbaQ3P1Hv9hKfJRHGAZf+fy2cG7laM4ereZEYWSlMeuDGVuQCs71VCTGClWdL23FLN/ afA8WLCUuwRywkjlMBGbAsfBtRzc/ZQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1he2Ng-0006xx-F4; Thu, 20 Jun 2019 19:05:56 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1he2Nd-0006xN-3c for ath11k@lists.infradead.org; Thu, 20 Jun 2019 19:05:54 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D768C6014B; Thu, 20 Jun 2019 19:05:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561057552; bh=Nqv2l2KMaIXXIEH9a50Jiyb/C1VSzBWIg40g5itGgSA=; h=From:To:Cc:Subject:Date:From; b=jvE4jGDWlxtsAjx08XRZgg215FsuH4I8od6K1RpBhgNtiZ+Z+rFuyT214nKAhoh/6 i/sYnMmU3/I2pTuddTWr/4HaDNR6QMn1zy04saYG7ckS8/mZXCGV123L1Vk8Qmtxy8 q4hl483As3MOIcxcA+2zcRiEZuAsI6ZiKqYnMHkE= Received: from CHECSTP284781-LIN.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: periyasa@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 3D46560274; Thu, 20 Jun 2019 19:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561057552; bh=Nqv2l2KMaIXXIEH9a50Jiyb/C1VSzBWIg40g5itGgSA=; h=From:To:Cc:Subject:Date:From; b=jvE4jGDWlxtsAjx08XRZgg215FsuH4I8od6K1RpBhgNtiZ+Z+rFuyT214nKAhoh/6 i/sYnMmU3/I2pTuddTWr/4HaDNR6QMn1zy04saYG7ckS8/mZXCGV123L1Vk8Qmtxy8 q4hl483As3MOIcxcA+2zcRiEZuAsI6ZiKqYnMHkE= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 3D46560274 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=periyasa@codeaurora.org From: Karthikeyan Periyasamy To: ath11k@lists.infradead.org Subject: [PATCH] ath11k: fix Block comments warnings Date: Fri, 21 Jun 2019 00:35:33 +0530 Message-Id: <1561057533-601-1-git-send-email-periyasa@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190620_120553_188146_E110884C X-CRM114-Status: GOOD ( 13.49 ) X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karthikeyan Periyasamy MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP drivers/net/wireless/ath/ath11k/hal_desc.h:1382: Block comments should align the * on each line drivers/net/wireless/ath/ath11k/hal_desc.h:1440: Block comments should align the * on each line drivers/net/wireless/ath/ath11k/mac.c:3233: Block comments use a trailing */ on a separate line Signed-off-by: Karthikeyan Periyasamy --- drivers/net/wireless/ath/ath11k/hal_desc.h | 208 ++++++++++++++--------------- drivers/net/wireless/ath/ath11k/mac.c | 3 +- 2 files changed, 105 insertions(+), 106 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/hal_desc.h b/drivers/net/wireless/ath/ath11k/hal_desc.h index 99ab6f6..2b2f19a 100644 --- a/drivers/net/wireless/ath/ath11k/hal_desc.h +++ b/drivers/net/wireless/ath/ath11k/hal_desc.h @@ -1378,46 +1378,45 @@ struct hal_ce_srng_dest_desc { u32 buffer_addr_info; /* %HAL_CE_DEST_DESC_ADDR_INFO_ */ } __packed; -/* -* hal_ce_srng_dest_desc -* -* dst_buffer_low -* LSB 32 bits of the 40 Bit Pointer to the Destination -* buffer -* -* dst_buffer_high -* MSB 8 bits of the 40 Bit Pointer to the Destination -* buffer -* -* ce_res_4 -* Reserved -* -* ring_id -* The buffer pointer ring ID. -* 0 refers to the IDLE ring -* 1 - N refers to other rings -* Helps with debugging when dumping ring contents. -* -* looping_count -* A count value that indicates the number of times the -* producer of entries into the Ring has looped around the -* ring. -* -* At initialization time, this value is set to 0. On the -* first loop, this value is set to 1. After the max value is -* reached allowed by the number of bits for this field, the -* count value continues with 0 again. -* -* In case SW is the consumer of the ring entries, it can -* use this field to figure out up to where the producer of -* entries has created new entries. This eliminates the need to -* check where the head pointer' of the ring is located once -* the SW starts processing an interrupt indicating that new -* entries have been put into this ring... -* -* Also note that SW if it wants only needs to look at the -* LSB bit of this count value. -*/ +/* hal_ce_srng_dest_desc + * + * dst_buffer_low + * LSB 32 bits of the 40 Bit Pointer to the Destination + * buffer + * + * dst_buffer_high + * MSB 8 bits of the 40 Bit Pointer to the Destination + * buffer + * + * ce_res_4 + * Reserved + * + * ring_id + * The buffer pointer ring ID. + * 0 refers to the IDLE ring + * 1 - N refers to other rings + * Helps with debugging when dumping ring contents. + * + * looping_count + * A count value that indicates the number of times the + * producer of entries into the Ring has looped around the + * ring. + * + * At initialization time, this value is set to 0. On the + * first loop, this value is set to 1. After the max value is + * reached allowed by the number of bits for this field, the + * count value continues with 0 again. + * + * In case SW is the consumer of the ring entries, it can + * use this field to figure out up to where the producer of + * entries has created new entries. This eliminates the need to + * check where the head pointer' of the ring is located once + * the SW starts processing an interrupt indicating that new + * entries have been put into this ring... + * + * Also note that SW if it wants only needs to look at the + * LSB bit of this count value. + */ #define HAL_CE_DST_STATUS_DESC_FLAGS_HASH_EN BIT(8) #define HAL_CE_DST_STATUS_DESC_FLAGS_BYTE_SWAP BIT(9) @@ -1436,71 +1435,70 @@ struct hal_ce_srng_dst_status_desc { u32 meta_info; /* HAL_CE_DST_STATUS_DESC_META_INFO_ */ } __packed; -/* -* hal_ce_srng_dst_status_desc -* -* ce_res_5 -* Reserved -* -* toeplitz_en -* -* src_swap -* Source memory buffer swapped -* -* dest_swap -* Destination memory buffer swapped -* -* gather -* Gather of multiple copy engine source descriptors to one -* destination enabled -* -* ce_res_6 -* Reserved -* -* length -* Sum of all the Lengths of the source descriptor in the -* gather chain -* -* toeplitz_hash_0 -* 32 LS bits of 64 bit Toeplitz LFSR hash result -* -* toeplitz_hash_1 -* 32 MS bits of 64 bit Toeplitz LFSR hash result -* -* fw_metadata -* Meta data used by FW -* In case of gather field in first source ring entry of -* the gather copy cycle in taken into account. -* -* ce_res_7 -* Reserved -* -* ring_id -* The buffer pointer ring ID. -* 0 refers to the IDLE ring -* 1 - N refers to other rings -* Helps with debugging when dumping ring contents. -* -* looping_count -* A count value that indicates the number of times the -* producer of entries into the Ring has looped around the -* ring. -* -* At initialization time, this value is set to 0. On the -* first loop, this value is set to 1. After the max value is -* reached allowed by the number of bits for this field, the -* count value continues with 0 again. -* -* In case SW is the consumer of the ring entries, it can -* use this field to figure out up to where the producer of -* entries has created new entries. This eliminates the need to -* check where the head pointer' of the ring is located once -* the SW starts processing an interrupt indicating that new -* entries have been put into this ring... -* -* Also note that SW if it wants only needs to look at the -* LSB bit of this count value. -*/ +/* hal_ce_srng_dst_status_desc + * + * ce_res_5 + * Reserved + * + * toeplitz_en + * + * src_swap + * Source memory buffer swapped + * + * dest_swap + * Destination memory buffer swapped + * + * gather + * Gather of multiple copy engine source descriptors to one + * destination enabled + * + * ce_res_6 + * Reserved + * + * length + * Sum of all the Lengths of the source descriptor in the + * gather chain + * + * toeplitz_hash_0 + * 32 LS bits of 64 bit Toeplitz LFSR hash result + * + * toeplitz_hash_1 + * 32 MS bits of 64 bit Toeplitz LFSR hash result + * + * fw_metadata + * Meta data used by FW + * In case of gather field in first source ring entry of + * the gather copy cycle in taken into account. + * + * ce_res_7 + * Reserved + * + * ring_id + * The buffer pointer ring ID. + * 0 refers to the IDLE ring + * 1 - N refers to other rings + * Helps with debugging when dumping ring contents. + * + * looping_count + * A count value that indicates the number of times the + * producer of entries into the Ring has looped around the + * ring. + * + * At initialization time, this value is set to 0. On the + * first loop, this value is set to 1. After the max value is + * reached allowed by the number of bits for this field, the + * count value continues with 0 again. + * + * In case SW is the consumer of the ring entries, it can + * use this field to figure out up to where the producer of + * entries has created new entries. This eliminates the need to + * check where the head pointer' of the ring is located once + * the SW starts processing an interrupt indicating that new + * entries have been put into this ring... + * + * Also note that SW if it wants only needs to look at the + * LSB bit of this count value. + */ #define HAL_TX_RATE_STATS_INFO0_VALID BIT(0) #define HAL_TX_RATE_STATS_INFO0_BW GENMASK(2, 1) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index 613590e..23974be 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -3106,7 +3106,8 @@ static void ath11k_mac_setup_ht_vht_cap(struct ath11k *ar, static int ath11k_check_chain_mask(struct ath11k *ar, u32 ant, bool is_tx_ant) { /* TODO: Check the request chainmask against the supported - * chainmask table which is advertised in extented_service_ready event */ + * chainmask table which is advertised in extented_service_ready event + */ return 0; }