From patchwork Mon Jun 24 11:49:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manikanta Pubbisetty X-Patchwork-Id: 11012939 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CD35C1398 for ; Mon, 24 Jun 2019 11:50:07 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BE6F128BB1 for ; Mon, 24 Jun 2019 11:50:07 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B2D9C28BC8; Mon, 24 Jun 2019 11:50:07 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 6BFD928BB1 for ; Mon, 24 Jun 2019 11:50:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=KcrqHgLbOR/5w/tWaotj3hCBq4j6rmD8TNBSzv5e7HI=; b=EmX8AZEML5mSXgWC+x6XdJbN7d QPCVZlFD4kntnI5j+1UYW5ECFTTE7mX4pvzOr5h64VQMjgm07BmPuVkJPbWs7ovSZJYBkI8JIZ/uQ 8FWWyVritocd3iUTvvbUbDi2JXbWLxQnTv3249ZEIA7DTiC2bs3NusEKXJQEjbyROExvUwhKn6MOY wgvd1+OZNpoEQP01tyT5HI8vZ0cSFoXFbfd9hLTxiFlVoT1mdjvzaR7F7ciaF4RSbYwQUCqKnUplh 6oK+NTmMQKzeV3gQmfOeg/ALm4kleprszRYmoNERy800iqpYf+oAZJSM8Eu8B6RWGwX0NO3cmbIfW CjzNlPaQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfNU6-0005d6-F7; Mon, 24 Jun 2019 11:50:06 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfNU3-0005Cv-1J for ath11k@lists.infradead.org; Mon, 24 Jun 2019 11:50:04 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 581FB60DAA; Mon, 24 Jun 2019 11:50:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561377002; bh=OLqnbcEyWm6jmTWjQvRUhMDuCeARkdTAhwW1nLPIbTg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g2PqRrB3RUu5YkYEBoYNGDRYMQ1bHvkMZKdwxddEnzSrgPvfEK69xF5JmLPP/Pg+2 8mxjisfu2IwLGzMLmtjHPFFkYUw2MVmME7yFpAoZqmOjobGSdoYLLAJPvzQ0839cbK Q3/SzpNiAqdM38wd8FBu4kOGojzbGmjRgBUM1DwY= Received: from vnaralas-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mpubbise@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 1C2F860C72; Mon, 24 Jun 2019 11:50:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561377002; bh=OLqnbcEyWm6jmTWjQvRUhMDuCeARkdTAhwW1nLPIbTg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=g2PqRrB3RUu5YkYEBoYNGDRYMQ1bHvkMZKdwxddEnzSrgPvfEK69xF5JmLPP/Pg+2 8mxjisfu2IwLGzMLmtjHPFFkYUw2MVmME7yFpAoZqmOjobGSdoYLLAJPvzQ0839cbK Q3/SzpNiAqdM38wd8FBu4kOGojzbGmjRgBUM1DwY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 1C2F860C72 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mpubbise@codeaurora.org From: Manikanta Pubbisetty To: ath11k@lists.infradead.org Subject: [PATCH 6/8] ath11k: avoid use of magic numbers Date: Mon, 24 Jun 2019 17:19:27 +0530 Message-Id: <1561376969-3999-6-git-send-email-mpubbise@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1561376969-3999-1-git-send-email-mpubbise@codeaurora.org> References: <1561376969-3999-1-git-send-email-mpubbise@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_045003_122206_6FE7190C X-CRM114-Status: UNSURE ( 9.72 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Manikanta Pubbisetty MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Use macros where ever necessary, replace magic numbers with appropriate macros in mac.c file. Signed-off-by: Manikanta Pubbisetty --- drivers/net/wireless/ath/ath11k/mac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index f878479..2fd1bfc 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -167,6 +167,8 @@ const struct htt_rx_ring_tlv_filter ath11k_mac_mon_status_filter_default = { #define ath11k_a_rates (ath11k_legacy_rates + 4) #define ath11k_a_rates_size (ARRAY_SIZE(ath11k_legacy_rates) - 4) +#define ATH11K_MAC_SCAN_TIMEOUT_MSECS 200 /* in msecs */ + static const u32 ath11k_smps_map[] = { [WLAN_HT_CAP_SM_PS_STATIC] = WMI_PEER_SMPS_STATIC, [WLAN_HT_CAP_SM_PS_DYNAMIC] = WMI_PEER_SMPS_DYNAMIC, @@ -2027,7 +2029,7 @@ static int ath11k_mac_op_hw_scan(struct ieee80211_hw *hw, /* Add a 200ms margin to account for event/command processing */ ieee80211_queue_delayed_work(ar->hw, &ar->scan.timeout, msecs_to_jiffies(arg.max_scan_time + - 200)); + ATH11K_MAC_SCAN_TIMEOUT_MSECS)); exit: if (req->ie_len)