From patchwork Mon Jun 24 11:49:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Manikanta Pubbisetty X-Patchwork-Id: 11012943 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A1F9614BB for ; Mon, 24 Jun 2019 11:50:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 935C128BC2 for ; Mon, 24 Jun 2019 11:50:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 91EC428BC6; Mon, 24 Jun 2019 11:50:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2D6F528BC2 for ; Mon, 24 Jun 2019 11:50:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:References: In-Reply-To:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=03NxYFr9/RNprhXlFYagFpFiHIfXd3uj5nMmCH21VFs=; b=KduYhqO5sutrDHRn/mhgiI84lL Imcjpb4jn512E/9MTxsLPOOkVxmZJ4NmgDkmaX50d/PSh/qZcPsFhmQcwWiNM0JXSF7+Dm98C4h19 bembthP6FMqb6sj4eP0DrRiYhfEmRtLx2wUFqQDDpNiGueUQQSn2AnFofkws9CJiSVygfTKfLCeXP ur2qwlX0n8ZUFgFbR2VGdNIZf6EBrle2hvmNcEbG0WxdehbI2kouCxyj5pGAcbdAZLiY4oFg6ciXb jPw4IQ3ItOPNueGYmsm2z2uf4lw2usdyI7L7cF9VMRlU6WRKao3Oa2A2jiq//2TWUdcivDrq++sSI Gx23luPA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hfNUA-0006Ab-Fl; Mon, 24 Jun 2019 11:50:10 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hfNU7-0005i0-7c for ath11k@lists.infradead.org; Mon, 24 Jun 2019 11:50:08 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id E05E260FE9; Mon, 24 Jun 2019 11:50:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561377006; bh=QSKhF5Xni7gDgw8ZNGayw9vMtlqv2HwSRVo9kvWKBHs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JIUpyWUgYPQUXAP/QCWgkXJ3kyRvNk09QwrlMzPc/Mvv3J+uwtK+gLWZBqEX/V+Zl gvkm8Li64W7+rQgubkcq/8L8l/75YDtpm5HQX7fJe6EZGZ5PRIj+uGRKYNPSrhAPNz w7tvH0Ry7JvTJlXWRPsH90qLrn5NTVpNhIcNcH5E= Received: from vnaralas-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: mpubbise@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A26F060E7A; Mon, 24 Jun 2019 11:50:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1561377006; bh=QSKhF5Xni7gDgw8ZNGayw9vMtlqv2HwSRVo9kvWKBHs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JIUpyWUgYPQUXAP/QCWgkXJ3kyRvNk09QwrlMzPc/Mvv3J+uwtK+gLWZBqEX/V+Zl gvkm8Li64W7+rQgubkcq/8L8l/75YDtpm5HQX7fJe6EZGZ5PRIj+uGRKYNPSrhAPNz w7tvH0Ry7JvTJlXWRPsH90qLrn5NTVpNhIcNcH5E= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A26F060E7A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mpubbise@codeaurora.org From: Manikanta Pubbisetty To: ath11k@lists.infradead.org Subject: [PATCH 8/8] ath11k: use switch statement when necessary Date: Mon, 24 Jun 2019 17:19:29 +0530 Message-Id: <1561376969-3999-8-git-send-email-mpubbise@codeaurora.org> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1561376969-3999-1-git-send-email-mpubbise@codeaurora.org> References: <1561376969-3999-1-git-send-email-mpubbise@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190624_045007_314319_D05796DC X-CRM114-Status: UNSURE ( 9.73 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Manikanta Pubbisetty MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP use switch statement instead of mutliple if statements in ath11k_mac_op_add_interface() in mac.c file. Signed-off-by: Manikanta Pubbisetty --- drivers/net/wireless/ath/ath11k/mac.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index 2274f77..fa92cf7 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -3828,7 +3828,8 @@ static int ath11k_mac_op_add_interface(struct ieee80211_hw *hw, goto err_vdev_del; } - if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { + switch (arvif->vdev_type) { + case WMI_VDEV_TYPE_AP: peer_param.vdev_id = arvif->vdev_id; peer_param.peer_addr = vif->addr; peer_param.peer_type = WMI_PEER_TYPE_DEFAULT; @@ -3838,18 +3839,15 @@ static int ath11k_mac_op_add_interface(struct ieee80211_hw *hw, arvif->vdev_id, ret); goto err_vdev_del; } - } - if (arvif->vdev_type == WMI_VDEV_TYPE_AP) { ret = ath11k_mac_set_kickout(arvif); if (ret) { ath11k_warn(ar->ab, "failed to set vdev %i kickout parameters: %d\n", arvif->vdev_id, ret); goto err_peer_del; } - } - - if (arvif->vdev_type == WMI_VDEV_TYPE_STA) { + break; + case WMI_VDEV_TYPE_STA: param_id = WMI_STA_PS_PARAM_RX_WAKE_POLICY; param_value = WMI_STA_PS_RX_WAKE_POLICY_WAKE; ret = ath11k_wmi_set_sta_ps_param(ar, arvif->vdev_id, @@ -3879,6 +3877,9 @@ static int ath11k_mac_op_add_interface(struct ieee80211_hw *hw, arvif->vdev_id, ret); goto err_peer_del; } + break; + default: + break; } arvif->txpower = vif->bss_conf.txpower;