From patchwork Tue Jul 16 14:04:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Karthikeyan periyasamy X-Patchwork-Id: 11046167 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B8B586C5 for ; Tue, 16 Jul 2019 14:04:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A3440228C9 for ; Tue, 16 Jul 2019 14:04:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 92E0C284E8; Tue, 16 Jul 2019 14:04:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4D259228C9 for ; Tue, 16 Jul 2019 14:04:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=COeEwBYiYnAD0+Y7sX+K7sw4cpINw6/2xLgIhcXiFR8=; b=bcB ONmBKKBtdxpV1Yb7iH2Mj28f6vzs+ihULUyH2JVN/2fouBtTDGhoowV6KRc8XLjIHN8eW7fLix0XS zLGVa1s8G+fykU2rJ7seEx/zNTvL0ZWxktz0Z3vmI0+nNtMhhrJopZJmNR9g7DqhwYwKHliAtQnYa Eccgnei314NxbooaExDxJYY6H3wIXvqFMITMnwyezXsAslOo6k5whJMsHAsT5+SgsPbkIVQ2ygyTS 2cdsa1EpnPfBqmw2PxMLFNaUa/DDgP+IK3DVqwogALGKEbzbAfHSi5Sf1ma2uniwob/XF5GnXbmcY ZAxUflkmX/X5FWJvoZOsEREsCzxK1+w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnO4f-0006U7-HK; Tue, 16 Jul 2019 14:04:57 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hnO4d-0006Tm-79 for ath11k@lists.infradead.org; Tue, 16 Jul 2019 14:04:56 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id D09CF6119E; Tue, 16 Jul 2019 14:04:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563285894; bh=OpbpmQXLyuMDxP44srk5qInzo5FnIH3RFC2v8tZwPUM=; h=From:To:Cc:Subject:Date:From; b=bOAss9y4u94UuPWivvEUeX5VnybE0cnGobcO6a7XBh278myKiaRCgYWQzgyuEIzoc cRPAvGyTt2S9L0mlooiHdFXtGJqmjYUN9Bsx/WY3da375bt+dYj2NGKeUbtJLQn+iW 7UcWN5lEnrzekCufmrFFqWaGjXYkGtKe/8n342NA= Received: from CHECSTP284781-LIN.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: periyasa@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 5CA6061845; Tue, 16 Jul 2019 14:04:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1563285894; bh=OpbpmQXLyuMDxP44srk5qInzo5FnIH3RFC2v8tZwPUM=; h=From:To:Cc:Subject:Date:From; b=bOAss9y4u94UuPWivvEUeX5VnybE0cnGobcO6a7XBh278myKiaRCgYWQzgyuEIzoc cRPAvGyTt2S9L0mlooiHdFXtGJqmjYUN9Bsx/WY3da375bt+dYj2NGKeUbtJLQn+iW 7UcWN5lEnrzekCufmrFFqWaGjXYkGtKe/8n342NA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5CA6061845 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=periyasa@codeaurora.org From: Karthikeyan Periyasamy To: ath11k@lists.infradead.org Subject: [PATCH] ath11k: fix memory leak in testmode Date: Tue, 16 Jul 2019 19:34:32 +0530 Message-Id: <1563285872-13408-1-git-send-email-periyasa@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190716_070455_274307_D3D2F5B9 X-CRM114-Status: UNSURE ( 8.40 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Karthikeyan Periyasamy MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP when ath11k_wmi_cmd_send() fails, caller need to free up the skb. In ath11k_tm_cmd_wmi(), skb free not happen when wmi command send fails. so free up the skb in the error case. Signed-off-by: Karthikeyan Periyasamy --- drivers/net/wireless/ath/ath11k/testmode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath11k/testmode.c b/drivers/net/wireless/ath/ath11k/testmode.c index 96ed2d2..9274b6c 100644 --- a/drivers/net/wireless/ath/ath11k/testmode.c +++ b/drivers/net/wireless/ath/ath11k/testmode.c @@ -160,6 +160,7 @@ static int ath11k_tm_cmd_wmi(struct ath11k *ar, struct nlattr *tb[]) ret = ath11k_wmi_cmd_send(wmi, skb, cmd_id); if (ret) { + dev_kfree_skb(skb); ath11k_warn(ar->ab, "failed to transmit wmi command (testmode): %d\n", ret); goto out;