From patchwork Wed Sep 25 04:44:17 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vasanthakumar Thiagarajan X-Patchwork-Id: 11160009 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4DA7714ED for ; Wed, 25 Sep 2019 04:47:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2AE9F21A4A for ; Wed, 25 Sep 2019 04:47:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Uet1327H"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="MuuMN9Gy"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="MuuMN9Gy" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2AE9F21A4A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0WCvigLFv7J7raHF7U3U9OOEciTIrCrChyUXSv8PsCs=; b=Uet1327H50cq33 VqIMuEsOKyXW0QYbWIbBeGenBrmp3meQmQE1PEXYqatQcJ0+dTTAVhxdVv33j2DQ4qrsc76IKuTtp Mz/y/uyWxby98okpN/jxtiyzkHSIkWSrupOWHzGpxRWyezVNPY9OD5XElACXOUKolv3f1ZtoJxsqd SJkTCI9vopTe8WLal6WlRNdOWmNXTXg7THciZkDFzie13HwSTFI2p4Ru93HR3BdFBGSMbfSFeRaE7 j0vQhnFqvIWPESanASvwvyqiMCLx2/oWMzquw+yJR2paJTsdXev5xPZriUovcwfgh93yPBBL3UQz3 OvlUGWvh4oTJzKv7Yx2g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCzDI-0003Nh-L5; Wed, 25 Sep 2019 04:47:40 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iCzDG-0003Mg-7j for ath11k@lists.infradead.org; Wed, 25 Sep 2019 04:47:39 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id EA76B61572; Wed, 25 Sep 2019 04:47:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569386857; bh=5t+9gHs8FR7nVXyuNYnhLrO+8jkGuzXGkGSyy9mbSDU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=MuuMN9Gyofy9+O1h8AVhF07uUebioFIvvLvb3pxMVJlDjLjj1CBcC1rGCM61yqZnT Lb3FRG18Vq/yOvbQSwFpEKWph0gTXtVcdWEphY2r7uKsnj0FYFGiq9VsqcO6YJyitJ xpR+9pC9a1xbpy3GClJhQj2yxT2/KnAtIHJzHPrA= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from vasanth-lnx.qca.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vthiagar@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id A35516115A for ; Wed, 25 Sep 2019 04:47:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1569386857; bh=5t+9gHs8FR7nVXyuNYnhLrO+8jkGuzXGkGSyy9mbSDU=; h=From:To:Subject:Date:In-Reply-To:References:From; b=MuuMN9Gyofy9+O1h8AVhF07uUebioFIvvLvb3pxMVJlDjLjj1CBcC1rGCM61yqZnT Lb3FRG18Vq/yOvbQSwFpEKWph0gTXtVcdWEphY2r7uKsnj0FYFGiq9VsqcO6YJyitJ xpR+9pC9a1xbpy3GClJhQj2yxT2/KnAtIHJzHPrA= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org A35516115A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vthiagar@codeaurora.org From: Vasanthakumar Thiagarajan To: ath11k@lists.infradead.org Subject: [PATCH bringup 2/3] ath11k: Clean up parameter list in ath11k_ce_completed_send_next() Date: Wed, 25 Sep 2019 10:14:17 +0530 Message-Id: <1569386658-1325-2-git-send-email-vthiagar@codeaurora.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1569386658-1325-1-git-send-email-vthiagar@codeaurora.org> References: <1569386658-1325-1-git-send-email-vthiagar@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190924_214738_315863_F4DE50BA X-CRM114-Status: GOOD ( 11.47 ) X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [198.145.29.96 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org Make ath11k_ce_completed_send_next() to return skb instead of through a double pointer argument of type sk_buff. Signed-off-by: Vasanthakumar Thiagarajan --- drivers/net/wireless/ath/ath11k/ce.c | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/ce.c b/drivers/net/wireless/ath/ath11k/ce.c index 205f28e..03e7cf0 100644 --- a/drivers/net/wireless/ath/ath11k/ce.c +++ b/drivers/net/wireless/ath/ath11k/ce.c @@ -296,15 +296,14 @@ static void ath11k_ce_recv_process_cb(struct ath11k_ce_pipe *pipe) } } -static int ath11k_ce_completed_send_next(struct ath11k_ce_pipe *pipe, - struct sk_buff **skb) +static struct sk_buff *ath11k_ce_completed_send_next(struct ath11k_ce_pipe *pipe) { struct ath11k_base *ab = pipe->ab; struct hal_srng *srng; unsigned int sw_index; unsigned int nentries_mask; + struct sk_buff *skb; u32 *desc; - int ret = 0; spin_lock_bh(&ab->ce.ce_lock); @@ -319,11 +318,11 @@ static int ath11k_ce_completed_send_next(struct ath11k_ce_pipe *pipe, desc = ath11k_hal_srng_src_reap_next(ab, srng); if (!desc) { - ret = -EIO; + skb = ERR_PTR(-EIO); goto err_unlock; } - *skb = pipe->src_ring->skb[sw_index]; + skb = pipe->src_ring->skb[sw_index]; pipe->src_ring->skb[sw_index] = NULL; @@ -335,7 +334,7 @@ static int ath11k_ce_completed_send_next(struct ath11k_ce_pipe *pipe, spin_unlock_bh(&ab->ce.ce_lock); - return ret; + return skb; } static void ath11k_ce_send_done_cb(struct ath11k_ce_pipe *pipe) @@ -343,7 +342,7 @@ static void ath11k_ce_send_done_cb(struct ath11k_ce_pipe *pipe) struct ath11k_base *ab = pipe->ab; struct sk_buff *skb; - while (ath11k_ce_completed_send_next(pipe, &skb) == 0) { + while (!IS_ERR(skb = ath11k_ce_completed_send_next(pipe))) { if (!skb) continue;