diff mbox series

ath11k: avoid burst time conversion logic

Message ID 1572420925-11452-1-git-send-email-periyasa@codeaurora.org (mailing list archive)
State Accepted
Commit ecbd15739034290b667ccb838ad90fd6331d14d8
Delegated to: Kalle Valo
Headers show
Series ath11k: avoid burst time conversion logic | expand

Commit Message

Karthikeyan periyasamy Oct. 30, 2019, 7:35 a.m. UTC
WMI_VDEV_SET_WMM_PARAMS commmand expects the txoplimit param in the units of
32 microseconds. convert the txop unit from 32 microseconds to absolute
microseconds leads to the higher burst values which is incorrect. so no need
to convert the txop unit from 32 microseconds to absolute microseconds.

Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/mac.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Kalle Valo Nov. 7, 2019, 9:06 a.m. UTC | #1
Karthikeyan Periyasamy <periyasa@codeaurora.org> wrote:

> WMI_VDEV_SET_WMM_PARAMS commmand expects the txoplimit param in the units of
> 32 microseconds. convert the txop unit from 32 microseconds to absolute
> microseconds leads to the higher burst values which is incorrect. so no need
> to convert the txop unit from 32 microseconds to absolute microseconds.
> 
> Signed-off-by: Karthikeyan Periyasamy <periyasa@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath11k-post-bringup branch of ath.git, thanks.

ecbd15739034 ath11k: avoid burst time conversion logic
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c
index 6f82fdb..412c258 100644
--- a/drivers/net/wireless/ath/ath11k/mac.c
+++ b/drivers/net/wireless/ath/ath11k/mac.c
@@ -3023,12 +3023,7 @@  static int ath11k_mac_op_conf_tx(struct ieee80211_hw *hw,
 	p->cwmin = params->cw_min;
 	p->cwmax = params->cw_max;
 	p->aifs = params->aifs;
-
-	/* The channel time duration programmed in the HW is in absolute
-	 * microseconds, while mac80211 gives the txop in units of
-	 * 32 microseconds.
-	 */
-	p->txop = params->txop * 32;
+	p->txop = params->txop;
 
 	ret = ath11k_wmi_send_wmm_update_cmd_tlv(ar, arvif->vdev_id,
 						 &arvif->wmm_params);