From patchwork Tue Mar 17 11:59:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pravas Kumar Panda X-Patchwork-Id: 11442615 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1102B14DD for ; Tue, 17 Mar 2020 12:00:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2A3320663 for ; Tue, 17 Mar 2020 12:00:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="IKirgAwi"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="hWpDAahS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2A3320663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=nmXPuDIoTy9sSkeuqOl+hrMJDhw5nb0pjnTQHG2BRdM=; b=IKi rgAwiIa1Qwt+YvJe53bCcQuF+QmaKKU6BQMzrpGyd9sRKbXbQUMdK7SGSyV/MdhbX8JW2RgxERxGm TKxvc3lGXc9ONdLPQuWItVRVccynDfdZ8YXw4gNikpjd3hBmcgyh12Dxi6UzPGzOPmk4s3RAamcHF nMrFIPBUCHKHTnPFuSIhWUUKrTLN7QxCi0O5rmA91ATP6U4eQxOFN5sS2R6hhvEVZalaNJxOSU2t1 U8JTFNJbhsCrlcoUROlDTE0nhqf8KrnhuyG5WPkBqyyb0ID20W8ed7JljBiARVp0U1JGCRvDzNZk5 03foKGydcEmx48byyVypnW4PrZm923Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEAtp-0006Kw-UL; Tue, 17 Mar 2020 12:00:45 +0000 Received: from mail26.static.mailgun.info ([104.130.122.26]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEAtj-0006KK-9C for ath11k@lists.infradead.org; Tue, 17 Mar 2020 12:00:44 +0000 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1584446443; h=Message-Id: Date: Subject: Cc: To: From: Sender; bh=0V4JeM7uMHP3PDzj6H7teVS8H+e3C0yYmlguWTAzDd4=; b=hWpDAahSr6FrBjhviwTrkvvbyZJGEHqQdvpysZaIvokQXrbNteIhE1dpzQ9XxpXeIX2zrI4Q 6jIBh2JoIFGLUBtvZNKzfpdG9oiJVO+i30gucoy/Vu4fg3WXH5y03O4WdUUi3Og2VQ4OTUEV MLQCPDaAswZzJHisDpoM3Mf0zRI= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyJmOGQ2ZiIsICJhdGgxMWtAbGlzdHMuaW5mcmFkZWFkLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e70bbce.7fde70d38260-smtp-out-n02; Tue, 17 Mar 2020 12:00:14 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 86B83C433BA; Tue, 17 Mar 2020 12:00:14 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=2.0 tests=ALL_TRUSTED,SPF_NONE autolearn=ham autolearn_force=no version=3.4.0 Received: from periyasa-linux.qualcomm.com (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: kumarpan) by smtp.codeaurora.org (Postfix) with ESMTPSA id CCC39C433CB; Tue, 17 Mar 2020 12:00:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CCC39C433CB Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=kumarpan@codeaurora.org From: Pravas Kumar Panda To: ath11k@lists.infradead.org Subject: [PATCH] ath11k: Adding proper validation before accessing tx_stats Date: Tue, 17 Mar 2020 17:29:29 +0530 Message-Id: <1584446369-7021-1-git-send-email-kumarpan@codeaurora.org> X-Mailer: git-send-email 2.7.4 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200317_050043_202111_8A5F2630 X-CRM114-Status: GOOD ( 10.93 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [104.130.122.26 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Pravas Kumar Panda , linux-wireless@vger.kernel.org MIME-Version: 1.0 Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org Before dumping tx_stats proper validation was not been taken care of. Due to which we were encountering null pointer dereference(kernel panic). This scenario will arise when a station is getting disconnected and we are changing the STA state by ath11k_mac_op_sta_state and assigning tx_stats as NULL and after this the mac80211 will destroy the debugfs entry from where we are trying to read the stats. If anyone tries to dump tx_stats for that STA in between setting tx_stats to NULL and debugfs file removal without checking the NULL value it will run into a NULL pointer exception. Proceeding with the analysis of "ARM Kernel Panic". The APSS crash happened due to OOPS on CPU 3. Crash Signature : Unable to handle kernel NULL pointer dereference at virtual address 00000360 During the crash, PC points to "ath11k_debug_htt_stats_init+0x16ac/0x1acc [ath11k]" LR points to "ath11k_debug_htt_stats_init+0x1688/0x1acc [ath11k]". The Backtrace obtained is as follows: [] ath11k_debug_htt_stats_init+0x16ac/0x1acc [ath11k] [] do_loop_readv_writev+0x60/0xa4 [] do_readv_writev+0xd8/0x19c [] vfs_readv+0x34/0x48 [] default_file_splice_read+0x1a8/0x2e4 [] do_splice_to+0x78/0x98 [] splice_direct_to_actor+0xb0/0x1a4 [] do_splice_direct+0x84/0xa8 [] do_sendfile+0x160/0x2a4 [] SyS_sendfile64+0xb4/0xc8 Signed-off-by: Pravas Kumar Panda --- drivers/net/wireless/ath/ath11k/debugfs_sta.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/ath11k/debugfs_sta.c b/drivers/net/wireless/ath/ath11k/debugfs_sta.c index 872f3ef..389dac2 100644 --- a/drivers/net/wireless/ath/ath11k/debugfs_sta.c +++ b/drivers/net/wireless/ath/ath11k/debugfs_sta.c @@ -219,6 +219,9 @@ static ssize_t ath11k_dbg_sta_dump_tx_stats(struct file *file, const int size = 2 * 4096; char *buf; + if (!arsta->tx_stats) + return -ENOENT; + buf = kzalloc(size, GFP_KERNEL); if (!buf) return -ENOMEM;