From patchwork Fri Jun 28 10:11:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Crispin X-Patchwork-Id: 11021909 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id AD51114E5 for ; Fri, 28 Jun 2019 10:11:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D1942878F for ; Fri, 28 Jun 2019 10:11:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9127D28796; Fri, 28 Jun 2019 10:11:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 221962878F for ; Fri, 28 Jun 2019 10:11:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yOq9LCnA9fNu7nzNSqnmQ4eAlOSLfmXn+akFtW10Dhw=; b=M7sQti72cuaj+/ iYFKjvCSyFZCErvoJnGWQLVHgNUFllhsJ9fqPiuppLMrlgKwu43aWBzt0L213Cfxs+hB9FAtCRxph RtU2bggVXWxAnEDgmjIZ+PH3KmxrQgV90lcc3p5GzDR/6kNMqAqC6VwYhaXBFIMvBzhijfpye+TcA uAhavIYTSmWQ8xpjic13o7Ev7DUDfp5WZLvCaJj9WY8D9kgdRBG017tHzzngNO+KcxddI+n7Q0lO7 pV+cKcyAmBULtcjUO3s+MWeIp3ZKVgWvnk0ODCEYXR6r6gmFiubGaC/HdimsxEF4iEiBfHYfWFHHF qiI2ZolaWR0chjC5IQXw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hgnr1-0005g0-KH; Fri, 28 Jun 2019 10:11:39 +0000 Received: from nbd.name ([2a01:4f8:221:3d45::2]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hgnqy-0005Z4-UW for ath11k@lists.infradead.org; Fri, 28 Jun 2019 10:11:38 +0000 Received: from pd95fdaa4.dip0.t-ipconnect.de ([217.95.218.164] helo=bertha.datto.lan) by ds12 with esmtpa (Exim 4.89) (envelope-from ) id 1hgnqv-0007dX-31; Fri, 28 Jun 2019 12:11:33 +0200 From: John Crispin To: Kalle Valo Subject: [RFC 2/2] ath11k: drop memset in tx status hotpath Date: Fri, 28 Jun 2019 12:11:27 +0200 Message-Id: <20190628101127.6044-2-john@phrozen.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190628101127.6044-1-john@phrozen.org> References: <20190628101127.6044-1-john@phrozen.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190628_031137_142608_646A4EE1 X-CRM114-Status: UNSURE ( 9.30 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Crispin , ath11k@lists.infradead.org, Rajkumar Manoharan Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This in a small but measurable performance increase. Signed-off-by: John Crispin --- drivers/net/wireless/ath/ath11k/dp_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c index b3d5995fc657..8c5db3c88a87 100644 --- a/drivers/net/wireless/ath/ath11k/dp_tx.c +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c @@ -448,7 +448,6 @@ void ath11k_dp_tx_completion_handler(struct ath11k_base *ab, int ring_id) int hal_ring_id = dp->tx_ring[ring_id].tcl_comp_ring.ring_id; struct hal_srng *status_ring = &ab->hal.srng_list[hal_ring_id]; struct sk_buff *msdu; - struct hal_tx_status ts; struct dp_tx_ring *tx_ring = &dp->tx_ring[ring_id]; u32 msdu_id; u32 *desc; @@ -459,7 +458,8 @@ void ath11k_dp_tx_completion_handler(struct ath11k_base *ab, int ring_id) ath11k_hal_srng_access_begin(ab, status_ring); while ((desc = ath11k_hal_srng_dst_get_next_entry(ab, status_ring))) { - memset(&ts, 0, sizeof(ts)); + struct hal_tx_status ts = { 0 }; + ath11k_hal_tx_status_parse(ab, (struct hal_wbm_release_ring *)desc, &ts);