From patchwork Wed Sep 4 09:15:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Crispin X-Patchwork-Id: 11129771 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id EA1B61398 for ; Wed, 4 Sep 2019 09:15:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C7CE72339E for ; Wed, 4 Sep 2019 09:15:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qC1u1GXg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C7CE72339E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=phrozen.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=I7P5HUs84uwUcTKYXGqonjwWMGOWow2jz362Eic2uqU=; b=qC1u1GXgHnf+n0 QTUSUA1Qaovjorhb1qx+kAeCOm7jCFdbrMSZ3uI5RV4j+7NrrbAPyKhQmY6LxN/MYoc+hiBAN51fZ muVGq2YFpaFpNuxA7HkJRc/+YKxAJXrqcBl+HDnik2K6F/9gKdR9g6OXnlqc6vBVVhY6b4KLXPduB E5PvSF1CBpNR1YGExw1x1ypofpvgSBxcLTeUBO6mxJEIf/2FjRs2BIGoTzo2TeagdC8+FM292nAYD w9MfjVjq5cLtAO10oM3ZpR+BaDdqF4MhLVaR24KKMgt4gcyuFIFr2+k0VTnFqCeMtZAEBMf8U9r+E uq0XO0wFWyQD1SzSLhzQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1i5RO1-0008SW-Eq; Wed, 04 Sep 2019 09:15:33 +0000 Received: from nbd.name ([2a01:4f8:221:3d45::2]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1i5RNy-0008S9-Ih for ath11k@lists.infradead.org; Wed, 04 Sep 2019 09:15:32 +0000 Received: from p5dcfba66.dip0.t-ipconnect.de ([93.207.186.102] helo=bertha.lan) by ds12 with esmtpa (Exim 4.89) (envelope-from ) id 1i5RNx-0004iU-2D; Wed, 04 Sep 2019 11:15:29 +0200 From: John Crispin To: Kalle Valo Subject: [PATCH] ath11k: Disable SU support in meshpoint mode Date: Wed, 4 Sep 2019 11:15:27 +0200 Message-Id: <20190904091527.27260-1-john@phrozen.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190904_021530_778032_A566E196 X-CRM114-Status: UNSURE ( 8.90 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ath11k@lists.infradead.org, Sven Eckelmann Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org From: Sven Eckelmann The firmware WLAN.HK.2.1.0.1-00629-QCAHKSWPL_SILICONZ-1 often stops sending data on 5GHz when SU support is advertised. A simple throughput benchmark will end up at only a couple hundred kilobytes per second (when finishing at all). Disabling SU related flags works around this problem and allowed a maximum throughput of ~450 MBit/s in a simple test setup with an HK01 over air. Signed-off-by: Sven Eckelmann --- drivers/net/wireless/ath/ath11k/mac.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index 4d40c9635a4a..0869900d7e18 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -3365,19 +3365,20 @@ static int ath11k_mac_copy_he_cap(struct ath11k *ar, he_cap_elem->phy_cap_info[3] &= ~(IEEE80211_HE_PHY_CAP3_RX_HE_MU_PPDU_FROM_NON_AP_STA | IEEE80211_HE_PHY_CAP3_DCM_MAX_CONST_TX_MASK | - IEEE80211_HE_PHY_CAP3_DCM_MAX_CONST_RX_MASK); - he_cap_elem->phy_cap_info[4] &= - ~IEEE80211_HE_PHY_CAP4_MU_BEAMFORMER; - he_cap_elem->phy_cap_info[5] &= - ~IEEE80211_HE_PHY_CAP5_NG16_MU_FEEDBACK; + IEEE80211_HE_PHY_CAP3_DCM_MAX_CONST_RX_MASK | + IEEE80211_HE_PHY_CAP3_SU_BEAMFORMER); + he_cap_elem->phy_cap_info[4] = 0; + he_cap_elem->phy_cap_info[5] = 0; he_cap_elem->phy_cap_info[6] &= ~(IEEE80211_HE_PHY_CAP6_CODEBOOK_SIZE_75_MU | + IEEE80211_HE_PHY_CAP6_TRIG_SU_BEAMFORMER_FB | IEEE80211_HE_PHY_CAP6_TRIG_MU_BEAMFORMER_FB | IEEE80211_HE_PHY_CAP6_TRIG_CQI_FB | IEEE80211_HE_PHY_CAP6_PARTIAL_BANDWIDTH_DL_MUMIMO); he_cap_elem->phy_cap_info[7] &= ~(IEEE80211_HE_PHY_CAP7_SRP_BASED_SR | IEEE80211_HE_PHY_CAP7_POWER_BOOST_FACTOR_AR | + IEEE80211_HE_PHY_CAP7_HE_SU_MU_PPDU_4XLTF_AND_08_US_GI | IEEE80211_HE_PHY_CAP7_STBC_TX_ABOVE_80MHZ | IEEE80211_HE_PHY_CAP7_STBC_RX_ABOVE_80MHZ); he_cap_elem->phy_cap_info[8] &=