diff mbox series

ath11k: Fixing TLV length issue in peer pktlog WMI command

Message ID 20191029025742.22488-1-vikpatel@codeaurora.org (mailing list archive)
State Accepted
Commit 86a3e1b38dcbb88d5ee64077149e9ed157e6c321
Delegated to: Kalle Valo
Headers show
Series ath11k: Fixing TLV length issue in peer pktlog WMI command | expand

Commit Message

Vikas Patel Oct. 29, 2019, 2:57 a.m. UTC
TLV length was 0 for TLV tag 'WMI_TAG_ARRAY_STRUCT' causing
Q6 to crash when trying to configure pktlog filter via debugfs.

Signed-off-by: Vikas Patel <vikpatel@codeaurora.org>
---
 drivers/net/wireless/ath/ath11k/wmi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kalle Valo Nov. 7, 2019, 9:02 a.m. UTC | #1
Vikas Patel <vikpatel@codeaurora.org> wrote:

> TLV length was 0 for TLV tag 'WMI_TAG_ARRAY_STRUCT' causing
> Q6 to crash when trying to configure pktlog filter via debugfs.
> 
> Signed-off-by: Vikas Patel <vikpatel@codeaurora.org>
> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

Patch applied to ath11k-post-bringup branch of ath.git, thanks.

86a3e1b38dcb ath11k: Fixing TLV length issue in peer pktlog WMI command
diff mbox series

Patch

diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c
index ccebf7ce420a..aae6e76330da 100644
--- a/drivers/net/wireless/ath/ath11k/wmi.c
+++ b/drivers/net/wireless/ath/ath11k/wmi.c
@@ -2329,7 +2329,7 @@  int ath11k_wmi_pdev_peer_pktlog_filter(struct ath11k *ar, u8 *addr, u8 enable)
 
 	tlv = ptr;
 	tlv->header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_ARRAY_STRUCT) |
-		      FIELD_PREP(WMI_TLV_LEN, 0);
+		      FIELD_PREP(WMI_TLV_LEN, sizeof(*info));
 
 	ptr += TLV_HDR_SIZE;
 	info = ptr;