From patchwork Tue Oct 29 02:57:42 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vikas Patel X-Patchwork-Id: 11216897 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D99491390 for ; Tue, 29 Oct 2019 02:57:57 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4C1A20663 for ; Tue, 29 Oct 2019 02:57:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="NGHyScm5"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="aODPQh21"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="M0j5/Eog" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4C1A20663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=gbtzYvXw+AkyFc3BAkv1Rfbb89R9wa3ZbtMvbP0cCqY=; b=NGHyScm542CF3d Zso6f+qgA7aGzaUtYmXSN6xUCQ75qb3Ckkp/2pX5vPs9avVrTCUQPLfE1prZbWxw1KxBM3oXilubp ZJNDYwWcmFO+e4pAmb4qU08chDB/lh+pP7QcWCwX1Ts4GVgALX3txgsyu2YDM6MB/zBvZJcTuvdBY Z4HHGNP6WIkdzh13g9VN0w4P1rJJLuzPBZ/soxUvtEGF8FdmaY3V2yr4kIe3i2tzDmva3SsKq9DJB mTPrGmTXZ9BAx0uals4TQ8XoUqaZ51qy7vY5EyNJysY9z9KdGl4ychFddBcB1yFbY7Dgqbi0zFSVu IQ/6Id5Zk6zaiRARs32Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPHhj-00088O-JO; Tue, 29 Oct 2019 02:57:55 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPHhg-00087x-3c for ath11k@lists.infradead.org; Tue, 29 Oct 2019 02:57:53 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 5654E60D74; Tue, 29 Oct 2019 02:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572317870; bh=3EtOUrJesGkWCJL+ogpAyqJZ5h57HEhfBhFABD/91ds=; h=From:To:Cc:Subject:Date:From; b=aODPQh21dASfFIks7rzy8TEVWL7NZMB2nzRJoElQaDftXFM438c/naobyEq7LnEiM p3SW/FU2JKdlwka8WwI/TCmr/S5Z+lVGBCwmPNlfgtBASwXOw08Jd0R3t8PptREGDB OqR1UeLxzA9Y3NF5kG6vn4ha/LVaYiT5i17EV3YI= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,SPF_NONE autolearn=no autolearn_force=no version=3.4.0 Received: from akolli-linux.qualcomm.com (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: vikpatel@codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 9FEF060D7C; Tue, 29 Oct 2019 02:57:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1572317869; bh=3EtOUrJesGkWCJL+ogpAyqJZ5h57HEhfBhFABD/91ds=; h=From:To:Cc:Subject:Date:From; b=M0j5/EogKzCy4KN0qvCqZzAyZxhJlZ+CkC5i9pYC9OnSpyNE7OxQug9nUgpu+uuxH bU3pD2wbkYxKNl0kxoRhpu40qM88DGV/i8W/KD4Zz/0mWoc2pPh2MvVRRjOf0Y+Pgt DhR69nyLBBbUeMIJryXhw8KW9S5iQ8fEDinvS6pY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 9FEF060D7C Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=vikpatel@codeaurora.org From: Vikas Patel To: ath11k@lists.infradead.org Subject: [PATCH] ath11k: Fixing TLV length issue in peer pktlog WMI command Date: Tue, 29 Oct 2019 08:27:42 +0530 Message-Id: <20191029025742.22488-1-vikpatel@codeaurora.org> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_195752_169989_0A2982B5 X-CRM114-Status: UNSURE ( 9.31 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.5 (--) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-2.5 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [198.145.29.96 listed in list.dnswl.org] X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Vikas Patel Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org TLV length was 0 for TLV tag 'WMI_TAG_ARRAY_STRUCT' causing Q6 to crash when trying to configure pktlog filter via debugfs. Signed-off-by: Vikas Patel --- drivers/net/wireless/ath/ath11k/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/wmi.c b/drivers/net/wireless/ath/ath11k/wmi.c index ccebf7ce420a..aae6e76330da 100644 --- a/drivers/net/wireless/ath/ath11k/wmi.c +++ b/drivers/net/wireless/ath/ath11k/wmi.c @@ -2329,7 +2329,7 @@ int ath11k_wmi_pdev_peer_pktlog_filter(struct ath11k *ar, u8 *addr, u8 enable) tlv = ptr; tlv->header = FIELD_PREP(WMI_TLV_TAG, WMI_TAG_ARRAY_STRUCT) | - FIELD_PREP(WMI_TLV_LEN, 0); + FIELD_PREP(WMI_TLV_LEN, sizeof(*info)); ptr += TLV_HDR_SIZE; info = ptr;