From patchwork Mon Nov 18 12:12:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Crispin X-Patchwork-Id: 11249691 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CE76E913 for ; Mon, 18 Nov 2019 12:12:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A5028206D4 for ; Mon, 18 Nov 2019 12:12:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Fz+e07JM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A5028206D4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=phrozen.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=bsBZuw0lTsyrUcYJKKbH3npVq5bPGUSdI3imeA/c50E=; b=Fz+e07JMbrxL/n a1vxvRV1CSPLWV73+BOHIGpYKEXht20cnRWusjmwsVlCiL8vbyYgvMNG4T4Q0nSQMJgy0uh87sFJJ EyPap8+r8VjeGTf4RdTIR8ut+6ZqiOo38VlpJzGsE84Zm1Oi9DFEH2FOwE+BPuyhTQTRCMbm7sj3b UoAhhJnzmHi4yyQ/aj6fQ3Vb15mAW2xnk+FEcJ2L6kGJ9TC9PEwFCHenYyPGhxWqKP6GLcYTOY3Gd o+jRFQv+rVZc7/ppl1/g3RWGB8Jf7EqAwplGI+UVMXkiW+77ri4MliuKwbpKVKaz6gnnNQQJKZq3d DMTqYTp2YMHnhwUfdquA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWftU-0002HJ-FR; Mon, 18 Nov 2019 12:12:36 +0000 Received: from nbd.name ([2a01:4f8:221:3d45::2]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWftR-0002GU-Q2 for ath11k@lists.infradead.org; Mon, 18 Nov 2019 12:12:35 +0000 Received: from p5dcfbb96.dip0.t-ipconnect.de ([93.207.187.150] helo=bertha.datto.lan) by ds12 with esmtpa (Exim 4.89) (envelope-from ) id 1iWftP-0001dJ-AX; Mon, 18 Nov 2019 13:12:31 +0100 From: John Crispin To: Kalle Valo Subject: [PATCH 1/3] ath11k: remove superflous memset Date: Mon, 18 Nov 2019 13:12:22 +0100 Message-Id: <20191118121224.26351-1-john@phrozen.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191118_041234_012556_5E68FB30 X-CRM114-Status: UNSURE ( 7.55 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ath11k@lists.infradead.org, John Crispin Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org We set all values inside the struct making the memset pointless. Signed-off-by: John Crispin --- drivers/net/wireless/ath/ath11k/dp_tx.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/dp_tx.c b/drivers/net/wireless/ath/ath11k/dp_tx.c index 670e253476a3..2d6255888cfb 100644 --- a/drivers/net/wireless/ath/ath11k/dp_tx.c +++ b/drivers/net/wireless/ath/ath11k/dp_tx.c @@ -463,7 +463,6 @@ void ath11k_dp_tx_completion_handler(struct ath11k_base *ab, int ring_id) spin_lock_bh(&tx_ring->tx_status_lock); while (kfifo_get(&tx_ring->tx_status_fifo, &tx_status)) { - memset(&ts, 0, sizeof(ts)); ath11k_hal_tx_status_parse(ab, &tx_status, &ts); mac_id = FIELD_GET(DP_TX_DESC_ID_MAC_ID, ts.desc_id);