From patchwork Tue Dec 17 17:18:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Crispin X-Patchwork-Id: 11298289 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BF7D013B6 for ; Tue, 17 Dec 2019 17:18:43 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CDA221582 for ; Tue, 17 Dec 2019 17:18:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Sql3AWX7" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CDA221582 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=phrozen.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=GvRpdolPky+zgZ274MGDtYXxQDs5pR4s/mx4zjp1h9g=; b=Sql3AWX7IF+nu1 8JI/IPc3BxXMjRy1PmRSUEjF731tjjBQaEpt2HgZ7aIelb/72ApW8YyzoUC9dNbHj0UPote0QFyle 5TAJXh7GSAhteZQ+rQBht3Hg+16mCQ59SvQMsiwVfn450ePr7O39bJzsxxWU5ol4CnaTjr2RK49bU WKqt1HIvY31wrdK+ZjDxbNF+8w2UPcAh9tXPpDiX+Tdm5N4u/Dn+iWWKQ6oLQptMccoay18WccKW0 mOGaXykdV9T67FrFeRXNzSj8o4mMYxLCZ2Hqz0iOHe1hr6i3QSwCes/GNo92CUAH7+K+np3zPpMHn qqnrIPxajG+dPna+zvqA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihGUb-0005Qd-MK; Tue, 17 Dec 2019 17:18:41 +0000 Received: from nbd.name ([2a01:4f8:221:3d45::2]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihGUY-0005Pv-Ek for ath11k@lists.infradead.org; Tue, 17 Dec 2019 17:18:39 +0000 Received: from pd95fd66b.dip0.t-ipconnect.de ([217.95.214.107] helo=bertha.fritz.box) by ds12 with esmtpa (Exim 4.89) (envelope-from ) id 1ihGUS-0006xr-Uh; Tue, 17 Dec 2019 18:18:33 +0100 From: John Crispin To: Kalle Valo Subject: [PATCH] ath11k: mask out vht beamforming if a fixed rate is set Date: Tue, 17 Dec 2019 18:18:27 +0100 Message-Id: <20191217171827.6780-1-john@phrozen.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191217_091838_651082_B673294B X-CRM114-Status: UNSURE ( 8.91 ) X-CRM114-Notice: Please train this message. X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ritesh Singh , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, John Crispin Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org From: Ritesh Singh After setting a fixed vht-rate we see a FW assert if a STA tries to (re)assoc with the mu_bfee cap set. This patch masks out the capability bits if a fixed rate is set. Reviewed-by: John Crispin Signed-off-by: Ritesh Singh --- drivers/net/wireless/ath/ath11k/mac.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/wireless/ath/ath11k/mac.c b/drivers/net/wireless/ath/ath11k/mac.c index b8be78dc295d..7f17d0e4cb96 100644 --- a/drivers/net/wireless/ath/ath11k/mac.c +++ b/drivers/net/wireless/ath/ath11k/mac.c @@ -1126,6 +1126,9 @@ static void ath11k_peer_assoc_h_vht(struct ath11k *ar, arg->tx_mcs_set &= ~IEEE80211_VHT_MCS_SUPPORT_0_11_MASK; arg->tx_mcs_set |= IEEE80211_DISABLE_VHT_MCS_SUPPORT_0_11; + if ((arg->tx_mcs_set & 0x3) == 0x3) + arg->peer_vht_caps &= ~IEEE80211_VHT_CAP_MU_BEAMFORMEE_CAPABLE; + /* TODO: Check */ arg->tx_max_mcs_nss = 0xFF;