From patchwork Tue Dec 17 17:22:00 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: John Crispin X-Patchwork-Id: 11298297 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 30DC66C1 for ; Tue, 17 Dec 2019 17:22:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E37121D7D for ; Tue, 17 Dec 2019 17:22:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CoKfGJcr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E37121D7D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=phrozen.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=IRjicFqqQYLeVwAhLncFk6SlkeppCcYQ6hg4nyWrieQ=; b=CoKfGJcrPIbRhJ IJhg9MYrjOKg3Z4eN5z+SgP3WOLo2+9zThfqkqQPJGe5Z9UN9iMvwUVxhRGMpcfzXU//Z7l12UlGn qXwBCuREkEzZq4Ee1cQsdluYWDYvj0DihTZAhqKPB3iK8nOogsTW4bcK8ng5a/Aewnik90AINb8Sh 8T5IzF1xchNjxNif63GzN6YRpck7IQipMqwr2Dkme/BXQE8tPjFPhZYEymxv5UT5WuFm98hSjMazQ d4qjSChLeRJ8RsU4Pgndst3qQ5CkOdN4iKzwkXb1VbiByAukKHj7DJODxTQpfJv2koHpk2bWLcfjZ pWmzWIGCZmGCvpVSFY6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihGXv-0006xh-F3; Tue, 17 Dec 2019 17:22:07 +0000 Received: from nbd.name ([2a01:4f8:221:3d45::2]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihGXs-0006x7-JS for ath11k@lists.infradead.org; Tue, 17 Dec 2019 17:22:06 +0000 Received: from pd95fd66b.dip0.t-ipconnect.de ([217.95.214.107] helo=bertha.fritz.box) by ds12 with esmtpa (Exim 4.89) (envelope-from ) id 1ihGXq-0007DR-Ln; Tue, 17 Dec 2019 18:22:02 +0100 From: John Crispin To: Kalle Valo Subject: [PATCH] ath11k: htt stats module does not handle multiple skbs Date: Tue, 17 Dec 2019 18:22:00 +0100 Message-Id: <20191217172200.7470-1-john@phrozen.org> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191217_092204_798798_08D9A936 X-CRM114-Status: GOOD ( 10.45 ) X-Spam-Score: 0.0 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Miles Hu , linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, John Crispin Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org From: Miles Hu This patch removes the "done" check from the stats handler thus allowing the code to parse more skbs. Reviewed-by: John Crispin Signed-off-by: Miles Hu --- drivers/net/wireless/ath/ath11k/debug_htt_stats.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c b/drivers/net/wireless/ath/ath11k/debug_htt_stats.c index 27b301bc1a1b..45dbffaca3bd 100644 --- a/drivers/net/wireless/ath/ath11k/debug_htt_stats.c +++ b/drivers/net/wireless/ath/ath11k/debug_htt_stats.c @@ -4119,6 +4119,7 @@ void ath11k_dbg_htt_ext_stats_handler(struct ath11k_base *ab, { struct ath11k_htt_extd_stats_msg *msg; struct debug_htt_stats_req *stats_req; + bool send_completion = false; struct ath11k *ar; u32 len; u64 cookie; @@ -4147,10 +4148,8 @@ void ath11k_dbg_htt_ext_stats_handler(struct ath11k_base *ab, return; spin_lock_bh(&ar->debug.htt_stats.lock); - if (stats_req->done) { - spin_unlock_bh(&ar->debug.htt_stats.lock); - return; - } + if (!stats_req->done) + send_completion = true; stats_req->done = true; spin_unlock_bh(&ar->debug.htt_stats.lock); @@ -4161,7 +4160,8 @@ void ath11k_dbg_htt_ext_stats_handler(struct ath11k_base *ab, if (ret) ath11k_warn(ab, "Failed to parse tlv %d\n", ret); - complete(&stats_req->cmpln); + if (send_completion) + complete(&stats_req->cmpln); } static ssize_t ath11k_read_htt_stats_type(struct file *file,