From patchwork Mon Apr 27 10:44:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 11511847 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 91776913 for ; Mon, 27 Apr 2020 10:42:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6FCBA20575 for ; Mon, 27 Apr 2020 10:42:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="HFhd7xgi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6FCBA20575 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=0vljngVxSyn+smBdL5sYRIzI0ylO/J6HYOxgLJJj7rg=; b=HFhd7xgiExVGYQ Vm+KkFWVZusN2KgSxDgFPcFa+zQl3Jtw+xhlFobhCRzDUpgb+FMOSuAuHHdaH3T58oXpSPcJogGWP /RLONyWKA/jQHM6jHogPr3ZFdaeBiBugMgW3QjiFERNQFEwp9D1FiUZPPf98nyPs8WaoVchJKHU88 f5wZJho7xOyebnwlUGDpMdep7wbb44WYIfVQ8aOO2AjKyxyw7mbGSC9JQHpcF8FVAnT0Xxwz9EErc Ib7OLSLkzmD+/wPHhkMm3hBXLyhnmyDYamaN+er+Xk2G62dSDrs6DKvYfjALE1JPYspElcTw71UII 3VsYf4kCa9r+2MXfeWRA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT1E0-0003Hq-RX; Mon, 27 Apr 2020 10:42:56 +0000 Received: from szxga07-in.huawei.com ([45.249.212.35] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jT1Dy-0003G7-IB for ath11k@lists.infradead.org; Mon, 27 Apr 2020 10:42:55 +0000 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 2FBBC812F8071EDB3218; Mon, 27 Apr 2020 18:42:50 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Mon, 27 Apr 2020 18:42:43 +0800 From: Wei Yongjun To: Kalle Valo Subject: [PATCH net-next] ath11k: remove redundant dev_err call in ath11k_ahb_probe() Date: Mon, 27 Apr 2020 10:44:03 +0000 Message-ID: <20200427104403.14598-1-weiyongjun1@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200427_034254_783199_113FFD8D X-CRM114-Status: UNSURE ( 8.00 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [45.249.212.35 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record X-BeenThere: ath11k@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org, Wei Yongjun , ath11k@lists.infradead.org Sender: "ath11k" Errors-To: ath11k-bounces+patchwork-ath11k=patchwork.kernel.org@lists.infradead.org There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/net/wireless/ath/ath11k/ahb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c index e7e3e64c07aa..7d3d1cc6f39f 100644 --- a/drivers/net/wireless/ath/ath11k/ahb.c +++ b/drivers/net/wireless/ath/ath11k/ahb.c @@ -897,10 +897,8 @@ static int ath11k_ahb_probe(struct platform_device *pdev) } mem = devm_ioremap_resource(&pdev->dev, mem_res); - if (IS_ERR(mem)) { - dev_err(&pdev->dev, "ioremap error\n"); + if (IS_ERR(mem)) return PTR_ERR(mem); - } ret = dma_set_mask_and_coherent(&pdev->dev, DMA_BIT_MASK(32)); if (ret) {