| Message ID | 20180923174535.16198-7-hauke@hauke-m.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | backports: misc fixes to improve support of 4.19 | expand |
On Sun, 2018-09-23 at 19:45 +0200, Hauke Mehrtens wrote: > The hostap and atmel wireless driver now make use of the > proc_create_single_data() function which can not easily be backported. > As these drivers are not used too often just deactivate them on older > kernel versions for now. It should be pretty easy to backport based on proc_create_data(), which has been around since 2.6.26? johannes -- To unsubscribe from this list: send the line "unsubscribe backports" in
On 09/23/2018 10:17 PM, Johannes Berg wrote: > On Sun, 2018-09-23 at 19:45 +0200, Hauke Mehrtens wrote: >> The hostap and atmel wireless driver now make use of the >> proc_create_single_data() function which can not easily be backported. >> As these drivers are not used too often just deactivate them on older >> kernel versions for now. > > It should be pretty easy to backport based on proc_create_data(), which > has been around since 2.6.26? > > johannes One of the upstream commits is this: https://git.kernel.org/linus/d51269592c327fcfe8ec80fd169a84f8dc0de73b The problem is that these function also get some data so we would have to provide the data and the show function pointer and store it somewhere. Most of the proc structures are also private so we can not easily abuse some unused member. The affected drivers are anyway not used much any more. Hauke
On Sun, 2018-09-23 at 22:23 +0200, Hauke Mehrtens wrote: > On 09/23/2018 10:17 PM, Johannes Berg wrote: > > On Sun, 2018-09-23 at 19:45 +0200, Hauke Mehrtens wrote: > > > The hostap and atmel wireless driver now make use of the > > > proc_create_single_data() function which can not easily be backported. > > > As these drivers are not used too often just deactivate them on older > > > kernel versions for now. > > > > It should be pretty easy to backport based on proc_create_data(), which > > has been around since 2.6.26? > > > > johannes > > One of the upstream commits is this: > https://git.kernel.org/linus/d51269592c327fcfe8ec80fd169a84f8dc0de73b Sure. > The problem is that these function also get some data so we would have > to provide the data and the show function pointer and store it > somewhere. Most of the proc structures are also private so we can not > easily abuse some unused member. But proc_create_data() does pass the data to store, and PDE_DATA() to get it back has been there also forever? Ah, but yes, you'd also have to store the show pointer, and thus probably allocate memory for the data, and then you even have to leak it because you can't hook into the freeing thereof. > The affected drivers are anyway not used much any more. True. I suppose if somebody really needed the drivers they'd be better off reverting the patch linked above. johannes -- To unsubscribe from this list: send the line "unsubscribe backports" in
diff --git a/dependencies b/dependencies index 42ed0e2f..cd644df7 100644 --- a/dependencies +++ b/dependencies @@ -13,8 +13,9 @@ WLCORE 3.2 WL12XX 3.2 WL18XX 3.2 -# hostapd uses proc_remove() -HOSTAP 3.10 +# hostapd uses proc_create_single_data() +HOSTAP 4.18 +ATMEL 4.18 # This driver uses the remove_proc_subtree() function. AIRO 3.9
The hostap and atmel wireless driver now make use of the proc_create_single_data() function which can not easily be backported. As these drivers are not used too often just deactivate them on older kernel versions for now. Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de> --- dependencies | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)