mbox series

[v3,00/12] Bluetooth: correct the use of print format

Message ID 1622706065-45409-1-git-send-email-yekai13@huawei.com (mailing list archive)
Headers show
Series Bluetooth: correct the use of print format | expand

Message

yekai (A) June 3, 2021, 7:40 a.m. UTC
According to Documentation/core-api/printk-formats.rst,
Use the correct print format. 
1. Printing an unsigned int value should use %u instead of %d.
2. Printing an unsigned long value should use %lu instead of %ld.
Otherwise printk() might end up displaying negative numbers.

changes v1 -> v2:
	fix some style problems
changes v2 -> v3
	fix some commit message style

Kai Ye (12):
  Bluetooth: bnep: Use the correct print format
  Bluetooth: cmtp: Use the correct print format
  Bluetooth: hidp: Use the correct print format
  Bluetooth: rfcomm: Use the correct print format
  Bluetooth: 6lowpan: Use the correct print format
  Bluetooth: a2mp: Use the correct print format
  Bluetooth: amp: Use the correct print format
  Bluetooth: hci: Use the correct print format
  Bluetooth: mgmt: Use the correct print format
  Bluetooth: msft: Use the correct print format
  Bluetooth: sco: Use the correct print format
  Bluetooth: smp: Use the correct print format

 net/bluetooth/6lowpan.c     | 16 +++++------
 net/bluetooth/a2mp.c        | 24 ++++++++--------
 net/bluetooth/amp.c         |  6 ++--
 net/bluetooth/bnep/core.c   |  8 +++---
 net/bluetooth/cmtp/capi.c   | 22 +++++++--------
 net/bluetooth/hci_conn.c    |  8 +++---
 net/bluetooth/hci_core.c    | 48 ++++++++++++++++----------------
 net/bluetooth/hci_event.c   | 24 ++++++++--------
 net/bluetooth/hci_request.c |  8 +++---
 net/bluetooth/hci_sock.c    |  6 ++--
 net/bluetooth/hci_sysfs.c   |  2 +-
 net/bluetooth/hidp/core.c   |  6 ++--
 net/bluetooth/mgmt.c        | 16 +++++------
 net/bluetooth/mgmt_config.c |  4 +--
 net/bluetooth/msft.c        |  2 +-
 net/bluetooth/rfcomm/core.c | 68 ++++++++++++++++++++++-----------------------
 net/bluetooth/rfcomm/sock.c |  8 +++---
 net/bluetooth/rfcomm/tty.c  | 10 +++----
 net/bluetooth/sco.c         |  8 +++---
 net/bluetooth/smp.c         |  6 ++--
 20 files changed, 150 insertions(+), 150 deletions(-)

Comments

Marcel Holtmann June 3, 2021, 2:21 p.m. UTC | #1
Hi Kai,

> According to Documentation/core-api/printk-formats.rst,
> Use the correct print format. 
> 1. Printing an unsigned int value should use %u instead of %d.
> 2. Printing an unsigned long value should use %lu instead of %ld.
> Otherwise printk() might end up displaying negative numbers.
> 
> changes v1 -> v2:
> 	fix some style problems
> changes v2 -> v3
> 	fix some commit message style
> 
> Kai Ye (12):
>  Bluetooth: bnep: Use the correct print format
>  Bluetooth: cmtp: Use the correct print format
>  Bluetooth: hidp: Use the correct print format
>  Bluetooth: rfcomm: Use the correct print format
>  Bluetooth: 6lowpan: Use the correct print format
>  Bluetooth: a2mp: Use the correct print format
>  Bluetooth: amp: Use the correct print format
>  Bluetooth: hci: Use the correct print format
>  Bluetooth: mgmt: Use the correct print format
>  Bluetooth: msft: Use the correct print format
>  Bluetooth: sco: Use the correct print format
>  Bluetooth: smp: Use the correct print format
> 
> net/bluetooth/6lowpan.c     | 16 +++++------
> net/bluetooth/a2mp.c        | 24 ++++++++--------
> net/bluetooth/amp.c         |  6 ++--
> net/bluetooth/bnep/core.c   |  8 +++---
> net/bluetooth/cmtp/capi.c   | 22 +++++++--------
> net/bluetooth/hci_conn.c    |  8 +++---
> net/bluetooth/hci_core.c    | 48 ++++++++++++++++----------------
> net/bluetooth/hci_event.c   | 24 ++++++++--------
> net/bluetooth/hci_request.c |  8 +++---
> net/bluetooth/hci_sock.c    |  6 ++--
> net/bluetooth/hci_sysfs.c   |  2 +-
> net/bluetooth/hidp/core.c   |  6 ++--
> net/bluetooth/mgmt.c        | 16 +++++------
> net/bluetooth/mgmt_config.c |  4 +--
> net/bluetooth/msft.c        |  2 +-
> net/bluetooth/rfcomm/core.c | 68 ++++++++++++++++++++++-----------------------
> net/bluetooth/rfcomm/sock.c |  8 +++---
> net/bluetooth/rfcomm/tty.c  | 10 +++----
> net/bluetooth/sco.c         |  8 +++---
> net/bluetooth/smp.c         |  6 ++--
> 20 files changed, 150 insertions(+), 150 deletions(-)

I applied all patches except 04/12 and 08/12 since they no longer apply cleanly against bluetooth-next tree.

Regards

Marcel