From patchwork Fri Mar 20 00:07:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Abhishek Pandit-Subedi X-Patchwork-Id: 11448211 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D849A6CA for ; Fri, 20 Mar 2020 00:07:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B288C206D7 for ; Fri, 20 Mar 2020 00:07:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LY7Fc+nl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727256AbgCTAHa (ORCPT ); Thu, 19 Mar 2020 20:07:30 -0400 Received: from mail-pf1-f172.google.com ([209.85.210.172]:33144 "EHLO mail-pf1-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727202AbgCTAHa (ORCPT ); Thu, 19 Mar 2020 20:07:30 -0400 Received: by mail-pf1-f172.google.com with SMTP id n7so2321521pfn.0 for ; Thu, 19 Mar 2020 17:07:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kLb0ZW3Gt56un5tXJnGrDhWNvjh5tVVZUmrjKBTkr+I=; b=LY7Fc+nlEVtHs0x3b9ctNL+6CrOSlcR+dUMnjqvjQwijmEnKO6WMGSwm7kxpjqqoOP rQrvu1SMuG56ettv/vRNoQUuSnEvkfcvf9DdCO+i+sU1NuOcoAkGsBA2HbbgokioRHFt OUg11p+DIaNLmdcadaLQASLwXes5a1rc+XT9Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=kLb0ZW3Gt56un5tXJnGrDhWNvjh5tVVZUmrjKBTkr+I=; b=fYSTKu/mEf33UuWGM+gpxDg4LBXMqt+GPI0UAwkoiZeue774q3gizpYWBzDS4ZGFGf c12fcOgKKBoU8JOb1qu8eU/vO+a+T9uzg/nn5Ed+o7cWtgIr09zknjOhrvDZTolxG4Ne 8tmNu9lg8FO9OqxDUIima8hotN9jBtSFPBL9t5BVvZ6Nt/Fqo8ZTZo4Sj1H8JKaQ0sTT mIXpMvmaVXyitZNSdH/gfNeZ8cTbJGV/3tXnDAp0b+ZmjhnDj1mZ+ezi5TDag363FHKN WWhNVd9i4+WHR+8FhPHzHIs1IeMoJCdDkAOqHjL9oKeqbHxZ8MGXuU+BEWJmQuATpG4l z4Aw== X-Gm-Message-State: ANhLgQ2ay8aViqI7sFyi8rVUV4NqonD/3chpcsMa8JtJZSpouvscxmvN xpNqOmHXlfcNsRrXYvdFHkxJ7g== X-Google-Smtp-Source: ADFU+vu+R8yEHZtvdwQOflPfI/ieY4C1RoRUB74THQ9itVUwbo0VQhUooKemv0uAcyg5F8tYTYvIFQ== X-Received: by 2002:a63:c507:: with SMTP id f7mr5766872pgd.278.1584662849286; Thu, 19 Mar 2020 17:07:29 -0700 (PDT) Received: from apsdesk.mtv.corp.google.com ([2620:15c:202:1:e09a:8d06:a338:aafb]) by smtp.gmail.com with ESMTPSA id m12sm2928292pjf.25.2020.03.19.17.07.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Mar 2020 17:07:28 -0700 (PDT) From: Abhishek Pandit-Subedi To: marcel@holtmann.org, linux-bluetooth@vger.kernel.org Cc: chromeos-bluetooth-upstreaming@chromium.org, Abhishek Pandit-Subedi , "David S. Miller" , Johan Hedberg , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Jakub Kicinski Subject: [PATCH 0/2] Bluetooth: Suspend related bugfixes Date: Thu, 19 Mar 2020 17:07:11 -0700 Message-Id: <20200320000713.32899-1-abhishekpandit@chromium.org> X-Mailer: git-send-email 2.25.1.696.g5e7596f4ac-goog MIME-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org Hi Marcel, After further automated testing of the upstreamed suspend patches, I found two issues: - A failure in PM_SUSPEND_PREPARE wasn't calling PM_POST_SUSPEND. I misread the docs and thought it would call it for all notifiers already run but it only does so for the ones that returned successfully from PM_SUSPEND_PREPARE. - hci_conn_complete_evt wasn't completing on auto-connects (an else block was removed during a refactor incorrectly) With the following patches, I've run a suspend stress test on a couple of Chromebooks for several dozen iterations (each) successfully. Thanks Abhishek Abhishek Pandit-Subedi (2): Bluetooth: Restore running state if suspend fails Bluetooth: Fix incorrect branch in connection complete net/bluetooth/hci_core.c | 39 ++++++++++++++++++++------------------- net/bluetooth/hci_event.c | 17 +++++++++-------- 2 files changed, 29 insertions(+), 27 deletions(-)