[BlueZ,0/4] API changes for forward compatibility

Message

Stotland, Inga March 27, 2020, 6:42 p.m. UTC

The changes are contained to Management and Provisioner APIs. 

  The following methods are modified to allow for future development:
    
    Interface org.bluez.mesh.Management1:
    
    Old: void UnprovisionedScan(uint16 seconds)
    New: void UnprovisionedScan(dict options)
    
        The options parameter is a dictionary with the following keys defined:
        uint16 Seconds
                    Specifies number of seconds for scanning to be active.
                    If set to 0 or if this key is not present, then the
                    scanning will continue until UnprovisionedScanCancel()
                    or AddNode() methods are called.
        other keys TBD
    
    Old: void AddNode(array{byte}[16] uuid)
    New: void AddNode(array{byte}[16] uuid, dict options)
    
        The options parameter is currently an empty dictionary
    
    Interface org.bluez.mesh.Provisioner1
    
    Old: void ScanResult(int16 rssi, array{byte} data)
    New: void ScanResult(int16 rssi, array{byte} data, dict options)
    
        The options parameter is currently an empty dictionary

Inga Stotland (4):
  doc/mesh-api: Forward compatibility modifications
  mesh: Update UnprovisionedScan, AddNode & ScanResult
  test/test-mesh: Update to match modified APIs
  tools/mesh-cfgclient: Update to match modified APIs

 doc/mesh-api.txt       | 28 +++++++++++++++++++++-------
 mesh/manager.c         | 39 ++++++++++++++++++++++++++++++---------
 test/test-mesh         | 39 +++++++++++++++++++++++++--------------
 tools/mesh-cfgclient.c | 36 ++++++++++++++++++++++++++++++------
 4 files changed, 106 insertions(+), 36 deletions(-)

Comments

Brian Gix March 30, 2020, 10:07 p.m. UTC | #1

Patchset Applied
On Fri, 2020-03-27 at 11:42 -0700, Inga Stotland wrote:
> The changes are contained to Management and Provisioner APIs. 
> 
>   The following methods are modified to allow for future development:
>     
>     Interface org.bluez.mesh.Management1:
>     
>     Old: void UnprovisionedScan(uint16 seconds)
>     New: void UnprovisionedScan(dict options)
>     
>         The options parameter is a dictionary with the following keys defined:
>         uint16 Seconds
>                     Specifies number of seconds for scanning to be active.
>                     If set to 0 or if this key is not present, then the
>                     scanning will continue until UnprovisionedScanCancel()
>                     or AddNode() methods are called.
>         other keys TBD
>     
>     Old: void AddNode(array{byte}[16] uuid)
>     New: void AddNode(array{byte}[16] uuid, dict options)
>     
>         The options parameter is currently an empty dictionary
>     
>     Interface org.bluez.mesh.Provisioner1
>     
>     Old: void ScanResult(int16 rssi, array{byte} data)
>     New: void ScanResult(int16 rssi, array{byte} data, dict options)
>     
>         The options parameter is currently an empty dictionary
> 
> Inga Stotland (4):
>   doc/mesh-api: Forward compatibility modifications
>   mesh: Update UnprovisionedScan, AddNode & ScanResult
>   test/test-mesh: Update to match modified APIs
>   tools/mesh-cfgclient: Update to match modified APIs
> 
>  doc/mesh-api.txt       | 28 +++++++++++++++++++++-------
>  mesh/manager.c         | 39 ++++++++++++++++++++++++++++++---------
>  test/test-mesh         | 39 +++++++++++++++++++++++++--------------
>  tools/mesh-cfgclient.c | 36 ++++++++++++++++++++++++++++++------
>  4 files changed, 106 insertions(+), 36 deletions(-)
>