mbox series

[v2,0/7] LL Privacy support

Message ID 20200603171713.9882-1-sathish.narasimman@intel.com (mailing list archive)
Headers show
Series LL Privacy support | expand

Message

Sathish Narasimman June 3, 2020, 5:17 p.m. UTC
Based on the input the patches modified and verifed accordingly.

Marcel Holtmann (3):
  Bluetooth: Translate additional address type correctly
  Bluetooth: Configure controller address resolution if available
  Bluetooth: Update resolving list when updating whitelist

Sathish Narasimman (4):
  Bluetooth: Translate additional address type during le_conn
  Bluetooth: Let controller creates RPA during le create conn
  Bluetooth: Enable/Disable address resolution during le create conn
  Bluetooth: Enable RPA Timeout

 include/net/bluetooth/hci.h      |   8 ++-
 include/net/bluetooth/hci_core.h |   3 +
 net/bluetooth/hci_conn.c         |   6 +-
 net/bluetooth/hci_core.c         |  17 +++++
 net/bluetooth/hci_event.c        |  20 ++++++
 net/bluetooth/hci_request.c      | 119 ++++++++++++++++++++++++++-----
 net/bluetooth/hci_request.h      |   3 +-
 net/bluetooth/mgmt.c             |   2 +-
 8 files changed, 157 insertions(+), 21 deletions(-)

Comments

Sathish Narasimman June 8, 2020, 6:30 a.m. UTC | #1
Hi

On Wed, Jun 3, 2020 at 10:44 PM Sathish Narasimman <nsathish41@gmail.com> wrote:
>
> Based on the input the patches modified and verifed accordingly.
>
> Marcel Holtmann (3):
>   Bluetooth: Translate additional address type correctly
>   Bluetooth: Configure controller address resolution if available
>   Bluetooth: Update resolving list when updating whitelist
>
> Sathish Narasimman (4):
>   Bluetooth: Translate additional address type during le_conn
>   Bluetooth: Let controller creates RPA during le create conn
>   Bluetooth: Enable/Disable address resolution during le create conn
>   Bluetooth: Enable RPA Timeout
>
>  include/net/bluetooth/hci.h      |   8 ++-
>  include/net/bluetooth/hci_core.h |   3 +
>  net/bluetooth/hci_conn.c         |   6 +-
>  net/bluetooth/hci_core.c         |  17 +++++
>  net/bluetooth/hci_event.c        |  20 ++++++
>  net/bluetooth/hci_request.c      | 119 ++++++++++++++++++++++++++-----
>  net/bluetooth/hci_request.h      |   3 +-
>  net/bluetooth/mgmt.c             |   2 +-
>  8 files changed, 157 insertions(+), 21 deletions(-)
>
> --
> 2.17.1
>

Gentle Reminder
Also, the present approach will only work for the central role.

I am planning to work in a peripheral role.
need help with a design approach on the peripheral.


Regards
Sathish N
Marcel Holtmann June 19, 2020, 7:58 a.m. UTC | #2
Hi Sathish,

> Based on the input the patches modified and verifed accordingly.
> 
> Marcel Holtmann (3):
>  Bluetooth: Translate additional address type correctly
>  Bluetooth: Configure controller address resolution if available
>  Bluetooth: Update resolving list when updating whitelist
> 
> Sathish Narasimman (4):
>  Bluetooth: Translate additional address type during le_conn
>  Bluetooth: Let controller creates RPA during le create conn
>  Bluetooth: Enable/Disable address resolution during le create conn
>  Bluetooth: Enable RPA Timeout
> 
> include/net/bluetooth/hci.h      |   8 ++-
> include/net/bluetooth/hci_core.h |   3 +
> net/bluetooth/hci_conn.c         |   6 +-
> net/bluetooth/hci_core.c         |  17 +++++
> net/bluetooth/hci_event.c        |  20 ++++++
> net/bluetooth/hci_request.c      | 119 ++++++++++++++++++++++++++-----
> net/bluetooth/hci_request.h      |   3 +-
> net/bluetooth/mgmt.c             |   2 +-
> 8 files changed, 157 insertions(+), 21 deletions(-)

can you please rebase this against the latest bluetooth-next tree. With the introduction of the advertising monitor, we now have a few conflicts that you need to resolve.

Also as discussed, we wanted to hide this initially after an experimental feature flag so it would need to be enabled first. And I think once enabled, we need to take the support of “advertising” aka peripheral away from the controller until we can fully ensure it works for scanning and advertising at the same time.

Regards

Marcel
Sathish Narasimman July 1, 2020, 10:02 a.m. UTC | #3
Hi Marcel

On Fri, Jun 19, 2020 at 1:28 PM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Sathish,
>
> > Based on the input the patches modified and verifed accordingly.
> >
> > Marcel Holtmann (3):
> >  Bluetooth: Translate additional address type correctly
> >  Bluetooth: Configure controller address resolution if available
> >  Bluetooth: Update resolving list when updating whitelist
> >
> > Sathish Narasimman (4):
> >  Bluetooth: Translate additional address type during le_conn
> >  Bluetooth: Let controller creates RPA during le create conn
> >  Bluetooth: Enable/Disable address resolution during le create conn
> >  Bluetooth: Enable RPA Timeout
> >
> > include/net/bluetooth/hci.h      |   8 ++-
> > include/net/bluetooth/hci_core.h |   3 +
> > net/bluetooth/hci_conn.c         |   6 +-
> > net/bluetooth/hci_core.c         |  17 +++++
> > net/bluetooth/hci_event.c        |  20 ++++++
> > net/bluetooth/hci_request.c      | 119 ++++++++++++++++++++++++++-----
> > net/bluetooth/hci_request.h      |   3 +-
> > net/bluetooth/mgmt.c             |   2 +-
> > 8 files changed, 157 insertions(+), 21 deletions(-)
>
> can you please rebase this against the latest bluetooth-next tree. With the introduction of the advertising monitor, we now have a few conflicts that you need to resolve.
>
> Also as discussed, we wanted to hide this initially after an experimental feature flag so it would need to be enabled first. And I think once enabled, we need to take the support of “advertising” aka peripheral away from the controller until we can fully ensure it works for scanning and advertising at the same time.

Updated the v3  rebased and the flag is introduced to enable LL
privacy from the host using mgmt set_privacy interface.

what I understood regarding removing of advertising was when we enable
LL privacy using mgmt interface. the advertisement should not work
(correct me please).

>
> Regards
>
> Marcel
>

Regards
Sathish N