From patchwork Tue Nov 22 17:44:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas Gleixner X-Patchwork-Id: 13052607 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBCF1C4332F for ; Tue, 22 Nov 2022 17:44:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232909AbiKVRot (ORCPT ); Tue, 22 Nov 2022 12:44:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231808AbiKVRor (ORCPT ); Tue, 22 Nov 2022 12:44:47 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DBA0D9F; Tue, 22 Nov 2022 09:44:46 -0800 (PST) Message-ID: <20221122171312.191765396@linutronix.de> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1669139084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=POzOynlARSCDWGTOOqHnlCYCC6vCHB34Df8+dSsmA8w=; b=n4d8ksAiiBOB/GiR6goaaHimi7sHyXMi9NrCbE5iQSzoOQkNnPW3npgeuXLOY1LNkZdv+5 /miK6EuKmhbFkWBh5AXzRkus5gVDfJPrnXj+iVOMNOeI0W6Z+azDx9gH50MDlVa/2aiNaw X4AROGyxUrfk3KAYYlto7xQiSvNWXfa3t9leNIcT+UdA2Dv6+pg2nW/JqtX0iuc2GJQyHv hD+LRAU5Zjg1R1isaWh4DyIR17k7sTS9kivki+zk+p8tnpC0SLNec4QkD8wftVHQdjMidZ 1Begitcm/eVIzhCdBhfqaZ8D3dZQlzqeXcs3s1OJBKt1xC08RYnQ4eAsatOv2Q== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1669139084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc; bh=POzOynlARSCDWGTOOqHnlCYCC6vCHB34Df8+dSsmA8w=; b=rvixnL7+gnPzgGtSHp+QMSlFli6vU24L4I6ICdNCiY6IxhqE4flOOpILGRvcdmkVIchlrf M8a+5IF6MY//wFCA== From: Thomas Gleixner To: LKML Cc: Linus Torvalds , Steven Rostedt , Anna-Maria Behnsen , Peter Zijlstra , Stephen Boyd , Guenter Roeck , Andrew Morton , Julia Lawall , Arnd Bergmann , Viresh Kumar , Marc Zyngier , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , linux-bluetooth@vger.kernel.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org Subject: [patch V2 00/17] timers: Provide timer_shutdown[_sync]() Date: Tue, 22 Nov 2022 18:44:44 +0100 (CET) Precedence: bulk List-ID: X-Mailing-List: linux-bluetooth@vger.kernel.org This is the second version of the timer shutdown work. The first version can be found here: https://lore.kernel.org/all/20221115195802.415956561@linutronix.de Tearing down timers can be tedious when there are circular dependencies to other things which need to be torn down. A prime example is timer and workqueue where the timer schedules work and the work arms the timer. Steven and the Google Chromebook team ran into such an issue in the Bluetooth HCI code. Steven suggested to create a new function del_timer_free() which marks the timer as shutdown. Rearm attempts of shutdown timers are discarded and he wanted to emit a warning for that case: https://lore.kernel.org/all/20220407161745.7d6754b3@gandalf.local.home This resulted in a lengthy discussion and suggestions how this should be implemented. The patch series went through several iterations and during the review of the last version it turned out that this approach is suboptimal: https://lore.kernel.org/all/20221110064101.429013735@goodmis.org The warning is not really helpful because it's entirely unclear how it should be acted upon. The only way to address such a case is to add 'if (in_shutdown)' conditionals all over the place. This is error prone and in most cases of teardown like the HCI one which started this discussion not required all. What needs to prevented is that pending work which is drained via destroy_workqueue() does not rearm the previously shutdown timer. Nothing in that shutdown sequence relies on the timer being functional. The conclusion was that the semantics of timer_shutdown_sync() should be: - timer is not enqueued - timer callback is not running - timer cannot be rearmed Preventing the rearming of shutdown timers is done by discarding rearm attempts silently. As Steven is short of cycles, I made some spare cycles available and reworked the patch series to follow the new semantics and plugged the races which were discovered during review. The patches have been split up into small pieces to make review easier and I took the liberty to throw a bunch of overdue cleanups into the picture instead of proliferating the existing state further. The last patch in the series addresses the HCI teardown issue for real. The series is also available from git: git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git timers Changes vs. V1: - Fixed the return vs. continue bug in the timer expiration code (Steven) - Addressed the review vs. function documentation (Steven) - Fixed up the del_timer*() references in documentation (Steven) - Split out the 'remove bogus claims about del_timer_sync()' change - Picked up Reviewed/Tested-by tags where appropriate Thanks, tglx Reviewed-by: Jacob Keller --- Documentation/RCU/Design/Requirements/Requirements.rst | 2 Documentation/core-api/local_ops.rst | 2 Documentation/kernel-hacking/locking.rst | 17 Documentation/timers/hrtimers.rst | 2 Documentation/translations/it_IT/kernel-hacking/locking.rst | 14 Documentation/translations/zh_CN/core-api/local_ops.rst | 2 arch/arm/mach-spear/time.c | 8 drivers/bluetooth/hci_qca.c | 10 drivers/char/tpm/tpm-dev-common.c | 4 drivers/clocksource/arm_arch_timer.c | 12 drivers/clocksource/timer-sp804.c | 6 drivers/staging/wlan-ng/hfa384x_usb.c | 4 drivers/staging/wlan-ng/prism2usb.c | 6 include/linux/timer.h | 35 kernel/time/timer.c | 424 +++++++++--- net/sunrpc/xprt.c | 2 16 files changed, 404 insertions(+), 146 deletions(-)