mbox series

[v6,0/2] Bluetooth: btrtl: add support for the RTL8723CS

Message ID 20230307221732.3391-1-bage@debian.org (mailing list archive)
Headers show
Series Bluetooth: btrtl: add support for the RTL8723CS | expand

Message

Bastian Germann March 7, 2023, 10:17 p.m. UTC 
Pinebook uses RTL8723CS for WiFi and bluetooth. Unfortunately, RTL8723CS
has broken BT-4.1 support, so it requires a quirk.

Add a quirk and wire up 8723CS support in btrtl.
I was asked for a btmon output without the quirk;
however, using the chip without the quirk ends up in a bad state with
"Opcode 0x c77 failed: -56" (HCI_OP_READ_SYNC_TRAIN_PARAMS) on training.
A btmon output with the quirk active was already sent by Vasily.

v1 of this series was sent in July 2020 by Vasily Khoruzhick.
I have tested it to work on the Pinebook.

Changelog:
v2:
   * Rebase
   * Add uart-has-rtscts to device tree as requested by reviewer
v3:
   * Drop the device tree as it was split out and is already integrated.
   * Rename the quirk as requested by reviewer Marcel Holtmann
v4:
   * Use skb_pull_data as requested by reviewer Luiz Augusto von Dentz
v5:
   * Make use of skb_pull_data's length check
v6:
   * Warn on active quirk

Vasily Khoruzhick (2):
  Bluetooth: Add new quirk for broken local ext features page 2
  Bluetooth: btrtl: add support for the RTL8723CS

 drivers/bluetooth/btrtl.c   | 120 ++++++++++++++++++++++++++++++++++--
 drivers/bluetooth/btrtl.h   |   5 ++
 drivers/bluetooth/hci_h5.c  |   4 ++
 include/net/bluetooth/hci.h |   7 +++
 net/bluetooth/hci_event.c   |   9 ++-
 5 files changed, 139 insertions(+), 6 deletions(-)

Comments

patchwork-bot+bluetooth@kernel.org March 14, 2023, 11:10 p.m. UTC | #1 
Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue,  7 Mar 2023 23:17:29 +0100 you wrote:
> Pinebook uses RTL8723CS for WiFi and bluetooth. Unfortunately, RTL8723CS
> has broken BT-4.1 support, so it requires a quirk.
> 
> Add a quirk and wire up 8723CS support in btrtl.
> I was asked for a btmon output without the quirk;
> however, using the chip without the quirk ends up in a bad state with
> "Opcode 0x c77 failed: -56" (HCI_OP_READ_SYNC_TRAIN_PARAMS) on training.
> A btmon output with the quirk active was already sent by Vasily.
> 
> [...]

Here is the summary with links:
  - [v6,1/2] Bluetooth: Add new quirk for broken local ext features page 2
    https://git.kernel.org/bluetooth/bluetooth-next/c/000b57d5c009
  - [v6,2/2] Bluetooth: btrtl: add support for the RTL8723CS
    https://git.kernel.org/bluetooth/bluetooth-next/c/b8e482d02513

You are awesome, thank you!