mbox series

[v2,0/6] Add initial support for BAP broadcast source

Message ID 20230525153452.125789-1-silviu.barbulescu@nxp.com (mailing list archive)
Headers show
Series Add initial support for BAP broadcast source | expand

Message

Silviu Florian Barbulescu May 25, 2023, 3:34 p.m. UTC 
This patch adds initial support for BAP broadcast source.

The current implementation allows BAP source endpoint registration,
media transport creation, transport acquiring and sending broadcast ISO data.

Currently, one BIG containing one BIS is supported.

To test the current implementation use bluetoothctl with the following commands:
# endpoint.register 00001852-0000-1000-8000-00805f9b34fb 0x06
# transport.acquire /org/bluez/hci0/dev_00_00_00_00_00_00/pac_broadcast0/fd0
# transport.send /org/bluez/hci0/dev_00_00_00_00_00_00/pac_broadcast0/fd0 <file.wav>

The curent implementation checks that ISO_BROADCASTER is suported on the board so
"Check for ISO support in controller" patch is required
(https://patchwork.kernel.org/project/bluetooth/patch/20230510134557.11486-2-claudia.rosu@nxp.com/)

Silviu Florian Barbulescu (6):
  Update Docs for BAP broadcast source
  Add macro definitions for BAP broadcast source support
  Check for ISO broadcast support in controller
  Add support for setsockopt (BT_IO_OPT_BASE)
  Update bluetoothctl with support for broadcast source
  Add initial support for BAP broadcast source

 btio/btio.c                |  26 ++-
 btio/btio.h                |   2 +
 client/player.c            | 209 +++++++++++++++--
 doc/media-api.txt          |  11 +
 doc/mgmt-api.txt           |   2 +
 lib/bluetooth.h            |   9 +
 lib/mgmt.h                 |   2 +
 lib/uuid.h                 |   3 +
 monitor/packet.c           |   4 +-
 profiles/audio/bap.c       | 455 ++++++++++++++++++++++++++++++++-----
 profiles/audio/media.c     | 129 +++++++++--
 profiles/audio/transport.c |  51 +++--
 src/shared/bap.c           | 324 +++++++++++++++++++-------
 src/shared/bap.h           |  81 +++++--
 unit/test-bap.c            |  83 +++----
 15 files changed, 1121 insertions(+), 270 deletions(-)


base-commit: 718f27d09fc129d0b94ef61192482ac7e18cbaed

Comments

patchwork-bot+bluetooth@kernel.org May 26, 2023, 10:10 p.m. UTC | #1 
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 25 May 2023 18:34:46 +0300 you wrote:
> This patch adds initial support for BAP broadcast source.
> 
> The current implementation allows BAP source endpoint registration,
> media transport creation, transport acquiring and sending broadcast ISO data.
> 
> Currently, one BIG containing one BIS is supported.
> 
> [...]

Here is the summary with links:
  - [v2,1/6] Update Docs for BAP broadcast source
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f808fa065396
  - [v2,2/6] Add macro definitions for BAP broadcast source support
    (no matching commit)
  - [v2,3/6] Check for ISO broadcast support in controller
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=97f3386268fa
  - [v2,4/6] Add support for setsockopt (BT_IO_OPT_BASE)
    (no matching commit)
  - [v2,5/6] Update bluetoothctl with support for broadcast source
    (no matching commit)
  - [v2,6/6] Add initial support for BAP broadcast source
    (no matching commit)

You are awesome, thank you!
Luiz Augusto von Dentz May 26, 2023, 10:37 p.m. UTC | #2 
Hi Silviu,

On Fri, May 26, 2023 at 3:22 PM <patchwork-bot+bluetooth@kernel.org> wrote:
>
> Hello:
>
> This series was applied to bluetooth/bluez.git (master)
> by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
>
> On Thu, 25 May 2023 18:34:46 +0300 you wrote:
> > This patch adds initial support for BAP broadcast source.
> >
> > The current implementation allows BAP source endpoint registration,
> > media transport creation, transport acquiring and sending broadcast ISO data.
> >
> > Currently, one BIG containing one BIS is supported.
> >
> > [...]
>
> Here is the summary with links:
>   - [v2,1/6] Update Docs for BAP broadcast source
>     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=f808fa065396
>   - [v2,2/6] Add macro definitions for BAP broadcast source support
>     (no matching commit)
>   - [v2,3/6] Check for ISO broadcast support in controller
>     https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=97f3386268fa
>   - [v2,4/6] Add support for setsockopt (BT_IO_OPT_BASE)
>     (no matching commit)
>   - [v2,5/6] Update bluetoothctl with support for broadcast source
>     (no matching commit)
>   - [v2,6/6] Add initial support for BAP broadcast source
>     (no matching commit)
>
> You are awesome, thank you!

So Ive pushed changes up to 4/6, the last 2 have a lot of coding style
problems so please fix them, and I'd still recommend you to split
those as much as possible to make it easier to review.
patchwork-bot+bluetooth@kernel.org May 26, 2023, 10:40 p.m. UTC | #3 
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu, 25 May 2023 18:34:46 +0300 you wrote:
> This patch adds initial support for BAP broadcast source.
> 
> The current implementation allows BAP source endpoint registration,
> media transport creation, transport acquiring and sending broadcast ISO data.
> 
> Currently, one BIG containing one BIS is supported.
> 
> [...]

Here is the summary with links:
  - [v2,1/6] Update Docs for BAP broadcast source
    (no matching commit)
  - [v2,2/6] Add macro definitions for BAP broadcast source support
    (no matching commit)
  - [v2,3/6] Check for ISO broadcast support in controller
    (no matching commit)
  - [v2,4/6] Add support for setsockopt (BT_IO_OPT_BASE)
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=7002ecc8914a
  - [v2,5/6] Update bluetoothctl with support for broadcast source
    (no matching commit)
  - [v2,6/6] Add initial support for BAP broadcast source
    (no matching commit)

You are awesome, thank you!