mbox series

[BlueZ,v2,0/1] mgmt: Fix crash after pair command

Message ID 20231219062801.307-1-vinit.mehta@nxp.com (mailing list archive)
Headers show
Series mgmt: Fix crash after pair command | expand

Message

Vinit Mehta Dec. 19, 2023, 6:28 a.m. UTC 
Hello Maintainers

This patch fixes assertion in bluetoothctl client process

After pair command, if the user doesn't provide any input on bluetoothctl
CLI interface after receiving the prompt(yes/no), than subsequent CLI 
command will trigger a call to DBUS library function 
(dbus_message_get_no_reply) with a NULL message pointer which triggers
assertion in DBUS library causing the bluetoothctl process to crash. 
The change is done in confirm_response callback to trigger a DBUS
API error call only if the pending_message pointer is not NULL so 
as to avoid the assertion.

Thank you in advance for your review.

Warm Regards
Vinit Mehta

Vinit Mehta (1):
  mgmt: Fix crash after pair command

 client/agent.c | 15 +++++++++------
 client/mgmt.c  | 12 +++++++++---
 2 files changed, 18 insertions(+), 9 deletions(-)

Comments

patchwork-bot+bluetooth@kernel.org Jan. 3, 2024, 9:10 p.m. UTC | #1 
Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Tue, 19 Dec 2023 11:58:00 +0530 you wrote:
> Hello Maintainers
> 
> This patch fixes assertion in bluetoothctl client process
> 
> After pair command, if the user doesn't provide any input on bluetoothctl
> CLI interface after receiving the prompt(yes/no), than subsequent CLI
> command will trigger a call to DBUS library function
> (dbus_message_get_no_reply) with a NULL message pointer which triggers
> assertion in DBUS library causing the bluetoothctl process to crash.
> The change is done in confirm_response callback to trigger a DBUS
> API error call only if the pending_message pointer is not NULL so
> as to avoid the assertion.
> 
> [...]

Here is the summary with links:
  - [BlueZ,v2,1/1] mgmt: Fix crash after pair command
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=60d60166e4bf

You are awesome, thank you!