[BlueZ,00/14] Fix a number of static analysis issues

Message

Bastien Nocera May 10, 2024, 9:10 a.m. UTC

Hello,

This is the first batch of bug fixes for issues found by Red Hat's
internal static analysis tools.

The best course of action would probably be to merge the one that
are ready for upstream inclusion after review, and mark the others as
needing work, so I can include a new version of the patch in following
batches.

Cheers

Bastien Nocera (14):
  adapter: Use false instead of 0 for bool
  attrib/gatt: Guard against possible integer overflow
  client/gatt: Don't pass negative fd on error
  client/gatt: Check write_value() retval
  client/main: Fix array access
  client/main: Fix mismatched free
  monitor/att: Fix memory leak
  bap: Fix memory leaks
  media: Fix memory leak
  main: Fix memory leaks
  isotest: Consider "0" fd to be valid
  isotest: Fix error check after opening file
  client/player: Fix copy/paste error
  shared/vcp: Fix copy/paste error

 attrib/gatt.c          |  8 ++++---
 client/gatt.c          | 21 +++++++++++++++----
 client/main.c          |  7 ++++++-
 client/player.c        |  2 +-
 monitor/att.c          | 19 +++++++++++++++++
 profiles/audio/bap.c   | 47 +++++++++++++++++++++++++++++-------------
 profiles/audio/media.c |  1 +
 src/adapter.c          |  2 +-
 src/main.c             |  4 ++++
 src/shared/vcp.c       |  2 +-
 tools/isotest.c        |  4 ++--
 11 files changed, 90 insertions(+), 27 deletions(-)