| Message ID | 20240916132813.165731-1-frederic.danis@collabora.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add BIP for AVRCP covert art OBEX client | expand |
Hello: This series was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 16 Sep 2024 15:28:04 +0200 you wrote: > If AVRCP Target supports Cover Art download its SDP record contains an > additional access protocol for OBEX with an LCAP PSM on which the OBEX > client session should connect to, with the specific OBEX target header > 7163DD54-4A7E-11E2-B47C-0050C2490048. > > Once the OBEX session is connected, the AVRCP track metadata will contain > an Image Handle which can be used to get the associated image using > GetImageThumbnail or GetImage with one of the description property found > with GetImageProperties. > > [...] Here is the summary with links: - [BlueZ,v3,1/9] obexd: Add PSM support to session create https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5d7d3ac25bd5 - [BlueZ,v3,2/9] player: Add OBEX PSM port for cover art support https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=4c05a0ff41c8 - [BlueZ,v3,3/9] player: Add image handle support property https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=5cd301e888a1 - [BlueZ,v3,4/9] obexd: Add support for specific headers in obex transfer https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=8562d0e3874e - [BlueZ,v3,5/9] obexd: Add BIP client for AVRCP cover art download (no matching commit) - [BlueZ,v3,6/9] obexd: Add GetImageProperties to bip-avrcp (no matching commit) - [BlueZ,v3,7/9] obexd: Add GetImage to bip-avrcp (no matching commit) - [BlueZ,v3,8/9] avrcp: Update controller SDP record with cover art support (no matching commit) - [BlueZ,v3,9/9] doc: Add description of org.bluez.obex.BipAvrcp (no matching commit) You are awesome, thank you!
If AVRCP Target supports Cover Art download its SDP record contains an additional access protocol for OBEX with an LCAP PSM on which the OBEX client session should connect to, with the specific OBEX target header 7163DD54-4A7E-11E2-B47C-0050C2490048. Once the OBEX session is connected, the AVRCP track metadata will contain an Image Handle which can be used to get the associated image using GetImageThumbnail or GetImage with one of the description property found with GetImageProperties. This has been tested with iPhone 14, iPhone 15 Pro and Samsung S23. v1 -> v2: Parse integer properties as integer instead of string Return GetImageProperties values as aa{sv} instead of aa{ss} Get properties for GetImage as a{sv} instead of a{ss} Set new properties and interface as experimental v2 -> v3: Rename obexd/client/bip-avrcp.[ch] to obexd/client/bip.[ch] Update the AVRCP Controller version in SDP to 1.6 Add commit to support for specific headers in obex transfer Fix memory leaks Frédéric Danis (9): obexd: Add PSM support to session create player: Add OBEX PSM port for cover art support player: Add image handle support property obexd: Add support for specific headers in obex transfer obexd: Add BIP client for AVRCP cover art download obexd: Add GetImageProperties to bip-avrcp obexd: Add GetImage to bip-avrcp avrcp: Update controller SDP record with cover art support doc: Add description of org.bluez.obex.BipAvrcp Makefile.am | 9 +- Makefile.obexd | 2 + doc/org.bluez.MediaPlayer.rst | 11 + doc/org.bluez.obex.BipAvrcp.rst | 72 +++ doc/org.bluez.obex.Client.rst | 5 + doc/org.bluez.obex.Session.rst | 5 + monitor/avctp.c | 3 + obexd/client/bip-common.c | 800 ++++++++++++++++++++++++++++++++ obexd/client/bip-common.h | 24 + obexd/client/bip.c | 440 ++++++++++++++++++ obexd/client/bip.h | 12 + obexd/client/manager.c | 16 +- obexd/client/session.c | 27 +- obexd/client/session.h | 1 + obexd/client/transfer.c | 19 + obexd/client/transfer.h | 2 + profiles/audio/avrcp.c | 66 ++- profiles/audio/avrcp.h | 3 +- profiles/audio/player.c | 30 ++ profiles/audio/player.h | 1 + tools/parser/avrcp.c | 3 + 21 files changed, 1531 insertions(+), 20 deletions(-) create mode 100644 doc/org.bluez.obex.BipAvrcp.rst create mode 100644 obexd/client/bip-common.c create mode 100644 obexd/client/bip-common.h create mode 100644 obexd/client/bip.c create mode 100644 obexd/client/bip.h