mbox series

[BlueZ,v2,0/2] Add constant for 16 bits transparent voice

Message ID 20241216184613.135538-1-frederic.danis@collabora.com (mailing list archive)
Headers show
Series Add constant for 16 bits transparent voice | expand

Message

Frédéric Danis Dec. 16, 2024, 6:46 p.m. UTC 
Add 16 bits, 2s complement, transparent air coding format for mSBC.
Corresponding commit implements functionality on kernel side.

The voice setting is used by sco_connect() or sco_conn_defer_accept()
after being set by sco_sock_setsockopt().

The PCM part of the voice setting is used for offload mode through PCM
chipset port.
This commits add support for mSBC 16 bits offloading, i.e. audio data
not transported over HCI.

The BCM4349B1 supports 16 bits transparent data on its I2S port.
If BT_VOICE_TRANSPARENT is used when accepting a SCO connection, this
gives only garbage audio while using BT_VOICE_TRANSPARENT_16BIT gives
correct audio.
This has been tested with connection to iPhone 14 and Samsung S24.

This also adds a test to checks that BT_VOICE_TRANSPARENT_16BIT voice
settings can be set and get using [set|get]sockopt().

v1 -> v2: Add test to tools/sco-tester

Frédéric Danis (2):
  lib: Add constant for 16 bits transparent voice setting
  sco-tester: Add test for BT_VOICE_TRANSPARENT_16BIT constant

 lib/bluetooth.h    |  1 +
 tools/sco-tester.c | 28 ++++++++++++++++++++++++++++
 2 files changed, 29 insertions(+)

Comments

patchwork-bot+bluetooth@kernel.org Dec. 16, 2024, 9:50 p.m. UTC | #1 
Hello:

This series was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Mon, 16 Dec 2024 19:46:11 +0100 you wrote:
> Add 16 bits, 2s complement, transparent air coding format for mSBC.
> Corresponding commit implements functionality on kernel side.
> 
> The voice setting is used by sco_connect() or sco_conn_defer_accept()
> after being set by sco_sock_setsockopt().
> 
> The PCM part of the voice setting is used for offload mode through PCM
> chipset port.
> This commits add support for mSBC 16 bits offloading, i.e. audio data
> not transported over HCI.
> 
> [...]

Here is the summary with links:
  - [BlueZ,v2,1/2] lib: Add constant for 16 bits transparent voice setting
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9b631e09e943
  - [BlueZ,v2,2/2] sco-tester: Add test for BT_VOICE_TRANSPARENT_16BIT constant
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ff07f10ee4da

You are awesome, thank you!