mbox series

[v2,0/4] LE Set CIG Parameters / Create CIS fixes

Message ID cover.1685565568.git.pav@iki.fi (mailing list archive)
Headers show
Series LE Set CIG Parameters / Create CIS fixes | expand

Message

Pauli Virtanen June 1, 2023, 6:34 a.m. UTC
This patchset fixes a few issues with emission of HCI Remove CIG, Set
CIG Parameters, Create CIS when multiple ISO sockets in the same CIG are
closed and reconnected rapidly.

v2: Dropped patches that added error checking in hci_le_set_cig_params,
    TBD separately later.  Returning errors there triggers some race
    condition in the emulator when it's cleaning up the connections, which
    needs some more looking.

    Simplified the Set CIG Parameters event parsing.

    The patches here now are enough to make the test suite pass, and
    enough to fix the race conditions encountered in BlueZ ISO ops.

Pauli Virtanen (4):
  Bluetooth: ISO: use hci_sync for setting CIG parameters
  Bluetooth: ISO: don't try to remove CIG if there are bound CIS left
  Bluetooth: ISO: use correct CIS order in Set CIG Parameters event
  Bluetooth: ISO: do not emit new LE Create CIS if previous is pending

 include/net/bluetooth/hci_core.h |   4 +-
 include/net/bluetooth/hci_sync.h |   2 +-
 net/bluetooth/hci_conn.c         | 123 ++++++++++++++++++-------------
 net/bluetooth/hci_event.c        |  72 +++++++++++++-----
 net/bluetooth/hci_sync.c         |  90 +++++++++++++++-------
 net/bluetooth/iso.c              |   2 +-
 6 files changed, 193 insertions(+), 100 deletions(-)

Comments

patchwork-bot+bluetooth@kernel.org June 2, 2023, 8:30 p.m. UTC | #1
Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Thu,  1 Jun 2023 09:34:42 +0300 you wrote:
> This patchset fixes a few issues with emission of HCI Remove CIG, Set
> CIG Parameters, Create CIS when multiple ISO sockets in the same CIG are
> closed and reconnected rapidly.
> 
> v2: Dropped patches that added error checking in hci_le_set_cig_params,
>     TBD separately later.  Returning errors there triggers some race
>     condition in the emulator when it's cleaning up the connections, which
>     needs some more looking.
> 
> [...]

Here is the summary with links:
  - [v2,1/4] Bluetooth: ISO: use hci_sync for setting CIG parameters
    https://git.kernel.org/bluetooth/bluetooth-next/c/f0393238e391
  - [v2,2/4] Bluetooth: ISO: don't try to remove CIG if there are bound CIS left
    https://git.kernel.org/bluetooth/bluetooth-next/c/59b32ee40f50
  - [v2,3/4] Bluetooth: ISO: use correct CIS order in Set CIG Parameters event
    (no matching commit)
  - [v2,4/4] Bluetooth: ISO: do not emit new LE Create CIS if previous is pending
    (no matching commit)

You are awesome, thank you!