[v3,0/3] Bluetooth: ISO-related concurrency fixes

Message

Pauli Virtanen June 18, 2023, 10:04 p.m. UTC

This series addresses some concurrency issues (NULL / GPF) in ISO
sockets or related.

v3:
- Copy the pend_le_* lists, iterate over copy to make it simple.
- Rename to hci_pend_le_list_*

v2:
- Use RCU for the pend_le_* lists, avoid using hci_dev_lock.
- Always call disconn_cfm before hci_conn_del.

These were found while testing patches that make hci_le_set_cig_params
check the validity of the configuration and return false if incorrect.
This causes dropping of hci_conn just created, which apparently makes
hitting race conditions easier.

The test setup was primitive

while true; do bluetoothctl power on; sleep 12; bluetoothctl power off; sleep 1.5; bluetoothctl power off; sleep 2.5; done;
while true; do sudo systemctl restart bluetooth; sleep 110; done
while true; do systemctl --user restart pipewire wireplumber pipewire-pulse; sleep 91; done
while true; do paplay sample.flac & sleep 2; kill %1; sleep 0.7; done

and equivalent operations manually, on VM + connect to TWS earbuds. This
eventually hit the NULL / GFP errors here, but they are hard to
reproduce aside from the first one that appears in iso-tester.

Pauli Virtanen (3):
  Bluetooth: use RCU for hci_conn_params and iterate safely in hci_sync
  Bluetooth: hci_event: call disconnect callback before deleting conn
  Bluetooth: ISO: fix iso_conn related locking and validity issues

 include/net/bluetooth/hci_core.h |   5 ++
 net/bluetooth/hci_conn.c         |  10 +--
 net/bluetooth/hci_core.c         |  38 ++++++++--
 net/bluetooth/hci_event.c        |  15 ++--
 net/bluetooth/hci_sync.c         | 117 ++++++++++++++++++++++++++++---
 net/bluetooth/iso.c              |  53 ++++++++------
 net/bluetooth/mgmt.c             |  26 +++----
 7 files changed, 198 insertions(+), 66 deletions(-)

Comments

[e-mail] June 20, 2023, 6:30 p.m. UTC | #1

Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[e-mail]>:

On Mon, 19 Jun 2023 01:04:30 +0300 you wrote:
> This series addresses some concurrency issues (NULL / GPF) in ISO
> sockets or related.
> 
> v3:
> - Copy the pend_le_* lists, iterate over copy to make it simple.
> - Rename to hci_pend_le_list_*
> 
> [...]

Here is the summary with links:
  - [v3,1/3] Bluetooth: use RCU for hci_conn_params and iterate safely in hci_sync
    https://git.kernel.org/bluetooth/bluetooth-next/c/7b48b117e516
  - [v3,2/3] Bluetooth: hci_event: call disconnect callback before deleting conn
    https://git.kernel.org/bluetooth/bluetooth-next/c/e61a5be1d421
  - [v3,3/3] Bluetooth: ISO: fix iso_conn related locking and validity issues
    https://git.kernel.org/bluetooth/bluetooth-next/c/d9687da53dab

You are awesome, thank you!