| Message ID | 09755693e7900757286d3dc9fd181f8591c21a19.1710099560.git.pav@iki.fi (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c9dddb642663b8bafe8998fef6132a2bb36d609d |
| Headers | show |
| Series | [BlueZ] shared/bap: fix setting io on linked stream | expand |
| Context | Check | Description |
|---|---|---|
| tedd_an/pre-ci_am | success | Success |
| tedd_an/CheckPatch | warning | WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #93: bluetoothd[588207]: < ACL Data TX: Handle 2048 flags 0x00 dlen 11 #492 [hci1] /github/workspace/src/src/13588192.patch total: 0 errors, 1 warnings, 8 lines checked NOTE: For some of the reported defects, checkpatch may be able to mechanically convert to the typical style using --fix or --fix-inplace. /github/workspace/src/src/13588192.patch has style problems, please review. NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO NOTE: If any of the errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. |
| tedd_an/GitLint | success | Gitlint PASS |
| tedd_an/BuildEll | success | Build ELL PASS |
| tedd_an/BluezMake | success | Bluez Make PASS |
| tedd_an/MakeCheck | success | Bluez Make Check PASS |
| tedd_an/MakeDistcheck | success | Make Distcheck PASS |
| tedd_an/CheckValgrind | success | Check Valgrind PASS |
| tedd_an/CheckSmatch | success | CheckSparse PASS |
| tedd_an/bluezmakeextell | success | Make External ELL PASS |
| tedd_an/IncrementalBuild | success | Incremental Build PASS |
| tedd_an/ScanBuild | success | Scan Build PASS |
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=834154
---Test result---
Test Summary:
CheckPatch FAIL 0.54 seconds
GitLint PASS 0.27 seconds
BuildEll PASS 23.86 seconds
BluezMake PASS 1602.92 seconds
MakeCheck PASS 13.67 seconds
MakeDistcheck PASS 171.82 seconds
CheckValgrind PASS 241.37 seconds
CheckSmatch PASS 341.37 seconds
bluezmakeextell PASS 116.55 seconds
IncrementalBuild PASS 1448.04 seconds
ScanBuild PASS 957.82 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ] shared/bap: fix setting io on linked stream
WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#93:
bluetoothd[588207]: < ACL Data TX: Handle 2048 flags 0x00 dlen 11 #492 [hci1]
/github/workspace/src/src/13588192.patch total: 0 errors, 1 warnings, 8 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13588192.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
Hello: This patch was applied to bluetooth/bluez.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Sun, 10 Mar 2024 21:40:33 +0200 you wrote: > Fix the second bap_stream_set_io call to set the io on the linked > transport, as it's clearly meant to. > > Fixes sending duplicate stream stop/start requests. > > bluetoothd[588207]: < ACL Data TX: Handle 2048 flags 0x00 dlen 11 #492 [hci1] > ATT: Write Command (0x52) len 6 > Handle: 0x0098 Type: ASE Control Point (0x2bc6) > Data: 04020505 > Opcode: Receiver Start Ready (0x04) > Number of ASE(s): 2 > ASE: #0 > ASE ID: 0x05 > ASE: #1 > ASE ID: 0x05 > > [...] Here is the summary with links: - [BlueZ] shared/bap: fix setting io on linked stream https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=c9dddb642663 You are awesome, thank you!
diff --git a/src/shared/bap.c b/src/shared/bap.c index 37fc1de4e..fd99cbbca 100644 --- a/src/shared/bap.c +++ b/src/shared/bap.c @@ -5603,7 +5603,7 @@ bool bt_bap_stream_set_io(struct bt_bap_stream *stream, int fd) bap_stream_set_io(stream, INT_TO_PTR(fd)); if (stream->link) - bap_stream_set_io(stream, INT_TO_PTR(fd)); + bap_stream_set_io(stream->link, INT_TO_PTR(fd)); return true; }
Fix the second bap_stream_set_io call to set the io on the linked transport, as it's clearly meant to. Fixes sending duplicate stream stop/start requests. bluetoothd[588207]: < ACL Data TX: Handle 2048 flags 0x00 dlen 11 #492 [hci1] ATT: Write Command (0x52) len 6 Handle: 0x0098 Type: ASE Control Point (0x2bc6) Data: 04020505 Opcode: Receiver Start Ready (0x04) Number of ASE(s): 2 ASE: #0 ASE ID: 0x05 ASE: #1 ASE ID: 0x05 --- src/shared/bap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)