diff mbox series

[01/12] net/Bluetooth/bnep - use the correct print format

Message ID 1621511073-47766-2-git-send-email-yekai13@huawei.com (mailing list archive)
State New, archived
Headers show
Series net/Bluetooth: correct the use of print format | expand

Commit Message

yekai (A) May 20, 2021, 11:44 a.m. UTC
According to Documentation/core-api/printk-formats.rst,
Use the correct print format. Printing an unsigned int value should use %u
instead of %d. Otherwise printk() might end up displaying negative numbers.

Signed-off-by: Kai Ye <yekai13@huawei.com>
---
 net/bluetooth/bnep/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

bluez.test.bot@gmail.com May 20, 2021, 1:32 p.m. UTC | #1
This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=485699

---Test result---

Test Summary:
CheckPatch                    FAIL      2.19 seconds
GitLint                       PASS      1.29 seconds
BuildKernel                   PASS      597.46 seconds
TestRunner: Setup             PASS      416.59 seconds
TestRunner: l2cap-tester      PASS      2.99 seconds
TestRunner: bnep-tester       PASS      2.09 seconds
TestRunner: mgmt-tester       PASS      30.29 seconds
TestRunner: rfcomm-tester     PASS      2.28 seconds
TestRunner: sco-tester        PASS      2.17 seconds
TestRunner: smp-tester        PASS      2.29 seconds
TestRunner: userchan-tester   PASS      2.13 seconds

Details
##############################
Test: CheckPatch - FAIL - 2.19 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
net/Bluetooth/bnep - use the correct print format
CHECK: Alignment should match open parenthesis
#22: FILE: net/bluetooth/bnep/core.c:130:
+			BT_DBG("proto filter start %u end %u",
 				f[i].start, f[i].end);

total: 0 errors, 0 warnings, 1 checks, 24 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] net/Bluetooth/bnep - use the correct print format" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

net/Bluetooth/cmtp - use the correct print format
CHECK: Alignment should match open parenthesis
#76: FILE: net/bluetooth/cmtp/capi.c:389:
+	BT_DBG("ctrl %p appl %u level3cnt %u datablkcnt %u datablklen %u",
 		ctrl, appl, rp->level3cnt, rp->datablkcnt, rp->datablklen);

total: 0 errors, 0 warnings, 1 checks, 80 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] net/Bluetooth/cmtp - use the correct print format" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.

net/Bluetooth/rfcomm - use the correct print format
CHECK: Alignment should match open parenthesis
#41: FILE: net/bluetooth/rfcomm/core.c:454:
+	BT_DBG("dlc %p state %lu dlci %u err %d session %p",
 			d, d->state, d->dlci, err, s);

CHECK: Alignment should match open parenthesis
#212: FILE: net/bluetooth/rfcomm/core.c:1368:
+	BT_DBG("dlc %p state %lu dlci %u mtu %u fc 0x%x credits %u",
 			d, d->state, d->dlci, pn->mtu, pn->flow_ctrl, pn->credits);

CHECK: Alignment should match open parenthesis
#266: FILE: net/bluetooth/rfcomm/core.c:1794:
+	BT_DBG("dlc %p state %lu cfc %u rx_credits %u tx_credits %u",
 			d, d->state, d->cfc, d->rx_credits, d->tx_credits);

total: 0 errors, 0 warnings, 3 checks, 313 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
      mechanically convert to the typical style using --fix or --fix-inplace.

"[PATCH] net/Bluetooth/rfcomm - use the correct print format" has style problems, please review.

NOTE: If any of the errors are false positives, please report
      them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - PASS - 1.29 seconds
Run gitlint with rule in .gitlint


##############################
Test: BuildKernel - PASS - 597.46 seconds
Build Kernel with minimal configuration supports Bluetooth


##############################
Test: TestRunner: Setup - PASS - 416.59 seconds
Setup environment for running Test Runner


##############################
Test: TestRunner: l2cap-tester - PASS - 2.99 seconds
Run test-runner with l2cap-tester
Total: 40, Passed: 40 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: bnep-tester - PASS - 2.09 seconds
Run test-runner with bnep-tester
Total: 1, Passed: 1 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: mgmt-tester - PASS - 30.29 seconds
Run test-runner with mgmt-tester
Total: 416, Passed: 403 (96.9%), Failed: 0, Not Run: 13

##############################
Test: TestRunner: rfcomm-tester - PASS - 2.28 seconds
Run test-runner with rfcomm-tester
Total: 9, Passed: 9 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: sco-tester - PASS - 2.17 seconds
Run test-runner with sco-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: smp-tester - PASS - 2.29 seconds
Run test-runner with smp-tester
Total: 8, Passed: 8 (100.0%), Failed: 0, Not Run: 0

##############################
Test: TestRunner: userchan-tester - PASS - 2.13 seconds
Run test-runner with userchan-tester
Total: 3, Passed: 3 (100.0%), Failed: 0, Not Run: 0



---
Regards,
Linux Bluetooth
diff mbox series

Patch

diff --git a/net/bluetooth/bnep/core.c b/net/bluetooth/bnep/core.c
index 43c2841..5898012 100644
--- a/net/bluetooth/bnep/core.c
+++ b/net/bluetooth/bnep/core.c
@@ -126,7 +126,7 @@  static int bnep_ctrl_set_netfilter(struct bnep_session *s, __be16 *data, int len
 			f[i].start = get_unaligned_be16(data++);
 			f[i].end   = get_unaligned_be16(data++);
 
-			BT_DBG("proto filter start %d end %d",
+			BT_DBG("proto filter start %u end %u",
 				f[i].start, f[i].end);
 		}
 
@@ -266,7 +266,7 @@  static int bnep_rx_extension(struct bnep_session *s, struct sk_buff *skb)
 			break;
 		}
 
-		BT_DBG("type 0x%x len %d", h->type, h->len);
+		BT_DBG("type 0x%x len %u", h->type, h->len);
 
 		switch (h->type & BNEP_TYPE_MASK) {
 		case BNEP_EXT_CONTROL:
@@ -424,7 +424,7 @@  static int bnep_tx_frame(struct bnep_session *s, struct sk_buff *skb)
 	int len = 0, il = 0;
 	u8 type = 0;
 
-	BT_DBG("skb %p dev %p type %d", skb, skb->dev, skb->pkt_type);
+	BT_DBG("skb %p dev %p type %u", skb, skb->dev, skb->pkt_type);
 
 	if (!skb->dev) {
 		/* Control frame sent by us */